* Re: [PATCH] s2io: fixing DBG_PRINT() macro
[not found] <1267623697-14781-1-git-send-email-leitao@linux.vnet.ibm.com>
@ 2010-03-05 14:21 ` Breno Leitao
0 siblings, 0 replies; only message in thread
From: Breno Leitao @ 2010-03-05 14:21 UTC (permalink / raw)
To: David Miller; +Cc: sreenivasa.honnur, joe, netdev
David,
Due my mistake I didn't send this patch to Sreenivasa. After
sending this patch to netdev, I forward to him, and
he acked it privately.
Sorry for the confusion.
Thanks,
Breno
leitao@linux.vnet.ibm.com wrote:
> Patch 9e39f7c5b311a306977c5471f9e2ce4c456aa038 changed the
> DBG_PRINT() macro and the if clause was changed. It means
> that currently all the DBG_PRINT are being printed, flooding
> the kernel log buffer with thinkgs like:
>
> s2io: eth6: Next block at: c0000000b9c90000
> s2io: eth6: In Neterion Tx routine
>
> This patch just fixes the if clause condition.
>
> Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>
> ---
> drivers/net/s2io.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/s2io.h b/drivers/net/s2io.h
> index 47c36e0..3b6f45d 100644
> --- a/drivers/net/s2io.h
> +++ b/drivers/net/s2io.h
> @@ -65,7 +65,7 @@ static int debug_level = ERR_DBG;
>
> /* DEBUG message print. */
> #define DBG_PRINT(dbg_level, fmt, args...) do { \
> - if (dbg_level >= debug_level) \
> + if (dbg_level <= debug_level) \
> pr_info(fmt, ##args); \
> } while (0)
>
^ permalink raw reply [flat|nested] only message in thread