All of lore.kernel.org
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: Compile problem due to compressor changes,	UART referenced in section .txt
Date: Mon, 08 Mar 2010 09:13:33 +1300	[thread overview]
Message-ID: <4B9408ED.4060901@bluewatersys.com> (raw)
In-Reply-To: <Prayer.1.3.2.1003071719080.2280@hermes-2.csi.cam.ac.uk>

J.I. Cameron wrote:
> Dear  All,
>
> Ran into the following problem on a pxa stargate2 platform (I think it
> will
> effect a number of others).
>
> `UART' referenced in section `.text' of
> arch/arm/boot/compressed/misc.o: defined in discarded section `.data'
> of arch/arm/boot/compressed/misc.o `UART' referenced in section
> `.text' of arch/arm/boot/compressed/misc.o: defined in discarded
> section `.data' of arch/arm/boot/compressed/misc.o
>
> There is a hack in mach-pxa/include/mach/uncompress.h
> that changes the primary uart for some platforms:
>
> static inline void arch_decomp_setup(void)
> {
>     if (machine_is_littleton() || machine_is_intelmote2()
>         || machine_is_csb726() || machine_is_stargate2()
>       || machine_is_cm_x300() || machine_is_balloon3())
>     UART = STUART;
> }
>
> Simply changing the initial assignment of UART and commenting this
> function
> out acts as a work around.  I'm not entirely sure how to fix the problem
> properly.
Perhaps something like this untested patch:

Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
---

diff --git a/arch/arm/mach-pxa/include/mach/uncompress.h b/arch/arm/mach-pxa/include/mach/uncompress.h
index 237734b..efd9c0d 100644
--- a/arch/arm/mach-pxa/include/mach/uncompress.h
+++ b/arch/arm/mach-pxa/include/mach/uncompress.h
@@ -15,7 +15,16 @@
 
 #define __REG(x)       ((volatile unsigned long *)x)
 
+#if defined(CONFIG_MACH_LITTLETON)  ||	\
+    defined(CONFIG_MACH_INTELMOTE2) ||	\
+    defined(CONFIG_MACH_CSB726)     ||	\
+    defined(CONFIG_MACH_STARGATE2)  ||	\
+    defined(CONFIG_MACH_CM_X300)    ||	\
+    defined(CONFIG_MACH_BALLOON3)
+static volatile unsigned long *UART = STUART;
+#else
 static volatile unsigned long *UART = FFUART;
+#endif
 
 static inline void putc(char c)
 {
@@ -35,10 +44,6 @@ static inline void flush(void)
 
 static inline void arch_decomp_setup(void)
 {
-	if (machine_is_littleton() || machine_is_intelmote2()
-	    || machine_is_csb726() || machine_is_stargate2()
-	    || machine_is_cm_x300() || machine_is_balloon3())
-		UART = STUART;
 }
 
 /*

  reply	other threads:[~2010-03-07 20:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-07 17:19 Compile problem due to compressor changes, UART referenced in section .txt J.I. Cameron
2010-03-07 20:13 ` Ryan Mallon [this message]
2010-03-08  9:55   ` Uwe Kleine-König
2010-03-08 10:14 ` Russell King - ARM Linux
2010-03-09  7:27   ` Mike Rapoport
2010-03-09 12:27     ` Jonathan Cameron
2010-03-09 13:00       ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9408ED.4060901@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.