From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: Compile problem due to compressor changes, UART referenced in section .txt
Date: Tue, 09 Mar 2010 09:27:27 +0200 [thread overview]
Message-ID: <4B95F85F.5090108@compulab.co.il> (raw)
In-Reply-To: <20100308101445.GA12363@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> On Sun, Mar 07, 2010 at 05:19:08PM +0000, J.I. Cameron wrote:
>> Dear All,
>>
>> Ran into the following problem on a pxa stargate2 platform (I think it will
>> effect a number of others).
>>
>> `UART' referenced in section `.text' of arch/arm/boot/compressed/misc.o:
>> defined in discarded section `.data' of arch/arm/boot/compressed/misc.o
>> `UART' referenced in section `.text' of arch/arm/boot/compressed/misc.o:
>> defined in discarded section `.data' of arch/arm/boot/compressed/misc.o
>>
>> There is a hack in mach-pxa/include/mach/uncompress.h
>> that changes the primary uart for some platforms:
>>
>> static inline void arch_decomp_setup(void)
>> {
>> if (machine_is_littleton() || machine_is_intelmote2()
>> || machine_is_csb726() || machine_is_stargate2()
>> || machine_is_cm_x300() || machine_is_balloon3())
>> UART = STUART;
>
> else
> UART = FFUART;
>
> and remove the initializer from UART.
Something like that:
Signed-off-by: Mike Rapoport <mike@compulab.co.il>
---
arch/arm/mach-pxa/include/mach/uncompress.h | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/include/mach/uncompress.h b/arch/arm/mach-pxa/include/mach/uncompress.h
index 237734b..b009299 100644
--- a/arch/arm/mach-pxa/include/mach/uncompress.h
+++ b/arch/arm/mach-pxa/include/mach/uncompress.h
@@ -15,7 +15,7 @@
#define __REG(x) ((volatile unsigned long *)x)
-static volatile unsigned long *UART = FFUART;
+static volatile unsigned long *UART;
static inline void putc(char c)
{
@@ -39,6 +39,8 @@ static inline void arch_decomp_setup(void)
|| machine_is_csb726() || machine_is_stargate2()
|| machine_is_cm_x300() || machine_is_balloon3())
UART = STUART;
+ else
+ UART = FFUART;
}
/*
--
1.6.4.4
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2010-03-09 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 17:19 Compile problem due to compressor changes, UART referenced in section .txt J.I. Cameron
2010-03-07 20:13 ` Ryan Mallon
2010-03-08 9:55 ` Uwe Kleine-König
2010-03-08 10:14 ` Russell King - ARM Linux
2010-03-09 7:27 ` Mike Rapoport [this message]
2010-03-09 12:27 ` Jonathan Cameron
2010-03-09 13:00 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B95F85F.5090108@compulab.co.il \
--to=mike@compulab.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.