From: Carsten Emde <Carsten.Emde@osadl.org>
To: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH] Revert "simplify equal priority logic for cyclictest"
Date: Mon, 08 Mar 2010 09:01:56 +0100 [thread overview]
Message-ID: <4B94AEF4.8050204@osadl.org> (raw)
In-Reply-To: <1268011104-22451-2-git-send-email-jkacur@redhat.com>
On 03/08/2010 02:18 AM, John Kacur wrote:
> Unfortunately this commit introduces a bug because the priority is not
> retested, and this can result in reported priorities below 0.
> [..]
> I think it can be argued that the original code is also clearer, although
> that is somewhat subjective. With the original code I don't need to track
> down exactly what "sameprio" means, and it is clear what is being tested.
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
Acked-by: Carsten Emde <C.Emde@osadl.org>
next prev parent reply other threads:[~2010-03-08 8:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 1:18 [PATCH] Fix scheduling policy problems for cyclictest John Kacur
2010-03-08 1:18 ` [PATCH] Revert "simplify equal priority logic for cyclictest" John Kacur
2010-03-08 8:01 ` Carsten Emde [this message]
2010-03-08 1:18 ` [PATCH] cyclictest: Use symbolic names for scheduling policy John Kacur
2010-03-08 8:35 ` Carsten Emde
2010-03-08 12:48 ` John Kacur
2010-03-08 13:01 ` Carsten Emde
2010-03-08 13:11 ` John Kacur
2010-03-08 1:18 ` [PATCH] cyclictest: Fix spelling mistake in the man page John Kacur
2010-03-08 1:18 ` [PATCH] cyclictest: Make the default scheduling policy SCHED_FIFO John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B94AEF4.8050204@osadl.org \
--to=carsten.emde@osadl.org \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.