From: Carsten Emde <Carsten.Emde@osadl.org>
To: John Kacur <jkacur@redhat.com>
Cc: Clark Williams <williams@redhat.com>,
rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH] cyclictest: Use symbolic names for scheduling policy
Date: Mon, 08 Mar 2010 09:35:45 +0100 [thread overview]
Message-ID: <4B94B6E1.2060400@osadl.org> (raw)
In-Reply-To: <1268011104-22451-3-git-send-email-jkacur@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1918 bytes --]
On 03/08/2010 02:18 AM, John Kacur wrote:
> - Use symbolic names for scheduling policies, that is, don't assume
> SCHED_RR is 2, use SCHED_RR instead, and so on.
>
> - Fix the logic in handlepolicy(char *polname)
> - remove the test with the unreachable line,
> - make the default SCHED_FIFO if we don't recognize the
> requested policy.
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
> src/cyclictest/cyclictest.c | 15 +++++----------
> 1 files changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index d38c0a7..066ca79 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -826,13 +826,8 @@ static void handlepolicy(char *polname)
> policy = SCHED_FIFO;
> else if (strncasecmp(polname, "rr", 2) == 0)
> policy = SCHED_RR;
> -
> - if (policy == SCHED_FIFO || policy == SCHED_RR) {
> - if (policy == 0)
> - policy = 1;
> - }
> - else
> - policy = 0;
> + else /* default policy if we don't recognize the request */
> + policy = SCHED_FIFO;
> }
>
> static char *policyname(int policy)
> @@ -1303,9 +1298,9 @@ int main(int argc, char **argv)
> par->prio = priority;
> if (priority && !histogram && !smp && !numa)
> priority--;
> - if (priority && policy <= 1) par->policy = SCHED_FIFO;
> - else if (priority && policy == 2) par->policy = SCHED_RR;
> - else par->policy = SCHED_OTHER;
> + if (priority && policy == SCHED_FIFO) par->policy = SCHED_FIFO;
> + else if (priority && policy == SCHED_RR) par->policy = SCHED_RR;
> + else par->policy = SCHED_OTHER;
> par->clock = clocksources[clocksel];
> par->mode = mode;
> par->timermode = timermode;
We need to adapt the help message accordingly.
Signed-off-by: Carsten Emde <C.Emde@osadl.org>
[-- Attachment #2: adapt-policy-help-message-for-cyclictest.patch --]
[-- Type: text/x-patch, Size: 1092 bytes --]
Index: rt-tests/src/cyclictest/cyclictest.c
===================================================================
--- rt-tests.orig/src/cyclictest/cyclictest.c
+++ rt-tests/src/cyclictest/cyclictest.c
@@ -776,8 +776,8 @@ static void display_help(int error)
" format: n:c:v n=tasknum c=count v=value in us\n"
"-w --wakeup task wakeup tracing (used with -b)\n"
"-W --wakeuprt rt task wakeup tracing (used with -b)\n"
- "-y POLI --policy=POLI policy of realtime thread (1:FIFO, 2:RR)\n"
- " format: --policy=fifo(default) or --policy=rr\n"
+ "-y POLI --policy=POLI policy of realtime thread, POLI may be FIFO (default)\n"
+ " or RR\n"
"-S --smp Standard SMP testing (equals -a -t -n -m -d0)\n"
" same priority on all threads.\n"
"-U --numa Standard NUMA testing (similar to SMP option)\n"
next prev parent reply other threads:[~2010-03-08 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 1:18 [PATCH] Fix scheduling policy problems for cyclictest John Kacur
2010-03-08 1:18 ` [PATCH] Revert "simplify equal priority logic for cyclictest" John Kacur
2010-03-08 8:01 ` Carsten Emde
2010-03-08 1:18 ` [PATCH] cyclictest: Use symbolic names for scheduling policy John Kacur
2010-03-08 8:35 ` Carsten Emde [this message]
2010-03-08 12:48 ` John Kacur
2010-03-08 13:01 ` Carsten Emde
2010-03-08 13:11 ` John Kacur
2010-03-08 1:18 ` [PATCH] cyclictest: Fix spelling mistake in the man page John Kacur
2010-03-08 1:18 ` [PATCH] cyclictest: Make the default scheduling policy SCHED_FIFO John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B94B6E1.2060400@osadl.org \
--to=carsten.emde@osadl.org \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.