From: Mike Christie <michaelc@cs.wisc.edu>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "James E.J. Bottomley"
<James.Bottomley-l3A5Bk7waGM@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Stefani Seibold <stefani-mkwtCZVSLSnR7s880joybQ@public.gmane.org>,
Andi Kleen <ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] iscsi: change & to &&
Date: Mon, 08 Mar 2010 20:57:29 +0000 [thread overview]
Message-ID: <4B9564B9.5000202@cs.wisc.edu> (raw)
In-Reply-To: <20100308122157.GI6469@bicker>
On 03/08/2010 06:21 AM, Dan Carpenter wrote:
> This change is basically a clean up.
>
> datadgst_en is an int which comes from the user. I didn't see anything
> limiting it to 1 and 0 although obviously that's what it's supposed to
> be. If the user passed in 2 this test would fail.
>
> This same if condition is repeated in another function and it uses&&
> there.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 4ad87fd..3794d29 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -420,7 +420,7 @@ iscsi_tcp_data_recv_prep(struct iscsi_tcp_conn *tcp_conn)
> struct iscsi_conn *conn = tcp_conn->iscsi_conn;
> struct hash_desc *rx_hash = NULL;
>
> - if (conn->datadgst_en&
> + if (conn->datadgst_en&&
> !(conn->session->tt->caps& CAP_DIGEST_OFFLOAD))
> rx_hash = tcp_conn->rx_hash;
>
Doh. Thanks!
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
WARNING: multiple messages have this Message-ID (diff)
From: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
To: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "James E.J. Bottomley"
<James.Bottomley-l3A5Bk7waGM@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Stefani Seibold <stefani-mkwtCZVSLSnR7s880joybQ@public.gmane.org>,
Andi Kleen <ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] iscsi: change & to &&
Date: Mon, 08 Mar 2010 14:57:29 -0600 [thread overview]
Message-ID: <4B9564B9.5000202@cs.wisc.edu> (raw)
In-Reply-To: <20100308122157.GI6469@bicker>
On 03/08/2010 06:21 AM, Dan Carpenter wrote:
> This change is basically a clean up.
>
> datadgst_en is an int which comes from the user. I didn't see anything
> limiting it to 1 and 0 although obviously that's what it's supposed to
> be. If the user passed in 2 this test would fail.
>
> This same if condition is repeated in another function and it uses&&
> there.
>
> Signed-off-by: Dan Carpenter<error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> diff --git a/drivers/scsi/libiscsi_tcp.c b/drivers/scsi/libiscsi_tcp.c
> index 4ad87fd..3794d29 100644
> --- a/drivers/scsi/libiscsi_tcp.c
> +++ b/drivers/scsi/libiscsi_tcp.c
> @@ -420,7 +420,7 @@ iscsi_tcp_data_recv_prep(struct iscsi_tcp_conn *tcp_conn)
> struct iscsi_conn *conn = tcp_conn->iscsi_conn;
> struct hash_desc *rx_hash = NULL;
>
> - if (conn->datadgst_en&
> + if (conn->datadgst_en&&
> !(conn->session->tt->caps& CAP_DIGEST_OFFLOAD))
> rx_hash = tcp_conn->rx_hash;
>
Doh. Thanks!
Reviewed-by: Mike Christie <michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
--
You received this message because you are subscribed to the Google Groups "open-iscsi" group.
To post to this group, send email to open-iscsi-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to open-iscsi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit this group at http://groups.google.com/group/open-iscsi?hl=en.
next prev parent reply other threads:[~2010-03-08 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 12:21 [patch] iscsi: change & to && Dan Carpenter
2010-03-08 12:21 ` Dan Carpenter
2010-03-08 20:57 ` Mike Christie [this message]
2010-03-08 20:57 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9564B9.5000202@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley-l3A5Bk7waGM@public.gmane.org \
--cc=ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=stefani-mkwtCZVSLSnR7s880joybQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.