From: Huang Shijie <shijie8@gmail.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: akpm@linux-foundation.org, hugh.dickins@tiscali.co.uk,
linux-mm@kvack.org
Subject: Re: [PATCH] shmem : remove redundant code
Date: Tue, 09 Mar 2010 10:02:58 +0800 [thread overview]
Message-ID: <4B95AC52.1000502@gmail.com> (raw)
In-Reply-To: <1268064285.1254.6.camel@barrios-desktop>
> On Mon, 2010-03-08 at 17:33 +0800, Huang Shijie wrote:
>
>> The prep_new_page() will call set_page_private(page, 0) to initiate
>> the page.
>>
>> So the code is redundant.
>>
>> Signed-off-by: Huang Shijie<shijie8@gmail.com>
>>
> Reviewed-by: Minchan Kim<minchan.kim@gmail.com>
>
Thanks Minchan. :)
> Long time ago, nr_swapped named is meaningful as a comment at least.
> But as split page table lock is introduced in 4c21e2f2441, it was
> changed by just set_page_private.
> So even it's not meaningful any more as a comment, I think.
> So let's remove redundant code.
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-09 2:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 9:33 [PATCH] shmem : remove redundant code Huang Shijie
2010-03-08 16:04 ` Minchan Kim
2010-03-09 2:02 ` Huang Shijie [this message]
2010-03-08 16:20 ` [PATCH] kvm : remove redundant initialization of page->private Minchan Kim
2010-03-10 10:19 ` Avi Kivity
2010-03-10 14:31 ` Minchan Kim
2010-03-11 7:42 ` Avi Kivity
2010-03-11 8:51 ` Jan Kiszka
2010-03-11 8:55 ` Avi Kivity
2010-03-11 18:43 ` Hugh Dickins
2010-03-09 21:25 ` [PATCH] shmem : remove redundant code Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B95AC52.1000502@gmail.com \
--to=shijie8@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.