From: Michal Simek <michal.simek@petalogix.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Howells <dhowells@redhat.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was Re: sync_mm_rss() issues
Date: Tue, 09 Mar 2010 12:49:18 +0100 [thread overview]
Message-ID: <4B9635BE.6090001@petalogix.com> (raw)
In-Reply-To: <8bd0f97a1003081833s2e8527d7pd1e0b427ae76020@mail.gmail.com>
Mike Frysinger wrote:
> On Mon, Mar 8, 2010 at 19:58, KAMEZAWA Hiroyuki wrote:
>> David-san, could you check this ?
>> ==
>> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>>
>> Fix breakage in NOMMU build
>>
>> commit 34e55232e59f7b19050267a05ff1226e5cd122a5 added sync_mm_rss()
>> for syncing loosely accounted rss counters. It's for CONFIG_MMU but
>> sync_mm_rss is called even in NOMMU enviroment (kerne/exit.c, fs/exec.c).
>> Above commit doesn't handle it well.
>>
>> This patch changes
>> SPLIT_RSS_COUNTING depends on SPLIT_PTLOCKS && CONFIG_MMU
>>
>> And for avoid unnecessary function calls, sync_mm_rss changed to be inlined
>> noop function in header file.
>
> fixes Blackfin systems ...
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
fixes Microblaze noMMU systems too.
Signed-off-by: Michal Simek <monstr@monstr.eu>
You can check Microblaze noMMU system via my site
http://www.monstr.eu/wiki/doku.php?id=log:log
Will be good to add your patches to linux-next before Linus tree.
Michal
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
WARNING: multiple messages have this Message-ID (diff)
From: Michal Simek <michal.simek@petalogix.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
David Howells <dhowells@redhat.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was Re: sync_mm_rss() issues
Date: Tue, 09 Mar 2010 12:49:18 +0100 [thread overview]
Message-ID: <4B9635BE.6090001@petalogix.com> (raw)
In-Reply-To: <8bd0f97a1003081833s2e8527d7pd1e0b427ae76020@mail.gmail.com>
Mike Frysinger wrote:
> On Mon, Mar 8, 2010 at 19:58, KAMEZAWA Hiroyuki wrote:
>> David-san, could you check this ?
>> ==
>> From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>>
>> Fix breakage in NOMMU build
>>
>> commit 34e55232e59f7b19050267a05ff1226e5cd122a5 added sync_mm_rss()
>> for syncing loosely accounted rss counters. It's for CONFIG_MMU but
>> sync_mm_rss is called even in NOMMU enviroment (kerne/exit.c, fs/exec.c).
>> Above commit doesn't handle it well.
>>
>> This patch changes
>> SPLIT_RSS_COUNTING depends on SPLIT_PTLOCKS && CONFIG_MMU
>>
>> And for avoid unnecessary function calls, sync_mm_rss changed to be inlined
>> noop function in header file.
>
> fixes Blackfin systems ...
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
fixes Microblaze noMMU systems too.
Signed-off-by: Michal Simek <monstr@monstr.eu>
You can check Microblaze noMMU system via my site
http://www.monstr.eu/wiki/doku.php?id=log:log
Will be good to add your patches to linux-next before Linus tree.
Michal
> -mike
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-03-09 11:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 13:59 sync_mm_rss() issues David Howells
2010-03-08 13:59 ` David Howells
2010-03-08 23:50 ` KAMEZAWA Hiroyuki
2010-03-08 23:50 ` KAMEZAWA Hiroyuki
2010-03-09 0:58 ` [BUGFIX][PATCH] fix sync_mm_rss in nommu (Was " KAMEZAWA Hiroyuki
2010-03-09 0:58 ` KAMEZAWA Hiroyuki
2010-03-09 2:33 ` Mike Frysinger
2010-03-09 2:33 ` Mike Frysinger
2010-03-09 11:49 ` Michal Simek [this message]
2010-03-09 11:49 ` Michal Simek
2010-03-09 15:41 ` Christoph Lameter
2010-03-09 15:41 ` Christoph Lameter
2010-03-09 15:43 ` Mike Frysinger
2010-03-09 15:43 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9635BE.6090001@petalogix.com \
--to=michal.simek@petalogix.com \
--cc=dhowells@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@osdl.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.