From: "David S. Ahern" <daahern@cisco.com>
To: "Arnaud Patard (Rtp)" <arnaud.patard@rtp-net.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/usb-msd: fix some usb requests
Date: Wed, 10 Mar 2010 12:40:44 -0700 [thread overview]
Message-ID: <4B97F5BC.5050500@cisco.com> (raw)
In-Reply-To: <87pr3cmrx3.fsf@lechat.rtp-net.org>
On 03/10/2010 02:45 AM, Arnaud Patard (Rtp) wrote:
>
> The usb-msd device emulation needs some small tweaks in the requests
> emulations. For instance, the reset/maxlun requests are class/interface
> specific so requests for them with the type class and recipient interface
> bits sets have to be handled.
>
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---
I hit this yesterday with msd as well. I suggest moving the
ClassInterfaceRequest and ClassInterfaceOutRequest defines from
hw/usb-net.c to hw/usb.h and then use those in hw/usb-msd.c for the
Class specific requests.
David
next prev parent reply other threads:[~2010-03-10 19:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 9:45 [Qemu-devel] [PATCH] hw/usb-msd: fix some usb requests Arnaud Patard
2010-03-10 19:40 ` David S. Ahern [this message]
2010-03-17 16:58 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B97F5BC.5050500@cisco.com \
--to=daahern@cisco.com \
--cc=arnaud.patard@rtp-net.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.