All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] inotify: Don't leak user struct on inotify release
@ 2010-03-11 10:37 Pavel Emelyanov
  0 siblings, 0 replies; only message in thread
From: Pavel Emelyanov @ 2010-03-11 10:37 UTC (permalink / raw)
  To: Eric Paris; +Cc: John McCutchan, Robert Love, Linux Kernel Mailing List, stable

The inotify_new_group receives a get_uid-ed user_struct and saves the
reference on group->inotify_data.user. The problem is that the free_uid
is never called on it.

Issue seem to be introduced by 63c882a0 (inotify: reimplement inotify 
using fsnotify) after 2.6.30 (so stable is in Cc)

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>

---

diff --git a/fs/notify/inotify/inotify_fsnotify.c b/fs/notify/inotify/inotify_fsnotify.c
index 1afb0a1..e27960c 100644
--- a/fs/notify/inotify/inotify_fsnotify.c
+++ b/fs/notify/inotify/inotify_fsnotify.c
@@ -28,6 +28,7 @@
 #include <linux/path.h> /* struct path */
 #include <linux/slab.h> /* kmem_* */
 #include <linux/types.h>
+#include <linux/sched.h>
 
 #include "inotify.h"
 
@@ -146,6 +147,7 @@ static void inotify_free_group_priv(struct fsnotify_group *group)
 	idr_for_each(&group->inotify_data.idr, idr_callback, group);
 	idr_remove_all(&group->inotify_data.idr);
 	idr_destroy(&group->inotify_data.idr);
+	free_uid(group->inotify_data.user);
 }
 
 void inotify_free_event_priv(struct fsnotify_event_private_data *fsn_event_priv)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-11 10:41 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-11 10:37 [PATCH] inotify: Don't leak user struct on inotify release Pavel Emelyanov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.