[Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Michael Tokarev <mjt@tls.msk.ru>]

tags 573439 + upstream patch pending
thanks

Kouichi ONO wrote:
> Package: qemu-kvm
> Version: 0.12.3+dfsg-3
> Severity: normal
> 
> Hello,
> 
> On version 0.12.3, -drive serial=XXX option does not work.
> Below patch fixes it. 'serial' is pointer, not array.
> 
> 
> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
> @@ -2397,7 +2397,7 @@
>      dinfo->on_write_error = on_write_error;
>      dinfo->opts = opts;
>      if (serial)
> -        strncpy(dinfo->serial, serial, sizeof(serial));
> +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
>      QTAILQ_INSERT_TAIL(&drives, dinfo, next);
>      if (is_extboot) {
>          extboot_drive = dinfo;

Good catch!  Thank you for the excellent bug report with
the patch.  It is this way even in upstream qemu, not only
in qemu-kvm...  So forwarding this to upstream too.

The patch will in in the next release of the Debian package.

Thanks!

/mjt