Re: [Qemu-devel] Re: Bug#573439: qemu-kvm: fail to set hdd serial number

[Michael Tokarev <mjt@tls.msk.ru>]

11.03.2010 18:34, Michael Tokarev wrote:
[]
>> On version 0.12.3, -drive serial=XXX option does not work.
>> Below patch fixes it. 'serial' is pointer, not array.
>>
>>
>> --- qemu-kvm-0.12.3+dfsg/vl.c	2010-02-26 11:34:00.000000000 +0900
>> +++ qemu-kvm-0.12.3+dfsg.old/vl.c	2010-03-11 02:26:00.134217787 +0900
>> @@ -2397,7 +2397,7 @@
>>       dinfo->on_write_error = on_write_error;
>>       dinfo->opts = opts;
>>       if (serial)
>> -        strncpy(dinfo->serial, serial, sizeof(serial));
>> +        strncpy(dinfo->serial, serial, sizeof(dinfo->serial));
>>       QTAILQ_INSERT_TAIL(&drives, dinfo, next);
>>       if (is_extboot) {
>>           extboot_drive = dinfo;

Folks, can we please add this trivial one-liner to -stable or something?
It has been one and a half months since it has been fixed in debian...

Thanks!

/mjt