From: Alexey Starikovskiy <aystarik@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Len Brown <lenb@kernel.org>,
Linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] ACPI: Battery: Add support for _BIX extended info method
Date: Mon, 15 Mar 2010 01:15:54 +0300 [thread overview]
Message-ID: <4B9D601A.3050708@gmail.com> (raw)
In-Reply-To: <20091017154124.GA31182@khazad-dum.debian.net>
Henrique de Moraes Holschuh пишет:
> On Fri, 16 Oct 2009, Alan Jenkins wrote:
>
>> So userspace is supposed to realise that "0" means "this attribute is
>> not supported", as opposed to "I am a brand new battery and don't
>> remember being factory-tested".
>>
>> How about returning -1 for batteries without _BIX?
>>
>
> How about NOT registering attributes that don't exist? That's the proper
> way of doing things in sysfs.
>
>
That is going to be too complex (2 duplicated arrays)
> When that's not possible, I'd suggest doing the right thing and returning an
> error of some sort (ENXIO, ENOTSUP, etc)...
>
>
None of power class members does it, and all ACPI classes are returning
-1 in not-supporting case.
Regards,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-14 22:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 10:31 [PATCH 1/4] ACPI: Battery: Add bit flags Alexey Starikovskiy
2009-10-15 10:31 ` [PATCH 2/4] POWER: Add support for cycle_count Alexey Starikovskiy
2010-01-15 21:59 ` Len Brown
2009-10-15 10:31 ` [PATCH 3/4] ACPI: SBS: Export cycle_count Alexey Starikovskiy
2010-01-15 21:59 ` Len Brown
2009-10-15 10:31 ` [PATCH 4/4] ACPI: Battery: Add support for _BIX extended info method Alexey Starikovskiy
2009-10-16 9:08 ` Alan Jenkins
2009-10-16 9:46 ` [PATCH] " Alexey Starikovskiy
2009-10-17 15:41 ` [PATCH 4/4] " Henrique de Moraes Holschuh
2010-03-14 22:15 ` Alexey Starikovskiy [this message]
2010-03-15 11:38 ` Henrique de Moraes Holschuh
2010-03-15 20:17 ` Alexey Starikovskiy
2010-03-16 0:12 ` Henrique de Moraes Holschuh
2010-01-15 22:03 ` Len Brown
2010-01-15 21:59 ` [PATCH 1/4] ACPI: Battery: Add bit flags Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9D601A.3050708@gmail.com \
--to=aystarik@gmail.com \
--cc=Linux-acpi@vger.kernel.org \
--cc=astarikovskiy@suse.de \
--cc=hmh@hmh.eng.br \
--cc=lenb@kernel.org \
--cc=sourcejedi.lkml@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.