All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Alexey Starikovskiy <aystarik@gmail.com>,
	Alan Jenkins <sourcejedi.lkml@googlemail.com>,
	Len Brown <lenb@kernel.org>,
	Linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/4] ACPI: Battery: Add support for _BIX extended info method
Date: Mon, 15 Mar 2010 23:17:47 +0300	[thread overview]
Message-ID: <4B9E95EB.8000604@suse.de> (raw)
In-Reply-To: <20100315113837.GA8296@khazad-dum.debian.net>

Henrique de Moraes Holschuh пишет:
> That just means the ACPI sysfs conversion on that area was not as good as it
> should have been.  It is hardly the only place where the sysfs ABI is not
> well implemented, but that doesn't mean the breakage should remain, or that
> it should be made worse.
> What is the technical case to returning invalid values for something that is
> not supported when you could return a proper error on open() instead (since
Power Class interface does not give me control over open() as far as I know.
> you're not going to do the Right Thing and not register that attribute it in
> the first place)?  Not only the "-1" way wastes more system resources (all
> clients have to do open+read+close), it also needs userspace to special case
> something, and that is always a Bad Idea for *many* reasons.
If you know how this could be done, please show the patch...

Thanks,
Alex.

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-03-15 20:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15 10:31 [PATCH 1/4] ACPI: Battery: Add bit flags Alexey Starikovskiy
2009-10-15 10:31 ` [PATCH 2/4] POWER: Add support for cycle_count Alexey Starikovskiy
2010-01-15 21:59   ` Len Brown
2009-10-15 10:31 ` [PATCH 3/4] ACPI: SBS: Export cycle_count Alexey Starikovskiy
2010-01-15 21:59   ` Len Brown
2009-10-15 10:31 ` [PATCH 4/4] ACPI: Battery: Add support for _BIX extended info method Alexey Starikovskiy
2009-10-16  9:08   ` Alan Jenkins
2009-10-16  9:46     ` [PATCH] " Alexey Starikovskiy
2009-10-17 15:41     ` [PATCH 4/4] " Henrique de Moraes Holschuh
2010-03-14 22:15       ` Alexey Starikovskiy
2010-03-15 11:38         ` Henrique de Moraes Holschuh
2010-03-15 20:17           ` Alexey Starikovskiy [this message]
2010-03-16  0:12             ` Henrique de Moraes Holschuh
2010-01-15 22:03   ` Len Brown
2010-01-15 21:59 ` [PATCH 1/4] ACPI: Battery: Add bit flags Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9E95EB.8000604@suse.de \
    --to=astarikovskiy@suse.de \
    --cc=Linux-acpi@vger.kernel.org \
    --cc=aystarik@gmail.com \
    --cc=hmh@hmh.eng.br \
    --cc=lenb@kernel.org \
    --cc=sourcejedi.lkml@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.