* [PATCH] Use correct array size!
@ 2010-03-13 0:17 Malahal Naineni
2010-03-15 9:03 ` Zdenek Kabelac
0 siblings, 1 reply; 4+ messages in thread
From: Malahal Naineni @ 2010-03-13 0:17 UTC (permalink / raw)
To: lvm-devel
Signed-off-by: Malahal Naineni (malahal at us.ibm.com)
diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c
--- a/daemons/dmeventd/dmeventd.c Thu Mar 11 16:05:21 2010 -0800
+++ b/daemons/dmeventd/dmeventd.c Fri Mar 12 16:15:25 2010 -0800
@@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
{ DM_EVENT_CMD_ACTIVE, _active},
}, *req;
- for (req = requests; req < requests + sizeof(requests); req++)
+ for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
if (req->cmd == msg->cmd)
return req->f(message_data);
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Use correct array size!
2010-03-13 0:17 [PATCH] Use correct array size! Malahal Naineni
@ 2010-03-15 9:03 ` Zdenek Kabelac
2010-03-15 9:05 ` Zdenek Kabelac
2010-03-15 9:10 ` Zdenek Kabelac
0 siblings, 2 replies; 4+ messages in thread
From: Zdenek Kabelac @ 2010-03-15 9:03 UTC (permalink / raw)
To: lvm-devel
On 13.3.2010 01:17, Malahal Naineni wrote:
> Signed-off-by: Malahal Naineni (malahal at us.ibm.com)
>
> diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c
> --- a/daemons/dmeventd/dmeventd.c Thu Mar 11 16:05:21 2010 -0800
> +++ b/daemons/dmeventd/dmeventd.c Fri Mar 12 16:15:25 2010 -0800
> @@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
> { DM_EVENT_CMD_ACTIVE, _active},
> }, *req;
>
> - for (req = requests; req < requests + sizeof(requests); req++)
> + for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
> if (req->cmd == msg->cmd)
> return req->f(message_data);
NACK
Moving via pointers - thus you need to check whether pointer passes
array boundary (just like C++ vector() iterator)
see the difference:
for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0
Zdenek
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Use correct array size!
2010-03-15 9:03 ` Zdenek Kabelac
@ 2010-03-15 9:05 ` Zdenek Kabelac
2010-03-15 9:10 ` Zdenek Kabelac
1 sibling, 0 replies; 4+ messages in thread
From: Zdenek Kabelac @ 2010-03-15 9:05 UTC (permalink / raw)
To: lvm-devel
On 15.3.2010 10:03, Zdenek Kabelac wrote:
> On 13.3.2010 01:17, Malahal Naineni wrote:
>> Signed-off-by: Malahal Naineni (malahal at us.ibm.com)
>>
>> diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c
>> --- a/daemons/dmeventd/dmeventd.c Thu Mar 11 16:05:21 2010 -0800
>> +++ b/daemons/dmeventd/dmeventd.c Fri Mar 12 16:15:25 2010 -0800
>> @@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
>> { DM_EVENT_CMD_ACTIVE, _active},
>> }, *req;
>>
>> - for (req = requests; req < requests + sizeof(requests); req++)
>> + for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
>> if (req->cmd == msg->cmd)
>> return req->f(message_data);
>
>
> NACK
>
> Moving via pointers - thus you need to check whether pointer passes
> array boundary (just like C++ vector() iterator)
>
> see the difference:
> for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0
>
> Zdenek
>
> --
> lvm-devel mailing list
> lvm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/lvm-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Use correct array size!
2010-03-15 9:03 ` Zdenek Kabelac
2010-03-15 9:05 ` Zdenek Kabelac
@ 2010-03-15 9:10 ` Zdenek Kabelac
1 sibling, 0 replies; 4+ messages in thread
From: Zdenek Kabelac @ 2010-03-15 9:10 UTC (permalink / raw)
To: lvm-devel
On 15.3.2010 10:03, Zdenek Kabelac wrote:
> On 13.3.2010 01:17, Malahal Naineni wrote:
>> Signed-off-by: Malahal Naineni (malahal at us.ibm.com)
>>
>> diff -r 5d08ba4ae8e8 -r 8db1b9ee17a8 daemons/dmeventd/dmeventd.c
>> --- a/daemons/dmeventd/dmeventd.c Thu Mar 11 16:05:21 2010 -0800
>> +++ b/daemons/dmeventd/dmeventd.c Fri Mar 12 16:15:25 2010 -0800
>> @@ -1369,7 +1369,7 @@ static int _handle_request(struct dm_eve
>> { DM_EVENT_CMD_ACTIVE, _active},
>> }, *req;
>>
>> - for (req = requests; req < requests + sizeof(requests); req++)
>> + for (req = requests; req < requests + sizeof(requests) / sizeof(requests[0]); req++)
>> if (req->cmd == msg->cmd)
>> return req->f(message_data);
>
>
> NACK
>
> Moving via pointers - thus you need to check whether pointer passes
> array boundary (just like C++ vector() iterator)
>
> see the difference:
> for(req = 0; i < sizeof(requests) / sizeof(requests[0]); req++0
Ahh, I've confused myself.
as req is pointer of the same type, pointer arithmetic applies here as well,
so the patch is correct. We need to add number of array elements.
Zdenek
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-03-15 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-13 0:17 [PATCH] Use correct array size! Malahal Naineni
2010-03-15 9:03 ` Zdenek Kabelac
2010-03-15 9:05 ` Zdenek Kabelac
2010-03-15 9:10 ` Zdenek Kabelac
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.