* [PATCH] chunkd: fix duplicate stc_object allocation in stc_parse_key()
@ 2010-03-16 9:59 Akinobu Mita
2010-03-16 16:17 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Akinobu Mita @ 2010-03-16 9:59 UTC (permalink / raw)
To: hail-devel; +Cc: Akinobu Mita
At the beginning of stc_parse_key(), st_object is allocated twice for
the same variable.
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
lib/chunkdc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/chunkdc.c b/lib/chunkdc.c
index 2696a81..67c39eb 100644
--- a/lib/chunkdc.c
+++ b/lib/chunkdc.c
@@ -831,7 +831,7 @@ void stc_free_keylist(struct st_keylist *keylist)
static void stc_parse_key(xmlDocPtr doc, xmlNode *node,
struct st_keylist *keylist)
{
- struct st_object *obj = calloc(1, sizeof(*obj));
+ struct st_object *obj;
xmlChar *xs;
obj = calloc(1, sizeof(*obj));
--
1.6.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] chunkd: fix duplicate stc_object allocation in stc_parse_key()
2010-03-16 9:59 [PATCH] chunkd: fix duplicate stc_object allocation in stc_parse_key() Akinobu Mita
@ 2010-03-16 16:17 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2010-03-16 16:17 UTC (permalink / raw)
To: Akinobu Mita; +Cc: hail-devel
On 03/16/2010 05:59 AM, Akinobu Mita wrote:
> At the beginning of stc_parse_key(), st_object is allocated twice for
> the same variable.
>
> Signed-off-by: Akinobu Mita<akinobu.mita@gmail.com>
> ---
> lib/chunkdc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
good catch, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-16 16:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-16 9:59 [PATCH] chunkd: fix duplicate stc_object allocation in stc_parse_key() Akinobu Mita
2010-03-16 16:17 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.