* TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) @ 2010-02-25 16:50 Jerome Glisse 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse 2010-03-04 10:12 ` TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse 0 siblings, 2 replies; 8+ messages in thread From: Jerome Glisse @ 2010-02-25 16:50 UTC (permalink / raw) To: airlied; +Cc: thellstrom, skeggsb, dri-devel This patch change the TTM API to allow driver to select btw choosing to wait or not either for bo reserve or GPU wait separately. This is needed for the unmappabled VRAM work. Comments ? Cheers, Jerome ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait 2010-02-25 16:50 TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse @ 2010-02-25 16:50 ` Jerome Glisse 2010-02-25 16:50 ` [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument Jerome Glisse ` (2 more replies) 2010-03-04 10:12 ` TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse 1 sibling, 3 replies; 8+ messages in thread From: Jerome Glisse @ 2010-02-25 16:50 UTC (permalink / raw) To: airlied; +Cc: thellstrom, skeggsb, Jerome Glisse, dri-devel There is case where we want to be able to wait only for the GPU while not waiting for other buffer to be unreserved. This patch split the no_wait argument all the way down in the whole ttm path so that upper level can decide on what to wait on or not. This patch break the API to other modules, update to others driver are following in separate patches. Signed-off-by: Jerome Glisse <jglisse@redhat.com> --- drivers/gpu/drm/ttm/ttm_bo.c | 57 ++++++++++++++++++++---------------- drivers/gpu/drm/ttm/ttm_bo_util.c | 9 ++++-- include/drm/ttm/ttm_bo_api.h | 6 ++- include/drm/ttm/ttm_bo_driver.h | 29 +++++++++++------- 4 files changed, 60 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c7320ce..d2b2482 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -357,7 +357,8 @@ static int ttm_bo_add_ttm(struct ttm_buffer_object *bo, bool zero_alloc) static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, struct ttm_mem_reg *mem, - bool evict, bool interruptible, bool no_wait) + bool evict, bool interruptible, + bool no_wait_reserve, bool no_wait_gpu) { struct ttm_bo_device *bdev = bo->bdev; bool old_is_pci = ttm_mem_reg_is_pci(bdev, &bo->mem); @@ -402,12 +403,12 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, if (!(old_man->flags & TTM_MEMTYPE_FLAG_FIXED) && !(new_man->flags & TTM_MEMTYPE_FLAG_FIXED)) - ret = ttm_bo_move_ttm(bo, evict, no_wait, mem); + ret = ttm_bo_move_ttm(bo, evict, no_wait_reserve, no_wait_gpu, mem); else if (bdev->driver->move) ret = bdev->driver->move(bo, evict, interruptible, - no_wait, mem); + no_wait_reserve, no_wait_gpu, mem); else - ret = ttm_bo_move_memcpy(bo, evict, no_wait, mem); + ret = ttm_bo_move_memcpy(bo, evict, no_wait_reserve, no_wait_gpu, mem); if (ret) goto out_err; @@ -606,7 +607,7 @@ void ttm_bo_unref(struct ttm_buffer_object **p_bo) EXPORT_SYMBOL(ttm_bo_unref); static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, - bool no_wait) + bool no_wait_reserve, bool no_wait_gpu) { struct ttm_bo_device *bdev = bo->bdev; struct ttm_bo_global *glob = bo->glob; @@ -615,7 +616,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, int ret = 0; spin_lock(&bo->lock); - ret = ttm_bo_wait(bo, false, interruptible, no_wait); + ret = ttm_bo_wait(bo, false, interruptible, no_wait_gpu); spin_unlock(&bo->lock); if (unlikely(ret != 0)) { @@ -638,7 +639,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, placement.num_busy_placement = 0; bdev->driver->evict_flags(bo, &placement); ret = ttm_bo_mem_space(bo, &placement, &evict_mem, interruptible, - no_wait); + no_wait_reserve, no_wait_gpu); if (ret) { if (ret != -ERESTARTSYS) { printk(KERN_ERR TTM_PFX @@ -650,7 +651,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, } ret = ttm_bo_handle_move_mem(bo, &evict_mem, true, interruptible, - no_wait); + no_wait_reserve, no_wait_gpu); if (ret) { if (ret != -ERESTARTSYS) printk(KERN_ERR TTM_PFX "Buffer eviction failed\n"); @@ -670,7 +671,8 @@ out: static int ttm_mem_evict_first(struct ttm_bo_device *bdev, uint32_t mem_type, - bool interruptible, bool no_wait) + bool interruptible, bool no_wait_reserve, + bool no_wait_gpu) { struct ttm_bo_global *glob = bdev->glob; struct ttm_mem_type_manager *man = &bdev->man[mem_type]; @@ -687,11 +689,11 @@ retry: bo = list_first_entry(&man->lru, struct ttm_buffer_object, lru); kref_get(&bo->list_kref); - ret = ttm_bo_reserve_locked(bo, false, true, false, 0); + ret = ttm_bo_reserve_locked(bo, false, no_wait_reserve, false, 0); if (unlikely(ret == -EBUSY)) { spin_unlock(&glob->lru_lock); - if (likely(!no_wait)) + if (likely(!no_wait_gpu)) ret = ttm_bo_wait_unreserved(bo, interruptible); kref_put(&bo->list_kref, ttm_bo_release_list); @@ -713,7 +715,7 @@ retry: while (put_count--) kref_put(&bo->list_kref, ttm_bo_ref_bug); - ret = ttm_bo_evict(bo, interruptible, no_wait); + ret = ttm_bo_evict(bo, interruptible, no_wait_reserve, no_wait_gpu); ttm_bo_unreserve(bo); kref_put(&bo->list_kref, ttm_bo_release_list); @@ -764,7 +766,9 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, uint32_t mem_type, struct ttm_placement *placement, struct ttm_mem_reg *mem, - bool interruptible, bool no_wait) + bool interruptible, + bool no_wait_reserve, + bool no_wait_gpu) { struct ttm_bo_device *bdev = bo->bdev; struct ttm_bo_global *glob = bdev->glob; @@ -785,7 +789,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, } spin_unlock(&glob->lru_lock); ret = ttm_mem_evict_first(bdev, mem_type, interruptible, - no_wait); + no_wait_reserve, no_wait_gpu); if (unlikely(ret != 0)) return ret; } while (1); @@ -855,7 +859,8 @@ static bool ttm_bo_mt_compatible(struct ttm_mem_type_manager *man, int ttm_bo_mem_space(struct ttm_buffer_object *bo, struct ttm_placement *placement, struct ttm_mem_reg *mem, - bool interruptible, bool no_wait) + bool interruptible, bool no_wait_reserve, + bool no_wait_gpu) { struct ttm_bo_device *bdev = bo->bdev; struct ttm_mem_type_manager *man; @@ -952,7 +957,7 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo, } ret = ttm_bo_mem_force_space(bo, mem_type, placement, mem, - interruptible, no_wait); + interruptible, no_wait_reserve, no_wait_gpu); if (ret == 0 && mem->mm_node) { mem->placement = cur_flags; mem->mm_node->private = bo; @@ -978,7 +983,8 @@ EXPORT_SYMBOL(ttm_bo_wait_cpu); int ttm_bo_move_buffer(struct ttm_buffer_object *bo, struct ttm_placement *placement, - bool interruptible, bool no_wait) + bool interruptible, bool no_wait_reserve, + bool no_wait_gpu) { struct ttm_bo_global *glob = bo->glob; int ret = 0; @@ -992,7 +998,7 @@ int ttm_bo_move_buffer(struct ttm_buffer_object *bo, * instead of doing it here. */ spin_lock(&bo->lock); - ret = ttm_bo_wait(bo, false, interruptible, no_wait); + ret = ttm_bo_wait(bo, false, interruptible, no_wait_gpu); spin_unlock(&bo->lock); if (ret) return ret; @@ -1002,10 +1008,10 @@ int ttm_bo_move_buffer(struct ttm_buffer_object *bo, /* * Determine where to move the buffer. */ - ret = ttm_bo_mem_space(bo, placement, &mem, interruptible, no_wait); + ret = ttm_bo_mem_space(bo, placement, &mem, interruptible, no_wait_reserve, no_wait_gpu); if (ret) goto out_unlock; - ret = ttm_bo_handle_move_mem(bo, &mem, false, interruptible, no_wait); + ret = ttm_bo_handle_move_mem(bo, &mem, false, interruptible, no_wait_reserve, no_wait_gpu); out_unlock: if (ret && mem.mm_node) { spin_lock(&glob->lru_lock); @@ -1039,7 +1045,8 @@ static int ttm_bo_mem_compat(struct ttm_placement *placement, int ttm_bo_validate(struct ttm_buffer_object *bo, struct ttm_placement *placement, - bool interruptible, bool no_wait) + bool interruptible, bool no_wait_reserve, + bool no_wait_gpu) { int ret; @@ -1054,7 +1061,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo, */ ret = ttm_bo_mem_compat(placement, &bo->mem); if (ret < 0) { - ret = ttm_bo_move_buffer(bo, placement, interruptible, no_wait); + ret = ttm_bo_move_buffer(bo, placement, interruptible, no_wait_reserve, no_wait_gpu); if (ret) return ret; } else { @@ -1175,7 +1182,7 @@ int ttm_bo_init(struct ttm_bo_device *bdev, goto out_err; } - ret = ttm_bo_validate(bo, placement, interruptible, false); + ret = ttm_bo_validate(bo, placement, interruptible, false, false); if (ret) goto out_err; @@ -1249,7 +1256,7 @@ static int ttm_bo_force_list_clean(struct ttm_bo_device *bdev, spin_lock(&glob->lru_lock); while (!list_empty(&man->lru)) { spin_unlock(&glob->lru_lock); - ret = ttm_mem_evict_first(bdev, mem_type, false, false); + ret = ttm_mem_evict_first(bdev, mem_type, false, false, false); if (ret) { if (allow_errors) { return ret; @@ -1839,7 +1846,7 @@ static int ttm_bo_swapout(struct ttm_mem_shrink *shrink) evict_mem.mem_type = TTM_PL_SYSTEM; ret = ttm_bo_handle_move_mem(bo, &evict_mem, true, - false, false); + false, false, false); if (unlikely(ret != 0)) goto out; } diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c index 3f72fe1..db43b30 100644 --- a/drivers/gpu/drm/ttm/ttm_bo_util.c +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c @@ -49,7 +49,8 @@ void ttm_bo_free_old_node(struct ttm_buffer_object *bo) } int ttm_bo_move_ttm(struct ttm_buffer_object *bo, - bool evict, bool no_wait, struct ttm_mem_reg *new_mem) + bool evict, bool no_wait_reserve, + bool no_wait_gpu, struct ttm_mem_reg *new_mem) { struct ttm_tt *ttm = bo->ttm; struct ttm_mem_reg *old_mem = &bo->mem; @@ -207,7 +208,8 @@ static int ttm_copy_ttm_io_page(struct ttm_tt *ttm, void *dst, } int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, - bool evict, bool no_wait, struct ttm_mem_reg *new_mem) + bool evict, bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { struct ttm_bo_device *bdev = bo->bdev; struct ttm_mem_type_manager *man = &bdev->man[new_mem->mem_type]; @@ -525,7 +527,8 @@ int ttm_bo_pfn_prot(struct ttm_buffer_object *bo, int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, void *sync_obj, void *sync_obj_arg, - bool evict, bool no_wait, + bool evict, bool no_wait_reserve, + bool no_wait_gpu, struct ttm_mem_reg *new_mem) { struct ttm_bo_device *bdev = bo->bdev; diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h index 81eb9f4..8c8005e 100644 --- a/include/drm/ttm/ttm_bo_api.h +++ b/include/drm/ttm/ttm_bo_api.h @@ -313,7 +313,8 @@ extern int ttm_bo_wait(struct ttm_buffer_object *bo, bool lazy, * @bo: The buffer object. * @placement: Proposed placement for the buffer object. * @interruptible: Sleep interruptible if sleeping. - * @no_wait: Return immediately if the buffer is busy. + * @no_wait_reserve: Return immediately if other buffers are busy. + * @no_wait_gpu: Return immediately if the GPU is busy. * * Changes placement and caching policy of the buffer object * according proposed placement. @@ -325,7 +326,8 @@ extern int ttm_bo_wait(struct ttm_buffer_object *bo, bool lazy, */ extern int ttm_bo_validate(struct ttm_buffer_object *bo, struct ttm_placement *placement, - bool interruptible, bool no_wait); + bool interruptible, bool no_wait_reserve, + bool no_wait_gpu); /** * ttm_bo_unref diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h index 4c4e0f8..999fbcb 100644 --- a/include/drm/ttm/ttm_bo_driver.h +++ b/include/drm/ttm/ttm_bo_driver.h @@ -312,7 +312,8 @@ struct ttm_bo_driver { */ int (*move) (struct ttm_buffer_object *bo, bool evict, bool interruptible, - bool no_wait, struct ttm_mem_reg *new_mem); + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem); /** * struct ttm_bo_driver_member verify_access @@ -634,7 +635,8 @@ extern bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, * @proposed_placement: Proposed new placement for the buffer object. * @mem: A struct ttm_mem_reg. * @interruptible: Sleep interruptible when sliping. - * @no_wait: Don't sleep waiting for space to become available. + * @no_wait_reserve: Return immediately if other buffers are busy. + * @no_wait_gpu: Return immediately if the GPU is busy. * * Allocate memory space for the buffer object pointed to by @bo, using * the placement flags in @mem, potentially evicting other idle buffer objects. @@ -648,7 +650,8 @@ extern bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, extern int ttm_bo_mem_space(struct ttm_buffer_object *bo, struct ttm_placement *placement, struct ttm_mem_reg *mem, - bool interruptible, bool no_wait); + bool interruptible, + bool no_wait_reserve, bool no_wait_gpu); /** * ttm_bo_wait_for_cpu * @@ -827,7 +830,8 @@ extern void ttm_bo_unblock_reservation(struct ttm_buffer_object *bo); * * @bo: A pointer to a struct ttm_buffer_object. * @evict: 1: This is an eviction. Don't try to pipeline. - * @no_wait: Never sleep, but rather return with -EBUSY. + * @no_wait_reserve: Return immediately if other buffers are busy. + * @no_wait_gpu: Return immediately if the GPU is busy. * @new_mem: struct ttm_mem_reg indicating where to move. * * Optimized move function for a buffer object with both old and @@ -841,15 +845,16 @@ extern void ttm_bo_unblock_reservation(struct ttm_buffer_object *bo); */ extern int ttm_bo_move_ttm(struct ttm_buffer_object *bo, - bool evict, bool no_wait, - struct ttm_mem_reg *new_mem); + bool evict, bool no_wait_reserve, + bool no_wait_gpu, struct ttm_mem_reg *new_mem); /** * ttm_bo_move_memcpy * * @bo: A pointer to a struct ttm_buffer_object. * @evict: 1: This is an eviction. Don't try to pipeline. - * @no_wait: Never sleep, but rather return with -EBUSY. + * @no_wait_reserve: Return immediately if other buffers are busy. + * @no_wait_gpu: Return immediately if the GPU is busy. * @new_mem: struct ttm_mem_reg indicating where to move. * * Fallback move function for a mappable buffer object in mappable memory. @@ -863,8 +868,8 @@ extern int ttm_bo_move_ttm(struct ttm_buffer_object *bo, */ extern int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, - bool evict, - bool no_wait, struct ttm_mem_reg *new_mem); + bool evict, bool no_wait_reserve, + bool no_wait_gpu, struct ttm_mem_reg *new_mem); /** * ttm_bo_free_old_node @@ -883,7 +888,8 @@ extern void ttm_bo_free_old_node(struct ttm_buffer_object *bo); * @sync_obj_arg: An argument to pass to the sync object idle / wait * functions. * @evict: This is an evict move. Don't return until the buffer is idle. - * @no_wait: Never sleep, but rather return with -EBUSY. + * @no_wait_reserve: Return immediately if other buffers are busy. + * @no_wait_gpu: Return immediately if the GPU is busy. * @new_mem: struct ttm_mem_reg indicating where to move. * * Accelerated move function to be called when an accelerated move @@ -897,7 +903,8 @@ extern void ttm_bo_free_old_node(struct ttm_buffer_object *bo); extern int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, void *sync_obj, void *sync_obj_arg, - bool evict, bool no_wait, + bool evict, bool no_wait_reserve, + bool no_wait_gpu, struct ttm_mem_reg *new_mem); /** * ttm_io_prot -- 1.6.6 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse @ 2010-02-25 16:50 ` Jerome Glisse 2010-02-25 16:50 ` [PATCH 3/4] drm/nouveau: " Jerome Glisse 2010-02-25 17:11 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Ville Syrjälä 2010-03-17 10:19 ` Thomas Hellstrom 2 siblings, 1 reply; 8+ messages in thread From: Jerome Glisse @ 2010-02-25 16:50 UTC (permalink / raw) To: airlied; +Cc: thellstrom, skeggsb, Jerome Glisse, dri-devel This patch update radeon to the new no_wait splitted argument TTM functionality. Signed-off-by: Jerome Glisse <jglisse@redhat.com> --- drivers/gpu/drm/radeon/radeon_object.c | 6 ++-- drivers/gpu/drm/radeon/radeon_ttm.c | 39 +++++++++++++++++-------------- 2 files changed, 24 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_object.c b/drivers/gpu/drm/radeon/radeon_object.c index fc9d00a..3adfa88 100644 --- a/drivers/gpu/drm/radeon/radeon_object.c +++ b/drivers/gpu/drm/radeon/radeon_object.c @@ -189,7 +189,7 @@ int radeon_bo_pin(struct radeon_bo *bo, u32 domain, u64 *gpu_addr) bo->placement.lpfn = bo->rdev->mc.visible_vram_size >> PAGE_SHIFT; for (i = 0; i < bo->placement.num_placement; i++) bo->placements[i] |= TTM_PL_FLAG_NO_EVICT; - r = ttm_bo_validate(&bo->tbo, &bo->placement, false, false); + r = ttm_bo_validate(&bo->tbo, &bo->placement, false, false, false); if (likely(r == 0)) { bo->pin_count = 1; if (gpu_addr != NULL) @@ -213,7 +213,7 @@ int radeon_bo_unpin(struct radeon_bo *bo) return 0; for (i = 0; i < bo->placement.num_placement; i++) bo->placements[i] &= ~TTM_PL_FLAG_NO_EVICT; - r = ttm_bo_validate(&bo->tbo, &bo->placement, false, false); + r = ttm_bo_validate(&bo->tbo, &bo->placement, false, false, false); if (unlikely(r != 0)) dev_err(bo->rdev->dev, "%p validate failed for unpin\n", bo); return r; @@ -328,7 +328,7 @@ int radeon_bo_list_validate(struct list_head *head) lobj->rdomain); } r = ttm_bo_validate(&bo->tbo, &bo->placement, - true, false); + true, false, false); if (unlikely(r)) return r; } diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c index 1157e0f..9d9dfe7 100644 --- a/drivers/gpu/drm/radeon/radeon_ttm.c +++ b/drivers/gpu/drm/radeon/radeon_ttm.c @@ -243,9 +243,9 @@ static void radeon_move_null(struct ttm_buffer_object *bo, } static int radeon_move_blit(struct ttm_buffer_object *bo, - bool evict, int no_wait, - struct ttm_mem_reg *new_mem, - struct ttm_mem_reg *old_mem) + bool evict, int no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem, + struct ttm_mem_reg *old_mem) { struct radeon_device *rdev; uint64_t old_start, new_start; @@ -289,13 +289,14 @@ static int radeon_move_blit(struct ttm_buffer_object *bo, r = radeon_copy(rdev, old_start, new_start, new_mem->num_pages, fence); /* FIXME: handle copy error */ r = ttm_bo_move_accel_cleanup(bo, (void *)fence, NULL, - evict, no_wait, new_mem); + evict, no_wait_reserve, no_wait_gpu, new_mem); radeon_fence_unref(&fence); return r; } static int radeon_move_vram_ram(struct ttm_buffer_object *bo, - bool evict, bool interruptible, bool no_wait, + bool evict, bool interruptible, + bool no_wait_reserve, bool no_wait_gpu, struct ttm_mem_reg *new_mem) { struct radeon_device *rdev; @@ -316,7 +317,7 @@ static int radeon_move_vram_ram(struct ttm_buffer_object *bo, placement.busy_placement = &placements; placements = TTM_PL_MASK_CACHING | TTM_PL_FLAG_TT; r = ttm_bo_mem_space(bo, &placement, &tmp_mem, - interruptible, no_wait); + interruptible, no_wait_reserve, no_wait_gpu); if (unlikely(r)) { return r; } @@ -330,11 +331,11 @@ static int radeon_move_vram_ram(struct ttm_buffer_object *bo, if (unlikely(r)) { goto out_cleanup; } - r = radeon_move_blit(bo, true, no_wait, &tmp_mem, old_mem); + r = radeon_move_blit(bo, true, no_wait_reserve, no_wait_gpu, &tmp_mem, old_mem); if (unlikely(r)) { goto out_cleanup; } - r = ttm_bo_move_ttm(bo, true, no_wait, new_mem); + r = ttm_bo_move_ttm(bo, true, no_wait_reserve, no_wait_gpu, new_mem); out_cleanup: if (tmp_mem.mm_node) { struct ttm_bo_global *glob = rdev->mman.bdev.glob; @@ -348,7 +349,8 @@ out_cleanup: } static int radeon_move_ram_vram(struct ttm_buffer_object *bo, - bool evict, bool interruptible, bool no_wait, + bool evict, bool interruptible, + bool no_wait_reserve, bool no_wait_gpu, struct ttm_mem_reg *new_mem) { struct radeon_device *rdev; @@ -368,15 +370,15 @@ static int radeon_move_ram_vram(struct ttm_buffer_object *bo, placement.num_busy_placement = 1; placement.busy_placement = &placements; placements = TTM_PL_MASK_CACHING | TTM_PL_FLAG_TT; - r = ttm_bo_mem_space(bo, &placement, &tmp_mem, interruptible, no_wait); + r = ttm_bo_mem_space(bo, &placement, &tmp_mem, interruptible, no_wait_reserve, no_wait_gpu); if (unlikely(r)) { return r; } - r = ttm_bo_move_ttm(bo, true, no_wait, &tmp_mem); + r = ttm_bo_move_ttm(bo, true, no_wait_reserve, no_wait_gpu, &tmp_mem); if (unlikely(r)) { goto out_cleanup; } - r = radeon_move_blit(bo, true, no_wait, new_mem, old_mem); + r = radeon_move_blit(bo, true, no_wait_reserve, no_wait_gpu, new_mem, old_mem); if (unlikely(r)) { goto out_cleanup; } @@ -393,8 +395,9 @@ out_cleanup: } static int radeon_bo_move(struct ttm_buffer_object *bo, - bool evict, bool interruptible, bool no_wait, - struct ttm_mem_reg *new_mem) + bool evict, bool interruptible, + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { struct radeon_device *rdev; struct ttm_mem_reg *old_mem = &bo->mem; @@ -421,18 +424,18 @@ static int radeon_bo_move(struct ttm_buffer_object *bo, if (old_mem->mem_type == TTM_PL_VRAM && new_mem->mem_type == TTM_PL_SYSTEM) { r = radeon_move_vram_ram(bo, evict, interruptible, - no_wait, new_mem); + no_wait_reserve, no_wait_gpu, new_mem); } else if (old_mem->mem_type == TTM_PL_SYSTEM && new_mem->mem_type == TTM_PL_VRAM) { r = radeon_move_ram_vram(bo, evict, interruptible, - no_wait, new_mem); + no_wait_reserve, no_wait_gpu, new_mem); } else { - r = radeon_move_blit(bo, evict, no_wait, new_mem, old_mem); + r = radeon_move_blit(bo, evict, no_wait_reserve, no_wait_gpu, new_mem, old_mem); } if (r) { memcpy: - r = ttm_bo_move_memcpy(bo, evict, no_wait, new_mem); + r = ttm_bo_move_memcpy(bo, evict, no_wait_reserve, no_wait_gpu, new_mem); } return r; -- 1.6.6 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/4] drm/nouveau: update to TTM no_wait splitted argument 2010-02-25 16:50 ` [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument Jerome Glisse @ 2010-02-25 16:50 ` Jerome Glisse 2010-02-25 16:50 ` [PATCH 4/4] drm/vmwgfx: " Jerome Glisse 0 siblings, 1 reply; 8+ messages in thread From: Jerome Glisse @ 2010-02-25 16:50 UTC (permalink / raw) To: airlied; +Cc: thellstrom, skeggsb, Jerome Glisse, dri-devel This patch update radeon to the new no_wait splitted argument TTM functionality. Compile tested only (but thing should run as there is no operating change from driver point of view) Signed-off-by: Jerome Glisse <jglisse@redhat.com> --- drivers/gpu/drm/nouveau/nouveau_bo.c | 45 ++++++++++++++++++-------------- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +- 2 files changed, 27 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c index db0ed4c..f53558b 100644 --- a/drivers/gpu/drm/nouveau/nouveau_bo.c +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c @@ -219,7 +219,7 @@ nouveau_bo_pin(struct nouveau_bo *nvbo, uint32_t memtype) for (i = 0; i < nvbo->placement.num_placement; i++) nvbo->placements[i] |= TTM_PL_FLAG_NO_EVICT; - ret = ttm_bo_validate(bo, &nvbo->placement, false, false); + ret = ttm_bo_validate(bo, &nvbo->placement, false, false, false); if (ret == 0) { switch (bo->mem.mem_type) { case TTM_PL_VRAM: @@ -256,7 +256,7 @@ nouveau_bo_unpin(struct nouveau_bo *nvbo) for (i = 0; i < nvbo->placement.num_placement; i++) nvbo->placements[i] &= ~TTM_PL_FLAG_NO_EVICT; - ret = ttm_bo_validate(bo, &nvbo->placement, false, false); + ret = ttm_bo_validate(bo, &nvbo->placement, false, false, false); if (ret == 0) { switch (bo->mem.mem_type) { case TTM_PL_VRAM: @@ -457,7 +457,8 @@ nouveau_bo_evict_flags(struct ttm_buffer_object *bo, struct ttm_placement *pl) static int nouveau_bo_move_accel_cleanup(struct nouveau_channel *chan, - struct nouveau_bo *nvbo, bool evict, bool no_wait, + struct nouveau_bo *nvbo, bool evict, + bool no_wait_reserve, bool no_wait_gpu, struct ttm_mem_reg *new_mem) { struct nouveau_fence *fence = NULL; @@ -468,7 +469,7 @@ nouveau_bo_move_accel_cleanup(struct nouveau_channel *chan, return ret; ret = ttm_bo_move_accel_cleanup(&nvbo->bo, fence, NULL, - evict, no_wait, new_mem); + evict, no_wait_reserve, no_wait_gpu, new_mem); if (nvbo->channel && nvbo->channel != chan) ret = nouveau_fence_wait(fence, NULL, false, false); nouveau_fence_unref((void *)&fence); @@ -492,7 +493,8 @@ nouveau_bo_mem_ctxdma(struct nouveau_bo *nvbo, struct nouveau_channel *chan, static int nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int evict, bool intr, - int no_wait, struct ttm_mem_reg *new_mem) + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { struct nouveau_bo *nvbo = nouveau_bo(bo); struct drm_nouveau_private *dev_priv = nouveau_bdev(bo->bdev); @@ -570,12 +572,13 @@ nouveau_bo_move_m2mf(struct ttm_buffer_object *bo, int evict, bool intr, dst_offset += (PAGE_SIZE * line_count); } - return nouveau_bo_move_accel_cleanup(chan, nvbo, evict, no_wait, new_mem); + return nouveau_bo_move_accel_cleanup(chan, nvbo, evict, no_wait_reserve, no_wait_gpu, new_mem); } static int nouveau_bo_move_flipd(struct ttm_buffer_object *bo, bool evict, bool intr, - bool no_wait, struct ttm_mem_reg *new_mem) + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { u32 placement_memtype = TTM_PL_FLAG_TT | TTM_PL_MASK_CACHING; struct ttm_placement placement; @@ -588,7 +591,7 @@ nouveau_bo_move_flipd(struct ttm_buffer_object *bo, bool evict, bool intr, tmp_mem = *new_mem; tmp_mem.mm_node = NULL; - ret = ttm_bo_mem_space(bo, &placement, &tmp_mem, intr, no_wait); + ret = ttm_bo_mem_space(bo, &placement, &tmp_mem, intr, no_wait_reserve, no_wait_gpu); if (ret) return ret; @@ -596,11 +599,11 @@ nouveau_bo_move_flipd(struct ttm_buffer_object *bo, bool evict, bool intr, if (ret) goto out; - ret = nouveau_bo_move_m2mf(bo, true, intr, no_wait, &tmp_mem); + ret = nouveau_bo_move_m2mf(bo, true, intr, no_wait_reserve, no_wait_gpu, &tmp_mem); if (ret) goto out; - ret = ttm_bo_move_ttm(bo, evict, no_wait, new_mem); + ret = ttm_bo_move_ttm(bo, evict, no_wait_reserve, no_wait_gpu, new_mem); out: if (tmp_mem.mm_node) { spin_lock(&bo->bdev->glob->lru_lock); @@ -613,7 +616,8 @@ out: static int nouveau_bo_move_flips(struct ttm_buffer_object *bo, bool evict, bool intr, - bool no_wait, struct ttm_mem_reg *new_mem) + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { u32 placement_memtype = TTM_PL_FLAG_TT | TTM_PL_MASK_CACHING; struct ttm_placement placement; @@ -626,15 +630,15 @@ nouveau_bo_move_flips(struct ttm_buffer_object *bo, bool evict, bool intr, tmp_mem = *new_mem; tmp_mem.mm_node = NULL; - ret = ttm_bo_mem_space(bo, &placement, &tmp_mem, intr, no_wait); + ret = ttm_bo_mem_space(bo, &placement, &tmp_mem, intr, no_wait_reserve, no_wait_gpu); if (ret) return ret; - ret = ttm_bo_move_ttm(bo, evict, no_wait, &tmp_mem); + ret = ttm_bo_move_ttm(bo, evict, no_wait_reserve, no_wait_gpu, &tmp_mem); if (ret) goto out; - ret = nouveau_bo_move_m2mf(bo, evict, intr, no_wait, new_mem); + ret = nouveau_bo_move_m2mf(bo, evict, intr, no_wait_reserve, no_wait_gpu, new_mem); if (ret) goto out; @@ -701,7 +705,8 @@ nouveau_bo_vm_cleanup(struct ttm_buffer_object *bo, static int nouveau_bo_move(struct ttm_buffer_object *bo, bool evict, bool intr, - bool no_wait, struct ttm_mem_reg *new_mem) + bool no_wait_reserve, bool no_wait_gpu, + struct ttm_mem_reg *new_mem) { struct drm_nouveau_private *dev_priv = nouveau_bdev(bo->bdev); struct nouveau_bo *nvbo = nouveau_bo(bo); @@ -716,7 +721,7 @@ nouveau_bo_move(struct ttm_buffer_object *bo, bool evict, bool intr, /* Software copy if the card isn't up and running yet. */ if (dev_priv->init_state != NOUVEAU_CARD_INIT_DONE || !dev_priv->channel) { - ret = ttm_bo_move_memcpy(bo, evict, no_wait, new_mem); + ret = ttm_bo_move_memcpy(bo, evict, no_wait_reserve, no_wait_gpu, new_mem); goto out; } @@ -730,17 +735,17 @@ nouveau_bo_move(struct ttm_buffer_object *bo, bool evict, bool intr, /* Hardware assisted copy. */ if (new_mem->mem_type == TTM_PL_SYSTEM) - ret = nouveau_bo_move_flipd(bo, evict, intr, no_wait, new_mem); + ret = nouveau_bo_move_flipd(bo, evict, intr, no_wait_reserve, no_wait_gpu, new_mem); else if (old_mem->mem_type == TTM_PL_SYSTEM) - ret = nouveau_bo_move_flips(bo, evict, intr, no_wait, new_mem); + ret = nouveau_bo_move_flips(bo, evict, intr, no_wait_reserve, no_wait_gpu, new_mem); else - ret = nouveau_bo_move_m2mf(bo, evict, intr, no_wait, new_mem); + ret = nouveau_bo_move_m2mf(bo, evict, intr, no_wait_reserve, no_wait_gpu, new_mem); if (!ret) goto out; /* Fallback to software copy. */ - ret = ttm_bo_move_memcpy(bo, evict, no_wait, new_mem); + ret = ttm_bo_move_memcpy(bo, evict, no_wait_reserve, no_wait_gpu, new_mem); out: if (ret) diff --git a/drivers/gpu/drm/nouveau/nouveau_gem.c b/drivers/gpu/drm/nouveau/nouveau_gem.c index 6ac804b..4539396 100644 --- a/drivers/gpu/drm/nouveau/nouveau_gem.c +++ b/drivers/gpu/drm/nouveau/nouveau_gem.c @@ -374,7 +374,7 @@ validate_list(struct nouveau_channel *chan, struct list_head *list, nvbo->channel = chan; ret = ttm_bo_validate(&nvbo->bo, &nvbo->placement, - false, false); + false, false, false); nvbo->channel = NULL; if (unlikely(ret)) return ret; @@ -690,7 +690,7 @@ nouveau_gem_ioctl_pushbuf_call(struct drm_device *dev, void *data, } nouveau_bo_placement_set(pbbo, 1 << chan->pushbuf_bo->bo.mem.mem_type); - ret = ttm_bo_validate(&pbbo->bo, &pbbo->placement, false, false); + ret = ttm_bo_validate(&pbbo->bo, &pbbo->placement, false, false, false); if (ret) { NV_ERROR(dev, "validate pb: %d\n", ret); ttm_bo_unreserve(&pbbo->bo); -- 1.6.6 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 4/4] drm/vmwgfx: update to TTM no_wait splitted argument 2010-02-25 16:50 ` [PATCH 3/4] drm/nouveau: " Jerome Glisse @ 2010-02-25 16:50 ` Jerome Glisse 0 siblings, 0 replies; 8+ messages in thread From: Jerome Glisse @ 2010-02-25 16:50 UTC (permalink / raw) To: airlied; +Cc: thellstrom, skeggsb, Jerome Glisse, dri-devel This patch update radeon to the new no_wait splitted argument TTM functionality. Compile tested only (but thing should run as there is no operating change from driver point of view) Signed-off-by: Jerome Glisse <jglisse@redhat.com> --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_fb.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index d69caf9..3aaa001 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -494,7 +494,7 @@ static int vmw_validate_single_buffer(struct vmw_private *dev_priv, * Put BO in VRAM, only if there is space. */ - ret = ttm_bo_validate(bo, &vmw_vram_sys_placement, true, false); + ret = ttm_bo_validate(bo, &vmw_vram_sys_placement, true, false, false); if (unlikely(ret == -ERESTARTSYS)) return ret; @@ -514,7 +514,7 @@ static int vmw_validate_single_buffer(struct vmw_private *dev_priv, * previous contents. */ - ret = ttm_bo_validate(bo, &vmw_vram_placement, true, false); + ret = ttm_bo_validate(bo, &vmw_vram_placement, true, false, false); return ret; } diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c index 4f4f643..a002807 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c @@ -625,7 +625,7 @@ int vmw_dmabuf_from_vram(struct vmw_private *vmw_priv, if (unlikely(ret != 0)) return ret; - ret = ttm_bo_validate(bo, &vmw_sys_placement, false, false); + ret = ttm_bo_validate(bo, &vmw_sys_placement, false, false, false); ttm_bo_unreserve(bo); return ret; @@ -649,7 +649,7 @@ int vmw_dmabuf_to_start_of_vram(struct vmw_private *vmw_priv, if (unlikely(ret != 0)) goto err_unlock; - ret = ttm_bo_validate(bo, &ne_placement, false, false); + ret = ttm_bo_validate(bo, &ne_placement, false, false, false); ttm_bo_unreserve(bo); err_unlock: ttm_write_unlock(&vmw_priv->active_master->lock); diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c index 5b6eabe..ad566c8 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c @@ -118,7 +118,7 @@ static int vmw_dmabuf_pin_in_vram(struct vmw_private *dev_priv, if (pin) overlay_placement = &vmw_vram_ne_placement; - ret = ttm_bo_validate(bo, overlay_placement, interruptible, false); + ret = ttm_bo_validate(bo, overlay_placement, interruptible, false, false); ttm_bo_unreserve(bo); -- 1.6.6 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse 2010-02-25 16:50 ` [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument Jerome Glisse @ 2010-02-25 17:11 ` Ville Syrjälä 2010-03-17 10:19 ` Thomas Hellstrom 2 siblings, 0 replies; 8+ messages in thread From: Ville Syrjälä @ 2010-02-25 17:11 UTC (permalink / raw) To: Jerome Glisse; +Cc: skeggsb, thellstrom, dri-devel On Thu, Feb 25, 2010 at 05:50:11PM +0100, Jerome Glisse wrote: > There is case where we want to be able to wait only for the > GPU while not waiting for other buffer to be unreserved. This > patch split the no_wait argument all the way down in the whole > ttm path so that upper level can decide on what to wait on or > not. > > This patch break the API to other modules, update to others > driver are following in separate patches. > > Signed-off-by: Jerome Glisse <jglisse@redhat.com> > --- > drivers/gpu/drm/ttm/ttm_bo.c | 57 ++++++++++++++++++++---------------- > drivers/gpu/drm/ttm/ttm_bo_util.c | 9 ++++-- > include/drm/ttm/ttm_bo_api.h | 6 ++- > include/drm/ttm/ttm_bo_driver.h | 29 +++++++++++------- > 4 files changed, 60 insertions(+), 41 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index c7320ce..d2b2482 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -357,7 +357,8 @@ static int ttm_bo_add_ttm(struct ttm_buffer_object *bo, bool zero_alloc) > > static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, > struct ttm_mem_reg *mem, > - bool evict, bool interruptible, bool no_wait) > + bool evict, bool interruptible, > + bool no_wait_reserve, bool no_wait_gpu) Code which calls these boolean monsters is very hard to read. How about converting all of these booleans into some kind of flags? -- Ville Syrjälä syrjala@sci.fi http://www.sci.fi/~syrjala/ ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse 2010-02-25 16:50 ` [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument Jerome Glisse 2010-02-25 17:11 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Ville Syrjälä @ 2010-03-17 10:19 ` Thomas Hellstrom 2 siblings, 0 replies; 8+ messages in thread From: Thomas Hellstrom @ 2010-03-17 10:19 UTC (permalink / raw) To: Jerome Glisse; +Cc: skeggsb, thellstrom, dri-devel Jerome Glisse wrote: > There is case where we want to be able to wait only for the > GPU while not waiting for other buffer to be unreserved. This > patch split the no_wait argument all the way down in the whole > ttm path so that upper level can decide on what to wait on or > not. > > This patch break the API to other modules, update to others > driver are following in separate patches. > > Signed-off-by: Jerome Glisse <jglisse@redhat.com> > Acked-by: Thomas Hellstrom <thellstrom@vmware.com> > --- > drivers/gpu/drm/ttm/ttm_bo.c | 57 ++++++++++++++++++++---------------- > drivers/gpu/drm/ttm/ttm_bo_util.c | 9 ++++-- > include/drm/ttm/ttm_bo_api.h | 6 ++- > include/drm/ttm/ttm_bo_driver.h | 29 +++++++++++------- > 4 files changed, 60 insertions(+), 41 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index c7320ce..d2b2482 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -357,7 +357,8 @@ static int ttm_bo_add_ttm(struct ttm_buffer_object *bo, bool zero_alloc) > > static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, > struct ttm_mem_reg *mem, > - bool evict, bool interruptible, bool no_wait) > + bool evict, bool interruptible, > + bool no_wait_reserve, bool no_wait_gpu) > { > struct ttm_bo_device *bdev = bo->bdev; > bool old_is_pci = ttm_mem_reg_is_pci(bdev, &bo->mem); > @@ -402,12 +403,12 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, > > if (!(old_man->flags & TTM_MEMTYPE_FLAG_FIXED) && > !(new_man->flags & TTM_MEMTYPE_FLAG_FIXED)) > - ret = ttm_bo_move_ttm(bo, evict, no_wait, mem); > + ret = ttm_bo_move_ttm(bo, evict, no_wait_reserve, no_wait_gpu, mem); > else if (bdev->driver->move) > ret = bdev->driver->move(bo, evict, interruptible, > - no_wait, mem); > + no_wait_reserve, no_wait_gpu, mem); > else > - ret = ttm_bo_move_memcpy(bo, evict, no_wait, mem); > + ret = ttm_bo_move_memcpy(bo, evict, no_wait_reserve, no_wait_gpu, mem); > > if (ret) > goto out_err; > @@ -606,7 +607,7 @@ void ttm_bo_unref(struct ttm_buffer_object **p_bo) > EXPORT_SYMBOL(ttm_bo_unref); > > static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, > - bool no_wait) > + bool no_wait_reserve, bool no_wait_gpu) > { > struct ttm_bo_device *bdev = bo->bdev; > struct ttm_bo_global *glob = bo->glob; > @@ -615,7 +616,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, > int ret = 0; > > spin_lock(&bo->lock); > - ret = ttm_bo_wait(bo, false, interruptible, no_wait); > + ret = ttm_bo_wait(bo, false, interruptible, no_wait_gpu); > spin_unlock(&bo->lock); > > if (unlikely(ret != 0)) { > @@ -638,7 +639,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, > placement.num_busy_placement = 0; > bdev->driver->evict_flags(bo, &placement); > ret = ttm_bo_mem_space(bo, &placement, &evict_mem, interruptible, > - no_wait); > + no_wait_reserve, no_wait_gpu); > if (ret) { > if (ret != -ERESTARTSYS) { > printk(KERN_ERR TTM_PFX > @@ -650,7 +651,7 @@ static int ttm_bo_evict(struct ttm_buffer_object *bo, bool interruptible, > } > > ret = ttm_bo_handle_move_mem(bo, &evict_mem, true, interruptible, > - no_wait); > + no_wait_reserve, no_wait_gpu); > if (ret) { > if (ret != -ERESTARTSYS) > printk(KERN_ERR TTM_PFX "Buffer eviction failed\n"); > @@ -670,7 +671,8 @@ out: > > static int ttm_mem_evict_first(struct ttm_bo_device *bdev, > uint32_t mem_type, > - bool interruptible, bool no_wait) > + bool interruptible, bool no_wait_reserve, > + bool no_wait_gpu) > { > struct ttm_bo_global *glob = bdev->glob; > struct ttm_mem_type_manager *man = &bdev->man[mem_type]; > @@ -687,11 +689,11 @@ retry: > bo = list_first_entry(&man->lru, struct ttm_buffer_object, lru); > kref_get(&bo->list_kref); > > - ret = ttm_bo_reserve_locked(bo, false, true, false, 0); > + ret = ttm_bo_reserve_locked(bo, false, no_wait_reserve, false, 0); > > if (unlikely(ret == -EBUSY)) { > spin_unlock(&glob->lru_lock); > - if (likely(!no_wait)) > + if (likely(!no_wait_gpu)) > ret = ttm_bo_wait_unreserved(bo, interruptible); > > kref_put(&bo->list_kref, ttm_bo_release_list); > @@ -713,7 +715,7 @@ retry: > while (put_count--) > kref_put(&bo->list_kref, ttm_bo_ref_bug); > > - ret = ttm_bo_evict(bo, interruptible, no_wait); > + ret = ttm_bo_evict(bo, interruptible, no_wait_reserve, no_wait_gpu); > ttm_bo_unreserve(bo); > > kref_put(&bo->list_kref, ttm_bo_release_list); > @@ -764,7 +766,9 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, > uint32_t mem_type, > struct ttm_placement *placement, > struct ttm_mem_reg *mem, > - bool interruptible, bool no_wait) > + bool interruptible, > + bool no_wait_reserve, > + bool no_wait_gpu) > { > struct ttm_bo_device *bdev = bo->bdev; > struct ttm_bo_global *glob = bdev->glob; > @@ -785,7 +789,7 @@ static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, > } > spin_unlock(&glob->lru_lock); > ret = ttm_mem_evict_first(bdev, mem_type, interruptible, > - no_wait); > + no_wait_reserve, no_wait_gpu); > if (unlikely(ret != 0)) > return ret; > } while (1); > @@ -855,7 +859,8 @@ static bool ttm_bo_mt_compatible(struct ttm_mem_type_manager *man, > int ttm_bo_mem_space(struct ttm_buffer_object *bo, > struct ttm_placement *placement, > struct ttm_mem_reg *mem, > - bool interruptible, bool no_wait) > + bool interruptible, bool no_wait_reserve, > + bool no_wait_gpu) > { > struct ttm_bo_device *bdev = bo->bdev; > struct ttm_mem_type_manager *man; > @@ -952,7 +957,7 @@ int ttm_bo_mem_space(struct ttm_buffer_object *bo, > } > > ret = ttm_bo_mem_force_space(bo, mem_type, placement, mem, > - interruptible, no_wait); > + interruptible, no_wait_reserve, no_wait_gpu); > if (ret == 0 && mem->mm_node) { > mem->placement = cur_flags; > mem->mm_node->private = bo; > @@ -978,7 +983,8 @@ EXPORT_SYMBOL(ttm_bo_wait_cpu); > > int ttm_bo_move_buffer(struct ttm_buffer_object *bo, > struct ttm_placement *placement, > - bool interruptible, bool no_wait) > + bool interruptible, bool no_wait_reserve, > + bool no_wait_gpu) > { > struct ttm_bo_global *glob = bo->glob; > int ret = 0; > @@ -992,7 +998,7 @@ int ttm_bo_move_buffer(struct ttm_buffer_object *bo, > * instead of doing it here. > */ > spin_lock(&bo->lock); > - ret = ttm_bo_wait(bo, false, interruptible, no_wait); > + ret = ttm_bo_wait(bo, false, interruptible, no_wait_gpu); > spin_unlock(&bo->lock); > if (ret) > return ret; > @@ -1002,10 +1008,10 @@ int ttm_bo_move_buffer(struct ttm_buffer_object *bo, > /* > * Determine where to move the buffer. > */ > - ret = ttm_bo_mem_space(bo, placement, &mem, interruptible, no_wait); > + ret = ttm_bo_mem_space(bo, placement, &mem, interruptible, no_wait_reserve, no_wait_gpu); > if (ret) > goto out_unlock; > - ret = ttm_bo_handle_move_mem(bo, &mem, false, interruptible, no_wait); > + ret = ttm_bo_handle_move_mem(bo, &mem, false, interruptible, no_wait_reserve, no_wait_gpu); > out_unlock: > if (ret && mem.mm_node) { > spin_lock(&glob->lru_lock); > @@ -1039,7 +1045,8 @@ static int ttm_bo_mem_compat(struct ttm_placement *placement, > > int ttm_bo_validate(struct ttm_buffer_object *bo, > struct ttm_placement *placement, > - bool interruptible, bool no_wait) > + bool interruptible, bool no_wait_reserve, > + bool no_wait_gpu) > { > int ret; > > @@ -1054,7 +1061,7 @@ int ttm_bo_validate(struct ttm_buffer_object *bo, > */ > ret = ttm_bo_mem_compat(placement, &bo->mem); > if (ret < 0) { > - ret = ttm_bo_move_buffer(bo, placement, interruptible, no_wait); > + ret = ttm_bo_move_buffer(bo, placement, interruptible, no_wait_reserve, no_wait_gpu); > if (ret) > return ret; > } else { > @@ -1175,7 +1182,7 @@ int ttm_bo_init(struct ttm_bo_device *bdev, > goto out_err; > } > > - ret = ttm_bo_validate(bo, placement, interruptible, false); > + ret = ttm_bo_validate(bo, placement, interruptible, false, false); > if (ret) > goto out_err; > > @@ -1249,7 +1256,7 @@ static int ttm_bo_force_list_clean(struct ttm_bo_device *bdev, > spin_lock(&glob->lru_lock); > while (!list_empty(&man->lru)) { > spin_unlock(&glob->lru_lock); > - ret = ttm_mem_evict_first(bdev, mem_type, false, false); > + ret = ttm_mem_evict_first(bdev, mem_type, false, false, false); > if (ret) { > if (allow_errors) { > return ret; > @@ -1839,7 +1846,7 @@ static int ttm_bo_swapout(struct ttm_mem_shrink *shrink) > evict_mem.mem_type = TTM_PL_SYSTEM; > > ret = ttm_bo_handle_move_mem(bo, &evict_mem, true, > - false, false); > + false, false, false); > if (unlikely(ret != 0)) > goto out; > } > diff --git a/drivers/gpu/drm/ttm/ttm_bo_util.c b/drivers/gpu/drm/ttm/ttm_bo_util.c > index 3f72fe1..db43b30 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo_util.c > +++ b/drivers/gpu/drm/ttm/ttm_bo_util.c > @@ -49,7 +49,8 @@ void ttm_bo_free_old_node(struct ttm_buffer_object *bo) > } > > int ttm_bo_move_ttm(struct ttm_buffer_object *bo, > - bool evict, bool no_wait, struct ttm_mem_reg *new_mem) > + bool evict, bool no_wait_reserve, > + bool no_wait_gpu, struct ttm_mem_reg *new_mem) > { > struct ttm_tt *ttm = bo->ttm; > struct ttm_mem_reg *old_mem = &bo->mem; > @@ -207,7 +208,8 @@ static int ttm_copy_ttm_io_page(struct ttm_tt *ttm, void *dst, > } > > int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, > - bool evict, bool no_wait, struct ttm_mem_reg *new_mem) > + bool evict, bool no_wait_reserve, bool no_wait_gpu, > + struct ttm_mem_reg *new_mem) > { > struct ttm_bo_device *bdev = bo->bdev; > struct ttm_mem_type_manager *man = &bdev->man[new_mem->mem_type]; > @@ -525,7 +527,8 @@ int ttm_bo_pfn_prot(struct ttm_buffer_object *bo, > int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, > void *sync_obj, > void *sync_obj_arg, > - bool evict, bool no_wait, > + bool evict, bool no_wait_reserve, > + bool no_wait_gpu, > struct ttm_mem_reg *new_mem) > { > struct ttm_bo_device *bdev = bo->bdev; > diff --git a/include/drm/ttm/ttm_bo_api.h b/include/drm/ttm/ttm_bo_api.h > index 81eb9f4..8c8005e 100644 > --- a/include/drm/ttm/ttm_bo_api.h > +++ b/include/drm/ttm/ttm_bo_api.h > @@ -313,7 +313,8 @@ extern int ttm_bo_wait(struct ttm_buffer_object *bo, bool lazy, > * @bo: The buffer object. > * @placement: Proposed placement for the buffer object. > * @interruptible: Sleep interruptible if sleeping. > - * @no_wait: Return immediately if the buffer is busy. > + * @no_wait_reserve: Return immediately if other buffers are busy. > + * @no_wait_gpu: Return immediately if the GPU is busy. > * > * Changes placement and caching policy of the buffer object > * according proposed placement. > @@ -325,7 +326,8 @@ extern int ttm_bo_wait(struct ttm_buffer_object *bo, bool lazy, > */ > extern int ttm_bo_validate(struct ttm_buffer_object *bo, > struct ttm_placement *placement, > - bool interruptible, bool no_wait); > + bool interruptible, bool no_wait_reserve, > + bool no_wait_gpu); > > /** > * ttm_bo_unref > diff --git a/include/drm/ttm/ttm_bo_driver.h b/include/drm/ttm/ttm_bo_driver.h > index 4c4e0f8..999fbcb 100644 > --- a/include/drm/ttm/ttm_bo_driver.h > +++ b/include/drm/ttm/ttm_bo_driver.h > @@ -312,7 +312,8 @@ struct ttm_bo_driver { > */ > int (*move) (struct ttm_buffer_object *bo, > bool evict, bool interruptible, > - bool no_wait, struct ttm_mem_reg *new_mem); > + bool no_wait_reserve, bool no_wait_gpu, > + struct ttm_mem_reg *new_mem); > > /** > * struct ttm_bo_driver_member verify_access > @@ -634,7 +635,8 @@ extern bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, > * @proposed_placement: Proposed new placement for the buffer object. > * @mem: A struct ttm_mem_reg. > * @interruptible: Sleep interruptible when sliping. > - * @no_wait: Don't sleep waiting for space to become available. > + * @no_wait_reserve: Return immediately if other buffers are busy. > + * @no_wait_gpu: Return immediately if the GPU is busy. > * > * Allocate memory space for the buffer object pointed to by @bo, using > * the placement flags in @mem, potentially evicting other idle buffer objects. > @@ -648,7 +650,8 @@ extern bool ttm_mem_reg_is_pci(struct ttm_bo_device *bdev, > extern int ttm_bo_mem_space(struct ttm_buffer_object *bo, > struct ttm_placement *placement, > struct ttm_mem_reg *mem, > - bool interruptible, bool no_wait); > + bool interruptible, > + bool no_wait_reserve, bool no_wait_gpu); > /** > * ttm_bo_wait_for_cpu > * > @@ -827,7 +830,8 @@ extern void ttm_bo_unblock_reservation(struct ttm_buffer_object *bo); > * > * @bo: A pointer to a struct ttm_buffer_object. > * @evict: 1: This is an eviction. Don't try to pipeline. > - * @no_wait: Never sleep, but rather return with -EBUSY. > + * @no_wait_reserve: Return immediately if other buffers are busy. > + * @no_wait_gpu: Return immediately if the GPU is busy. > * @new_mem: struct ttm_mem_reg indicating where to move. > * > * Optimized move function for a buffer object with both old and > @@ -841,15 +845,16 @@ extern void ttm_bo_unblock_reservation(struct ttm_buffer_object *bo); > */ > > extern int ttm_bo_move_ttm(struct ttm_buffer_object *bo, > - bool evict, bool no_wait, > - struct ttm_mem_reg *new_mem); > + bool evict, bool no_wait_reserve, > + bool no_wait_gpu, struct ttm_mem_reg *new_mem); > > /** > * ttm_bo_move_memcpy > * > * @bo: A pointer to a struct ttm_buffer_object. > * @evict: 1: This is an eviction. Don't try to pipeline. > - * @no_wait: Never sleep, but rather return with -EBUSY. > + * @no_wait_reserve: Return immediately if other buffers are busy. > + * @no_wait_gpu: Return immediately if the GPU is busy. > * @new_mem: struct ttm_mem_reg indicating where to move. > * > * Fallback move function for a mappable buffer object in mappable memory. > @@ -863,8 +868,8 @@ extern int ttm_bo_move_ttm(struct ttm_buffer_object *bo, > */ > > extern int ttm_bo_move_memcpy(struct ttm_buffer_object *bo, > - bool evict, > - bool no_wait, struct ttm_mem_reg *new_mem); > + bool evict, bool no_wait_reserve, > + bool no_wait_gpu, struct ttm_mem_reg *new_mem); > > /** > * ttm_bo_free_old_node > @@ -883,7 +888,8 @@ extern void ttm_bo_free_old_node(struct ttm_buffer_object *bo); > * @sync_obj_arg: An argument to pass to the sync object idle / wait > * functions. > * @evict: This is an evict move. Don't return until the buffer is idle. > - * @no_wait: Never sleep, but rather return with -EBUSY. > + * @no_wait_reserve: Return immediately if other buffers are busy. > + * @no_wait_gpu: Return immediately if the GPU is busy. > * @new_mem: struct ttm_mem_reg indicating where to move. > * > * Accelerated move function to be called when an accelerated move > @@ -897,7 +903,8 @@ extern void ttm_bo_free_old_node(struct ttm_buffer_object *bo); > extern int ttm_bo_move_accel_cleanup(struct ttm_buffer_object *bo, > void *sync_obj, > void *sync_obj_arg, > - bool evict, bool no_wait, > + bool evict, bool no_wait_reserve, > + bool no_wait_gpu, > struct ttm_mem_reg *new_mem); > /** > * ttm_io_prot > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) 2010-02-25 16:50 TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse @ 2010-03-04 10:12 ` Jerome Glisse 1 sibling, 0 replies; 8+ messages in thread From: Jerome Glisse @ 2010-03-04 10:12 UTC (permalink / raw) To: thomas; +Cc: skeggsb, thellstrom, dri-devel On Thu, Feb 25, 2010 at 05:50:10PM +0100, Jerome Glisse wrote: > This patch change the TTM API to allow driver to select btw choosing > to wait or not either for bo reserve or GPU wait separately. This is > needed for the unmappabled VRAM work. > > Comments ? > > Cheers, > Jerome Thomas any chance you review both this change and the iomap callback change ? The merge window is closing soon. Cheers, Jerome ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev -- ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-03-17 10:19 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-02-25 16:50 TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse 2010-02-25 16:50 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Jerome Glisse 2010-02-25 16:50 ` [PATCH 2/4] drm/radeon/kms: update to TTM no_wait splitted argument Jerome Glisse 2010-02-25 16:50 ` [PATCH 3/4] drm/nouveau: " Jerome Glisse 2010-02-25 16:50 ` [PATCH 4/4] drm/vmwgfx: " Jerome Glisse 2010-02-25 17:11 ` [PATCH 1/4] drm/ttm: split no_wait argument in 2 GPU or reserve wait Ville Syrjälä 2010-03-17 10:19 ` Thomas Hellstrom 2010-03-04 10:12 ` TTM split no_wait argument in 2 (no_wait_reserve, no_wait_gpu) Jerome Glisse
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.