Re: iptables pull request, add XT_RECENT_REAP support

[Tim Gardner <timg@tpi.com>]

[-- Attachment #1: Type: text/plain, Size: 1195 bytes --]

On 03/17/2010 01:34 PM, Eric Dumazet wrote:
> Le mercredi 17 mars 2010 à 12:48 -0600, Tim Gardner a écrit :
>> diff --git a/extensions/libxt_recent.man b/extensions/libxt_recent.man
>> index 532c328..26e4fb9 100644
>> --- a/extensions/libxt_recent.man
>> +++ b/extensions/libxt_recent.man
>> @@ -41,6 +41,11 @@ This option must be used in conjunction with one of \fB\-\-rcheck\fP or
>>   \fB\-\-update\fP. When used, this will narrow the match to only happen when the
>>   address is in the list and was seen within the last given number of seconds.
>>   .TP
>> +\fB\-\-reap\fP \fIreap\fP
>> +This option must be used in conjunction with \fB\-\-seconds\fP. When used, this
>> +will remove entries with the most recent timestamp older then \fB\-\-seconds\fP
>> +since the last packet was received.
>> +.TP
>>   \fB\-\-hitcount\fP \fIhits\fP
>>   This option must be used in conjunction with one of \fB\-\-rcheck\fP or
>>   \fB\-\-update\fP. When used, this will narrow the match to only happen when the
>
> Are you sure this "most recent timestamp older then " is correct ? ;)
>
>
>

How about this (attached):

rtg
-- 
Tim Gardner timg@tpi.com www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357

[-- Attachment #2: 0001-xt_recent-Simplified-and-corrected-some-man-page-ver.patch --]
[-- Type: text/x-diff, Size: 1369 bytes --]

>From e89de2a97d4336795503bb3406ba494338a06292 Mon Sep 17 00:00:00 2001
From: Tim Gardner <tim.gardner@canonical.com>
Date: Wed, 17 Mar 2010 14:36:17 -0600
Subject: [PATCH] xt_recent: Simplified and corrected some man page verbage about --reap

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
---
 extensions/libxt_recent.man |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/extensions/libxt_recent.man b/extensions/libxt_recent.man
index 26e4fb9..342c383 100644
--- a/extensions/libxt_recent.man
+++ b/extensions/libxt_recent.man
@@ -41,10 +41,10 @@ This option must be used in conjunction with one of \fB\-\-rcheck\fP or
 \fB\-\-update\fP. When used, this will narrow the match to only happen when the
 address is in the list and was seen within the last given number of seconds.
 .TP
-\fB\-\-reap\fP \fIreap\fP
-This option must be used in conjunction with \fB\-\-seconds\fP. When used, this
-will remove entries with the most recent timestamp older then \fB\-\-seconds\fP
-since the last packet was received.
+\fB\-\-reap\fP
+This option may be used in conjunction with \fB\-\-seconds\fP. When used, this
+will remove entries that have not received a packet within the time specified by
+\fB\-\-seconds\fP.
 .TP
 \fB\-\-hitcount\fP \fIhits\fP
 This option must be used in conjunction with one of \fB\-\-rcheck\fP or
-- 
1.7.0