From: Tim Gardner <timg@tpi.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: kaber@trash.net, netfilter-devel@vger.kernel.org
Subject: Re: iptables pull request, add XT_RECENT_REAP support
Date: Wed, 17 Mar 2010 14:21:23 -0600 [thread overview]
Message-ID: <4BA139C3.3010805@tpi.com> (raw)
In-Reply-To: <1268855402.2894.18.camel@edumazet-laptop>
On 03/17/2010 01:50 PM, Eric Dumazet wrote:
> Le mercredi 17 mars 2010 à 13:44 -0600, Tim Gardner a écrit :
>> On 03/17/2010 01:34 PM, Eric Dumazet wrote:
>>> Le mercredi 17 mars 2010 à 12:48 -0600, Tim Gardner a écrit :
>>>> diff --git a/extensions/libxt_recent.man b/extensions/libxt_recent.man
>>>> index 532c328..26e4fb9 100644
>>>> --- a/extensions/libxt_recent.man
>>>> +++ b/extensions/libxt_recent.man
>>>> @@ -41,6 +41,11 @@ This option must be used in conjunction with one of \fB\-\-rcheck\fP or
>>>> \fB\-\-update\fP. When used, this will narrow the match to only happen when the
>>>> address is in the list and was seen within the last given number of seconds.
>>>> .TP
>>>> +\fB\-\-reap\fP \fIreap\fP
>>>> +This option must be used in conjunction with \fB\-\-seconds\fP. When used, this
>>>> +will remove entries with the most recent timestamp older then \fB\-\-seconds\fP
>>>> +since the last packet was received.
>>>> +.TP
>>>> \fB\-\-hitcount\fP \fIhits\fP
>>>> This option must be used in conjunction with one of \fB\-\-rcheck\fP or
>>>> \fB\-\-update\fP. When used, this will narrow the match to only happen when the
>>>
>>> Are you sure this "most recent timestamp older then " is correct ? ;)
>>>
>>>
>>>
>>
>> That does kind of make my head hurt. Perhaps it is better stated, "When
>> used, this will remove entries that have not received a packet in the
>> time specified by --seconds."
>>
>
> Well, it will remove the oldest entry, if its age is more than time
> specifed by --seconds.
>
> ie you wrote "most recent" instead of "least recent" ----> "oldest"
>
>
>
Which is probably why my head hurt. Do you agree that the second version
is clearer?
rtg
--
Tim Gardner timg@tpi.com www.tpi.com
OR 503-601-0234 x102 MT 406-443-5357
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-17 20:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 18:48 iptables pull request, add XT_RECENT_REAP support Tim Gardner
2010-03-17 19:34 ` Eric Dumazet
2010-03-17 19:44 ` Tim Gardner
2010-03-17 19:50 ` Eric Dumazet
2010-03-17 20:21 ` Tim Gardner [this message]
2010-03-17 20:40 ` Tim Gardner
2010-03-18 13:05 ` Patrick McHardy
2010-03-17 20:13 ` Jan Engelhardt
2010-03-17 20:26 ` Tim Gardner
2010-03-17 20:14 ` Jan Engelhardt
2010-03-17 20:29 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA139C3.3010805@tpi.com \
--to=timg@tpi.com \
--cc=eric.dumazet@gmail.com \
--cc=kaber@trash.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.