All of lore.kernel.org
 help / color / mirror / Atom feed
* Patch "Don't inherit siteinfo in base.bbclass" breaks SlugOS
@ 2010-03-20  3:00 Mike Westerhof
  2010-03-20  3:16 ` Chris Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Westerhof @ 2010-03-20  3:00 UTC (permalink / raw)
  To: openembedded-devel

The following commit breaks SlugOS.  I apologize for starting a new
thread on this, but I am unable to find the original discussion on the
OE ml (but I probably missed it in the several hundred that piled up in
my inbox this week).

------------
commit a215c2f283476776567506c2e3f969c48f7e5e3d
Author: Chris Larson <chris_larson@mentor.com>
Date:   Tue Mar 9 16:54:57 2010 -0700

    Don't inherit siteinfo in base.bbclass

    Acked-by: Richard Purdie <rpurdie@linux.intel.com>
    Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
    Signed-off-by: Chris Larson <chris_larson@mentor.com>
------------

In a nutshell, the ixp4xx can run in either endianess, and SlugOS builds
both a BE and an LE image.  Removing "inherit siteinfo" from
base.bbclass causes parsing failures in every recipe.

As an example of the issue, consider this lines in
conf/distro/include/slugos.conf:

IMAGE_BASENAME = "${@['slugos${SITEINFO_ENDIANESS}',
'ucslugc'][bb.data.getVar('TARGET_OS', d, 1) == 'linux-uclibc']}"

and

DISTRO_NAME ?=
"INVALID-${SITEINFO_ENDIANESS}-${ARM_INSTRUCTION_SET}-${TARGET_OS}"

There may be other locations (such as recipes, etc) where this problem
may exist, these were just the two locations I found easily.

Any ideas how to address this?

-Mike (mwester)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "Don't inherit siteinfo in base.bbclass" breaks SlugOS
  2010-03-20  3:00 Patch "Don't inherit siteinfo in base.bbclass" breaks SlugOS Mike Westerhof
@ 2010-03-20  3:16 ` Chris Larson
  2010-03-20  3:20   ` Chris Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Chris Larson @ 2010-03-20  3:16 UTC (permalink / raw)
  To: openembedded-devel

Damn, I fixed all the recipes using SITEINFO, but missed distros, sorry
about that.
I'd suggest doing INHERIT += "siteinfo" in the distro .conf, for now.
 Again, sorry about the breakage.

On Fri, Mar 19, 2010 at 8:00 PM, Mike Westerhof <mike@mwester.net> wrote:

> The following commit breaks SlugOS.  I apologize for starting a new
> thread on this, but I am unable to find the original discussion on the
> OE ml (but I probably missed it in the several hundred that piled up in
> my inbox this week).
>
> ------------
> commit a215c2f283476776567506c2e3f969c48f7e5e3d
> Author: Chris Larson <chris_larson@mentor.com>
> Date:   Tue Mar 9 16:54:57 2010 -0700
>
>    Don't inherit siteinfo in base.bbclass
>
>    Acked-by: Richard Purdie <rpurdie@linux.intel.com>
>    Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
>    Signed-off-by: Chris Larson <chris_larson@mentor.com>
> ------------
>
> In a nutshell, the ixp4xx can run in either endianess, and SlugOS builds
> both a BE and an LE image.  Removing "inherit siteinfo" from
> base.bbclass causes parsing failures in every recipe.
>
> As an example of the issue, consider this lines in
> conf/distro/include/slugos.conf:
>
> IMAGE_BASENAME = "${@['slugos${SITEINFO_ENDIANESS}',
> 'ucslugc'][bb.data.getVar('TARGET_OS', d, 1) == 'linux-uclibc']}"
>
> and
>
> DISTRO_NAME ?=
> "INVALID-${SITEINFO_ENDIANESS}-${ARM_INSTRUCTION_SET}-${TARGET_OS}"
>
> There may be other locations (such as recipes, etc) where this problem
> may exist, these were just the two locations I found easily.
>
> Any ideas how to address this?
>
> -Mike (mwester)
>
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>



-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Patch "Don't inherit siteinfo in base.bbclass" breaks SlugOS
  2010-03-20  3:16 ` Chris Larson
@ 2010-03-20  3:20   ` Chris Larson
  0 siblings, 0 replies; 3+ messages in thread
From: Chris Larson @ 2010-03-20  3:20 UTC (permalink / raw)
  To: openembedded-devel

Should be fixed now.

On Fri, Mar 19, 2010 at 8:16 PM, Chris Larson <clarson@kergoth.com> wrote:

> Damn, I fixed all the recipes using SITEINFO, but missed distros, sorry
> about that.
> I'd suggest doing INHERIT += "siteinfo" in the distro .conf, for now.
>  Again, sorry about the breakage.
>
>
> On Fri, Mar 19, 2010 at 8:00 PM, Mike Westerhof <mike@mwester.net> wrote:
>
>> The following commit breaks SlugOS.  I apologize for starting a new
>> thread on this, but I am unable to find the original discussion on the
>> OE ml (but I probably missed it in the several hundred that piled up in
>> my inbox this week).
>>
>> ------------
>> commit a215c2f283476776567506c2e3f969c48f7e5e3d
>> Author: Chris Larson <chris_larson@mentor.com>
>> Date:   Tue Mar 9 16:54:57 2010 -0700
>>
>>    Don't inherit siteinfo in base.bbclass
>>
>>    Acked-by: Richard Purdie <rpurdie@linux.intel.com>
>>    Acked-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
>>    Signed-off-by: Chris Larson <chris_larson@mentor.com>
>> ------------
>>
>> In a nutshell, the ixp4xx can run in either endianess, and SlugOS builds
>> both a BE and an LE image.  Removing "inherit siteinfo" from
>> base.bbclass causes parsing failures in every recipe.
>>
>> As an example of the issue, consider this lines in
>> conf/distro/include/slugos.conf:
>>
>> IMAGE_BASENAME = "${@['slugos${SITEINFO_ENDIANESS}',
>> 'ucslugc'][bb.data.getVar('TARGET_OS', d, 1) == 'linux-uclibc']}"
>>
>> and
>>
>> DISTRO_NAME ?=
>> "INVALID-${SITEINFO_ENDIANESS}-${ARM_INSTRUCTION_SET}-${TARGET_OS}"
>>
>> There may be other locations (such as recipes, etc) where this problem
>> may exist, these were just the two locations I found easily.
>>
>> Any ideas how to address this?
>>
>> -Mike (mwester)
>>
>>
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
>
>
> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
>



-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-03-20  3:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-20  3:00 Patch "Don't inherit siteinfo in base.bbclass" breaks SlugOS Mike Westerhof
2010-03-20  3:16 ` Chris Larson
2010-03-20  3:20   ` Chris Larson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.