All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Giel van Schijndel <me@mortis.eu>
Cc: Jean Delvare <khali@linux-fr.org>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/2] Hwmon: f71882fg: fixed braces coding
Date: Mon, 22 Mar 2010 09:30:54 +0000	[thread overview]
Message-ID: <4BA738CE.8000901@redhat.com> (raw)
In-Reply-To: <1269185834-10266-1-git-send-email-me@mortis.eu>

Ack.

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 03/21/2010 04:37 PM, Giel van Schijndel wrote:
> Fixed several coding style issues.
>
> Signed-off-by: Giel van Schijndel<me@mortis.eu>
> ---
>   drivers/hwmon/f71882fg.c |   11 +++++------
>   1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> index a95fa42..21bc661 100644
> --- a/drivers/hwmon/f71882fg.c
> +++ b/drivers/hwmon/f71882fg.c
> @@ -866,11 +866,11 @@ static int superio_inw(int base, int reg)
>   static inline void superio_enter(int base)
>   {
>   	/* according to the datasheet the key must be send twice! */
> -	outb( SIO_UNLOCK_KEY, base);
> -	outb( SIO_UNLOCK_KEY, base);
> +	outb(SIO_UNLOCK_KEY, base);
> +	outb(SIO_UNLOCK_KEY, base);
>   }
>
> -static inline void superio_select( int base, int ld)
> +static inline void superio_select(int base, int ld)
>   {
>   	outb(SIO_REG_LDSEL, base);
>   	outb(ld, base + 1);
> @@ -945,7 +945,7 @@ static struct f71882fg_data *f71882fg_update_device(struct device *dev)
>   	mutex_lock(&data->update_lock);
>
>   	/* Update once every 60 seconds */
> -	if ( time_after(jiffies, data->last_limits + 60 * HZ ) ||
> +	if (time_after(jiffies, data->last_limits + 60 * HZ) ||
>   			!data->valid) {
>   		if (data->type = f71882fg || data->type = f71889fg) {
>   			data->in1_max > @@ -2151,8 +2151,7 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address,
>   	}
>
>   	*address = superio_inw(sioaddr, SIO_REG_ADDR);
> -	if (*address = 0)
> -	{
> +	if (*address = 0) {
>   		printk(KERN_WARNING DRVNAME ": Base address not set\n");
>   		goto exit;
>   	}

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Giel van Schijndel <me@mortis.eu>
Cc: Jean Delvare <khali@linux-fr.org>,
	Jonathan Cameron <jic23@cam.ac.uk>,
	lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues
Date: Mon, 22 Mar 2010 10:30:54 +0100	[thread overview]
Message-ID: <4BA738CE.8000901@redhat.com> (raw)
In-Reply-To: <1269185834-10266-1-git-send-email-me@mortis.eu>

Ack.

Acked-by: Hans de Goede <hdegoede@redhat.com>

On 03/21/2010 04:37 PM, Giel van Schijndel wrote:
> Fixed several coding style issues.
>
> Signed-off-by: Giel van Schijndel<me@mortis.eu>
> ---
>   drivers/hwmon/f71882fg.c |   11 +++++------
>   1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c
> index a95fa42..21bc661 100644
> --- a/drivers/hwmon/f71882fg.c
> +++ b/drivers/hwmon/f71882fg.c
> @@ -866,11 +866,11 @@ static int superio_inw(int base, int reg)
>   static inline void superio_enter(int base)
>   {
>   	/* according to the datasheet the key must be send twice! */
> -	outb( SIO_UNLOCK_KEY, base);
> -	outb( SIO_UNLOCK_KEY, base);
> +	outb(SIO_UNLOCK_KEY, base);
> +	outb(SIO_UNLOCK_KEY, base);
>   }
>
> -static inline void superio_select( int base, int ld)
> +static inline void superio_select(int base, int ld)
>   {
>   	outb(SIO_REG_LDSEL, base);
>   	outb(ld, base + 1);
> @@ -945,7 +945,7 @@ static struct f71882fg_data *f71882fg_update_device(struct device *dev)
>   	mutex_lock(&data->update_lock);
>
>   	/* Update once every 60 seconds */
> -	if ( time_after(jiffies, data->last_limits + 60 * HZ ) ||
> +	if (time_after(jiffies, data->last_limits + 60 * HZ) ||
>   			!data->valid) {
>   		if (data->type == f71882fg || data->type == f71889fg) {
>   			data->in1_max =
> @@ -2151,8 +2151,7 @@ static int __init f71882fg_find(int sioaddr, unsigned short *address,
>   	}
>
>   	*address = superio_inw(sioaddr, SIO_REG_ADDR);
> -	if (*address == 0)
> -	{
> +	if (*address == 0) {
>   		printk(KERN_WARNING DRVNAME ": Base address not set\n");
>   		goto exit;
>   	}

  parent reply	other threads:[~2010-03-22  9:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-21 15:37 [lm-sensors] [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style Giel van Schijndel
2010-03-21 15:37 ` [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues Giel van Schijndel
2010-03-21 15:37 ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Giel van Schijndel
2010-03-21 15:37   ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Giel van Schijndel
2010-03-22  9:30   ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Hans de Goede
2010-03-22  9:30     ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Hans de Goede
2010-03-22 10:23   ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Jean Delvare
2010-03-22 10:23     ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Jean Delvare
2010-03-22 11:41     ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Giel van Schijndel
2010-03-22 11:41       ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Giel van Schijndel
2010-03-23 10:59       ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Jean Delvare
2010-03-23 10:59         ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Jean Delvare
2010-03-23 11:07         ` [lm-sensors] [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) Hans de Goede
2010-03-23 11:07           ` [PATCH 2/2] Hwmon: f71882fg: use strict_stro(l|ul) instead of simple_strto$1 Hans de Goede
2010-03-22  9:30 ` Hans de Goede [this message]
2010-03-22  9:30   ` [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues Hans de Goede
2010-03-22 10:20   ` [lm-sensors] [PATCH 1/2] Hwmon: f71882fg: fixed braces coding Jean Delvare
2010-03-22 10:20     ` [PATCH 1/2] Hwmon: f71882fg: fixed braces coding style issues Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA738CE.8000901@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=jic23@cam.ac.uk \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=me@mortis.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.