From: Nigel Cunningham <ncunningham@crca.org.au>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Josef Bacik <josef@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.mason@oracle.com, hch@lst.de
Subject: Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl
Date: Wed, 24 Mar 2010 11:25:15 +1100 [thread overview]
Message-ID: <4BA95BEB.7040805@crca.org.au> (raw)
In-Reply-To: <20100324002117.GN30031@ZenIV.linux.org.uk>
Hi.
On 24/03/10 11:21, Al Viro wrote:
> On Wed, Mar 24, 2010 at 10:55:45AM +1100, Nigel Cunningham wrote:
>> Hi again.
>>
>> On 24/03/10 10:52, Nigel Cunningham wrote:
>>>> I've stayed away from TuxOnIce flamefests and I've no idea how
>>>> representative
>>>> that snippet is, but if it *does* match the general code quality in
>>>> there...
>>>> Ouch.
>>>
>>> Locking isn't necessary because of the freezing.
>>
>> Err, freezer, I mean.
>
> Even leaving aside the accuracy of that (and I seriously doubt it), this
> is completely wrong since *code* *gets* *copied*.
Ok. That's a fair enough point. I'll add locking.
Regards,
Nigel
next prev parent reply other threads:[~2010-03-24 0:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 14:22 [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl Josef Bacik
2010-03-23 14:28 ` Al Viro
2010-03-23 14:34 ` Josef Bacik
2010-03-23 14:48 ` Al Viro
2010-03-23 15:03 ` Josef Bacik
2010-03-23 15:09 ` Al Viro
2010-03-23 15:12 ` Al Viro
2010-03-23 15:15 ` Al Viro
2010-03-23 22:31 ` Nigel Cunningham
2010-03-23 23:18 ` Al Viro
2010-03-23 23:47 ` Al Viro
2010-03-23 23:52 ` Nigel Cunningham
2010-03-23 23:55 ` Nigel Cunningham
2010-03-24 0:21 ` Al Viro
2010-03-24 0:25 ` Nigel Cunningham [this message]
2010-03-24 0:03 ` Nigel Cunningham
2010-03-23 18:19 ` Sunil Mushran
2010-03-23 22:25 ` Nigel Cunningham
2010-03-24 1:17 ` Josef Bacik
2010-03-24 5:16 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA95BEB.7040805@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.