From: Nigel Cunningham <ncunningham@crca.org.au>
To: Josef Bacik <josef@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chris.mason@oracle.com, viro@ZenIV.linux.org.uk, hch@lst.de
Subject: Re: [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl
Date: Wed, 24 Mar 2010 16:16:56 +1100 [thread overview]
Message-ID: <4BA9A048.6050705@crca.org.au> (raw)
In-Reply-To: <20100324011714.GA5658@localhost.localdomain>
Hi.
On 24/03/10 12:17, Josef Bacik wrote:
> On Wed, Mar 24, 2010 at 09:25:39AM +1100, Nigel Cunningham wrote:
>> Hi.
>>
>> A cc would have been nice :)
>>
>> Thankfully the subject caught my eye.
>>
>
> Well it's not really tux-on-ice's fault, freeze wouldn't work _at all_ via the
> ioctl or any other method, we just happened to notice it was broken because
> people using tux-on-ice were getting corrupt filesystems after suspend :). Btw,
> it may be good to have freezer_sync set to 1 by default, otherwise if an fs
> doesnt support freezing it will likely end up corrupted too. Thanks,
Corrupted because the sys_sync was disabled? (We were recently
discussing adding a tuneable to swsusp for disabling sys_sync there too).
I've just committed a patch making freezer_sync default to 1.
Regards,
Nigel
prev parent reply other threads:[~2010-03-24 5:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 14:22 [PATCH] Introduce freeze_super and thaw_super for the fsfreeze ioctl Josef Bacik
2010-03-23 14:28 ` Al Viro
2010-03-23 14:34 ` Josef Bacik
2010-03-23 14:48 ` Al Viro
2010-03-23 15:03 ` Josef Bacik
2010-03-23 15:09 ` Al Viro
2010-03-23 15:12 ` Al Viro
2010-03-23 15:15 ` Al Viro
2010-03-23 22:31 ` Nigel Cunningham
2010-03-23 23:18 ` Al Viro
2010-03-23 23:47 ` Al Viro
2010-03-23 23:52 ` Nigel Cunningham
2010-03-23 23:55 ` Nigel Cunningham
2010-03-24 0:21 ` Al Viro
2010-03-24 0:25 ` Nigel Cunningham
2010-03-24 0:03 ` Nigel Cunningham
2010-03-23 18:19 ` Sunil Mushran
2010-03-23 22:25 ` Nigel Cunningham
2010-03-24 1:17 ` Josef Bacik
2010-03-24 5:16 ` Nigel Cunningham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA9A048.6050705@crca.org.au \
--to=ncunningham@crca.org.au \
--cc=chris.mason@oracle.com \
--cc=hch@lst.de \
--cc=josef@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.