Re: [Autotest] [PATCH 4/4] KVM test: Enable timedrift for Linux guests

Re: [Autotest] [PATCH 4/4] KVM test: Enable timedrift for Linux guests

[Michael Goldish]

----- "Jason Wang" <jasowang@redhat.com> wrote:

> We should also test timedrift for Linux guests especially for guest
> with pvclock. So this patch enable the timedrift for linux guests.
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  client/tests/kvm/tests_base.cfg.sample |   11 ++++++++++-
>  1 files changed, 10 insertions(+), 1 deletions(-)
> 
> diff --git a/client/tests/kvm/tests_base.cfg.sample
> b/client/tests/kvm/tests_base.cfg.sample
> index 8cc83a9..dcd0dcf 100644
> --- a/client/tests/kvm/tests_base.cfg.sample
> +++ b/client/tests/kvm/tests_base.cfg.sample
> @@ -330,7 +330,7 @@ variants:
>  variants:
>      # Linux section
>      - @Linux:
> -        no timedrift autoit
> +        no autoit
>          shutdown_command = shutdown -h now
>          reboot_command = shutdown -r now
>          status_test_command = echo $?
> @@ -342,6 +342,15 @@ variants:
>          file_transfer_port = 22
>          mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print $2}'
>          cpu_chk_cmd = grep -c processor /proc/cpuinfo
> +        timedrift:
> +            time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N'
> +            time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)"
> +            time_format = "%m/%d/%Y %H:%M:%S"
> +            guest_load_command = "dd if=/dev/urandom of=/dev/null"
> +            guest_load_instances = 2
> +            guest_load_clean_cmd = "killall -9 dd"

I think this should be 'guest_load_stop_command'.
Other than that, looks good to me.

> +            host_load_command = "bzip2 -c --best /dev/urandom >
> /dev/null"
> +            host_load_instances = 8
>  
>          variants:
>              - Fedora:
> 
> _______________________________________________
> Autotest mailing list
> Autotest@test.kernel.org
> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest

Re: [PATCH 4/4] KVM test: Enable timedrift for Linux guests

[Jason Wang]

Michael Goldish wrote:
> ----- "Jason Wang" <jasowang@redhat.com> wrote:
>
>   
>> We should also test timedrift for Linux guests especially for guest
>> with pvclock. So this patch enable the timedrift for linux guests.
>>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>>  client/tests/kvm/tests_base.cfg.sample |   11 ++++++++++-
>>  1 files changed, 10 insertions(+), 1 deletions(-)
>>
>> diff --git a/client/tests/kvm/tests_base.cfg.sample
>> b/client/tests/kvm/tests_base.cfg.sample
>> index 8cc83a9..dcd0dcf 100644
>> --- a/client/tests/kvm/tests_base.cfg.sample
>> +++ b/client/tests/kvm/tests_base.cfg.sample
>> @@ -330,7 +330,7 @@ variants:
>>  variants:
>>      # Linux section
>>      - @Linux:
>> -        no timedrift autoit
>> +        no autoit
>>          shutdown_command = shutdown -h now
>>          reboot_command = shutdown -r now
>>          status_test_command = echo $?
>> @@ -342,6 +342,15 @@ variants:
>>          file_transfer_port = 22
>>          mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print $2}'
>>          cpu_chk_cmd = grep -c processor /proc/cpuinfo
>> +        timedrift:
>> +            time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N'
>> +            time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)"
>> +            time_format = "%m/%d/%Y %H:%M:%S"
>> +            guest_load_command = "dd if=/dev/urandom of=/dev/null"
>> +            guest_load_instances = 2
>> +            guest_load_clean_cmd = "killall -9 dd"
>>     
>
> I think this should be 'guest_load_stop_command'.
> Other than that, looks good to me.
>
>   
Thanks for pointing this, would resend this patch.
>> +            host_load_command = "bzip2 -c --best /dev/urandom >
>> /dev/null"
>> +            host_load_instances = 8
>>  
>>          variants:
>>              - Fedora:
>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>     
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

[PATCH 1/4] KVM test: Add monotonic_time into the guest test

[Jason Wang]

Monotonic_time is used to test gettimeofday(), TSC and
clock_gettime(CLOCK_MONOTONIC) which is useful to test the virutal
timer device.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 .../kvm/autotest_control/monotonic_time.control    |   37 ++++++++++++++++++++
 client/tests/kvm/tests_base.cfg.sample             |    3 ++
 2 files changed, 40 insertions(+), 0 deletions(-)
 create mode 100644 client/tests/kvm/autotest_control/monotonic_time.control

diff --git a/client/tests/kvm/autotest_control/monotonic_time.control b/client/tests/kvm/autotest_control/monotonic_time.control
new file mode 100644
index 0000000..4dbfec4
--- /dev/null
+++ b/client/tests/kvm/autotest_control/monotonic_time.control
@@ -0,0 +1,37 @@
+NAME = 'monotonic_time'
+AUTHOR = 'Michael Davidson <md@google.com>'
+TIME = 'MEDIUM'
+TEST_CLASS = 'Kernel'
+TEST_CATEGORY = 'Functional'
+TEST_TYPE = 'client'
+DOC = """
+monotonic_time checks various time interfaces:
+  gettimeofday()
+  clock_gettime(CLOCK_MONTONIC)
+  TSC
+for monotonicity.
+
+Based on time-warp-test.c by Ingo Molnar.
+"""
+
+#
+# Test gettimeofday(), TSC, and clock_gettime(CLOCK_MONOTONIC)
+#
+# Tests run for 'duration' seconds and check that the selected
+# time interface does not go backwards by more than 'threshold'.
+#
+# Note that the threshold value has the same resolution as the
+# clock source:
+#   gettimeofday()                 - microseconds
+#   clock_gettime(CLOCK_MONOTONIC) - nanoseconds
+#   TSC                            - CPU clock cycles
+#
+#
+job.run_test('monotonic_time', tag='gtod',  test_type='gtod',
+             duration=300, threshold=0)
+
+job.run_test('monotonic_time', tag='clock', test_type='clock',
+             duration=300, threshold=0)
+
+job.run_test('monotonic_time', tag='tsc',   test_type='tsc',
+             duration=300, threshold=0)
diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 9963a44..2af6a05 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -133,6 +133,9 @@ variants:
             - cpu_hotplug:
                 test_name = cpu_hotplug
                 test_control_file = cpu_hotplug.control
+            - monotonic_time:
+                test_name = monotonic_time
+                test_control_file = monotonic_time.control
 
     - linux_s3:     install setup unattended_install
         type = linux_s3

[PATCH 4/4] KVM test: Enable timedrift for Linux guests

[Jason Wang]

We should also test timedrift for Linux guests especially for guest
with pvclock. So this patch enable the timedrift for linux guests.

Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 client/tests/kvm/tests_base.cfg.sample |   11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diff --git a/client/tests/kvm/tests_base.cfg.sample b/client/tests/kvm/tests_base.cfg.sample
index 8cc83a9..dcd0dcf 100644
--- a/client/tests/kvm/tests_base.cfg.sample
+++ b/client/tests/kvm/tests_base.cfg.sample
@@ -330,7 +330,7 @@ variants:
 variants:
     # Linux section
     - @Linux:
-        no timedrift autoit
+        no autoit
         shutdown_command = shutdown -h now
         reboot_command = shutdown -r now
         status_test_command = echo $?
@@ -342,6 +342,15 @@ variants:
         file_transfer_port = 22
         mem_chk_cmd = dmidecode -t 17 | awk -F: '/Size/ {print $2}'
         cpu_chk_cmd = grep -c processor /proc/cpuinfo
+        timedrift:
+            time_command = date +'TIME: %a %m/%d/%Y %H:%M:%S.%N'
+            time_filter_re = "(?:TIME: \w\w\w )(.{19})(?:\.\d\d)"
+            time_format = "%m/%d/%Y %H:%M:%S"
+            guest_load_command = "dd if=/dev/urandom of=/dev/null"
+            guest_load_instances = 2
+            guest_load_clean_cmd = "killall -9 dd"
+            host_load_command = "bzip2 -c --best /dev/urandom > /dev/null"
+            host_load_instances = 8
 
         variants:
             - Fedora: