[PATCH] ARM: Add support for LZMA-compressed kernel images

[PATCH] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

This patch allows using a kernel image compressed with LZMA on ARM,
using the support for multiple decompressors introduced in the LZO
support patch.
Extracting the image is fairly slow, but it might be useful on machines
with a very limited amount of storage.

Signed-off-by: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Tested-by: Martin Michlmayr <tbm@cyrius.com>
---
 arch/arm/Kconfig                      |    1 +
 arch/arm/boot/compressed/Makefile     |    1 +
 arch/arm/boot/compressed/misc.c       |    4 ++++
 arch/arm/boot/compressed/piggy.lzma.S |    6 ++++++
 4 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/compressed/piggy.lzma.S

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 350921d..34163da 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -20,6 +20,7 @@ config ARM
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_KERNEL_GZIP
 	select HAVE_KERNEL_LZO
+	select HAVE_KERNEL_LZMA
 	help
 	  The ARM series is a line of low-power-consumption RISC chip designs
 	  licensed by ARM Ltd and targeted at embedded applications and
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 2d4d88b..3906432 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -65,6 +65,7 @@ SEDFLAGS	= s/TEXT_START/$(ZTEXTADDR)/;s/BSS_START/$(ZBSSADDR)/
 
 suffix_$(CONFIG_KERNEL_GZIP) = gzip
 suffix_$(CONFIG_KERNEL_LZO)  = lzo
+suffix_$(CONFIG_KERNEL_LZMA)  = lzma
 
 targets       := vmlinux vmlinux.lds \
 		 piggy.$(suffix_y) piggy.$(suffix_y).o \
diff --git a/arch/arm/boot/compressed/misc.c b/arch/arm/boot/compressed/misc.c
index 7e0fe4d..4e35a10 100644
--- a/arch/arm/boot/compressed/misc.c
+++ b/arch/arm/boot/compressed/misc.c
@@ -237,6 +237,10 @@ static unsigned long free_mem_end_ptr;
 #include "../../../../lib/decompress_inflate.c"
 #endif
 
+#ifdef CONFIG_KERNEL_LZMA
+#include "../../../../lib/decompress_unlzma.c"
+#endif
+
 #ifdef CONFIG_KERNEL_LZO
 #include "../../../../lib/decompress_unlzo.c"
 #endif
diff --git a/arch/arm/boot/compressed/piggy.lzma.S b/arch/arm/boot/compressed/piggy.lzma.S
new file mode 100644
index 0000000..d7e69cf
--- /dev/null
+++ b/arch/arm/boot/compressed/piggy.lzma.S
@@ -0,0 +1,6 @@
+	.section .piggydata,#alloc
+	.globl	input_data
+input_data:
+	.incbin	"arch/arm/boot/compressed/piggy.lzma"
+	.globl	input_data_end
+input_data_end:
-- 
1.6.3.3

Re: [PATCH] ARM: Add support for LZMA-compressed kernel images

[Russell King]

On Fri, Nov 20, 2009 at 04:02:03PM +0100, Albin Tonnerre wrote:
> This patch allows using a kernel image compressed with LZMA on ARM,
> using the support for multiple decompressors introduced in the LZO
> support patch.
> Extracting the image is fairly slow, but it might be useful on machines
> with a very limited amount of storage.

I didn't see a response to my previous message about the LZO patch set.
Do you want me to queue up the patch set for the next merge window?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Re: [PATCH] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

On Fri, 20 Nov 2009 15:16 +0000, Russell King wrote :
> On Fri, Nov 20, 2009 at 04:02:03PM +0100, Albin Tonnerre wrote:
> > This patch allows using a kernel image compressed with LZMA on ARM,
> > using the support for multiple decompressors introduced in the LZO
> > support patch.
> > Extracting the image is fairly slow, but it might be useful on machines
> > with a very limited amount of storage.
> 
> I didn't see a response to my previous message about the LZO patch set.
> Do you want me to queue up the patch set for the next merge window?

Oh, sorry, I must have missed it. I would indeed appreciate this, thank you very
much.

Regards,
-- 
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

Re: [PATCH] ARM: Add support for LZMA-compressed kernel images

[Russell King]

On Fri, Nov 20, 2009 at 04:23:24PM +0100, Albin Tonnerre wrote:
> On Fri, 20 Nov 2009 15:16 +0000, Russell King wrote :
> > On Fri, Nov 20, 2009 at 04:02:03PM +0100, Albin Tonnerre wrote:
> > > This patch allows using a kernel image compressed with LZMA on ARM,
> > > using the support for multiple decompressors introduced in the LZO
> > > support patch.
> > > Extracting the image is fairly slow, but it might be useful on machines
> > > with a very limited amount of storage.
> > 
> > I didn't see a response to my previous message about the LZO patch set.
> > Do you want me to queue up the patch set for the next merge window?
> 
> Oh, sorry, I must have missed it. I would indeed appreciate this, thank
> you very much.

Okay, the next question which needs to be asked of the wider audience is:

Since some of the patch set is not specific to ARM, does anyone have any
objection to me pushing all four patches for the next merge window?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:

Re: [PATCH] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

On Fri, 20 Nov 2009 20:21 +0000, Russell King wrote :
> On Fri, Nov 20, 2009 at 04:23:24PM +0100, Albin Tonnerre wrote:
> > On Fri, 20 Nov 2009 15:16 +0000, Russell King wrote :
> > > On Fri, Nov 20, 2009 at 04:02:03PM +0100, Albin Tonnerre wrote:
> > > > This patch allows using a kernel image compressed with LZMA on ARM,
> > > > using the support for multiple decompressors introduced in the LZO
> > > > support patch.
> > > > Extracting the image is fairly slow, but it might be useful on machines
> > > > with a very limited amount of storage.
> > > 
> > > I didn't see a response to my previous message about the LZO patch set.
> > > Do you want me to queue up the patch set for the next merge window?
> > 
> > Oh, sorry, I must have missed it. I would indeed appreciate this, thank
> > you very much.
> 
> Okay, the next question which needs to be asked of the wider audience is:
> 
> Since some of the patch set is not specific to ARM, does anyone have any
> objection to me pushing all four patches for the next merge window?

As there are no objections, are you still willing to push this series for this
merge window?

Regards,
-- 
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

This patch allows using a kernel image compressed with LZMA on ARM.
Extracting the image is fairly slow, but it might be useful on machines
with a very limited amount of storage, as the size benefit is quite
significant:
Gzip: Data Size:    1586352 Bytes = 1549.17 kB = 1.51 MB
LZMA: Data Size:    2135916 Bytes = 2085.86 kB = 2.04 MB

Signed-off-by: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Tested-by: Martin Michlmayr <tbm@cyrius.com>
---
v2: Updated to apply on top of 2.6.34-rc1

 arch/arm/Kconfig                      |    1 +
 arch/arm/boot/compressed/Makefile     |    1 +
 arch/arm/boot/compressed/decompress.c |    4 ++++
 arch/arm/boot/compressed/piggy.lzma.S |    6 ++++++
 4 files changed, 12 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/compressed/piggy.lzma.S

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 3b18128..3ebc7c3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -21,6 +21,7 @@ config ARM
 	select HAVE_GENERIC_DMA_COHERENT
 	select HAVE_KERNEL_GZIP
 	select HAVE_KERNEL_LZO
+	select HAVE_KERNEL_LZMA
 	select HAVE_PERF_EVENTS
 	select PERF_USE_VMALLOC
 	help
diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
index 97c89e7..53faa90 100644
--- a/arch/arm/boot/compressed/Makefile
+++ b/arch/arm/boot/compressed/Makefile
@@ -65,6 +65,7 @@ SEDFLAGS	= s/TEXT_START/$(ZTEXTADDR)/;s/BSS_START/$(ZBSSADDR)/
 
 suffix_$(CONFIG_KERNEL_GZIP) = gzip
 suffix_$(CONFIG_KERNEL_LZO)  = lzo
+suffix_$(CONFIG_KERNEL_LZMA) = lzma
 
 targets       := vmlinux vmlinux.lds \
 		 piggy.$(suffix_y) piggy.$(suffix_y).o \
diff --git a/arch/arm/boot/compressed/decompress.c b/arch/arm/boot/compressed/decompress.c
index 0da382f..d554df6 100644
--- a/arch/arm/boot/compressed/decompress.c
+++ b/arch/arm/boot/compressed/decompress.c
@@ -39,6 +39,10 @@ extern void error(char *);
 #include "../../../../lib/decompress_unlzo.c"
 #endif
 
+#ifdef CONFIG_KERNEL_LZMA
+#include "../../../../lib/decompress_unlzma.c"
+#endif
+
 void do_decompress(u8 *input, int len, u8 *output, void (*error)(char *x))
 {
 	decompress(input, len, NULL, NULL, output, NULL, error);
diff --git a/arch/arm/boot/compressed/piggy.lzma.S b/arch/arm/boot/compressed/piggy.lzma.S
new file mode 100644
index 0000000..d7e69cf
--- /dev/null
+++ b/arch/arm/boot/compressed/piggy.lzma.S
@@ -0,0 +1,6 @@
+	.section .piggydata,#alloc
+	.globl	input_data
+input_data:
+	.incbin	"arch/arm/boot/compressed/piggy.lzma"
+	.globl	input_data_end
+input_data_end:
-- 
1.7.0

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

On Thu, 11 Mar 2010 20:24 +0100, Albin Tonnerre wrote :
> This patch allows using a kernel image compressed with LZMA on ARM.
> Extracting the image is fairly slow, but it might be useful on machines
> with a very limited amount of storage, as the size benefit is quite
> significant:
> Gzip: Data Size:    1586352 Bytes = 1549.17 kB = 1.51 MB
> LZMA: Data Size:    2135916 Bytes = 2085.86 kB = 2.04 MB

Meh. That should of course be:
LZMA ... 1.51MB
Gzip ... 2.04MB
-- 
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Paulius Zaleckas]

On 03/11/2010 09:24 PM, Albin Tonnerre wrote:
> This patch allows using a kernel image compressed with LZMA on ARM.
> Extracting the image is fairly slow, but it might be useful on machines
> with a very limited amount of storage, as the size benefit is quite
> significant:
> Gzip: Data Size:    1586352 Bytes = 1549.17 kB = 1.51 MB
> LZMA: Data Size:    2135916 Bytes = 2085.86 kB = 2.04 MB
>
> Signed-off-by: Albin Tonnerre<albin.tonnerre@free-electrons.com>
> Tested-by: Martin Michlmayr<tbm@cyrius.com>

You can add
Tested-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>

I think you should submit this patch to Russell's patch system.

> ---
> v2: Updated to apply on top of 2.6.34-rc1
>
>   arch/arm/Kconfig                      |    1 +
>   arch/arm/boot/compressed/Makefile     |    1 +
>   arch/arm/boot/compressed/decompress.c |    4 ++++
>   arch/arm/boot/compressed/piggy.lzma.S |    6 ++++++
>   4 files changed, 12 insertions(+), 0 deletions(-)
>   create mode 100644 arch/arm/boot/compressed/piggy.lzma.S
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 3b18128..3ebc7c3 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -21,6 +21,7 @@ config ARM
>   	select HAVE_GENERIC_DMA_COHERENT
>   	select HAVE_KERNEL_GZIP
>   	select HAVE_KERNEL_LZO
> +	select HAVE_KERNEL_LZMA
>   	select HAVE_PERF_EVENTS
>   	select PERF_USE_VMALLOC
>   	help
> diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile
> index 97c89e7..53faa90 100644
> --- a/arch/arm/boot/compressed/Makefile
> +++ b/arch/arm/boot/compressed/Makefile
> @@ -65,6 +65,7 @@ SEDFLAGS	= s/TEXT_START/$(ZTEXTADDR)/;s/BSS_START/$(ZBSSADDR)/
>
>   suffix_$(CONFIG_KERNEL_GZIP) = gzip
>   suffix_$(CONFIG_KERNEL_LZO)  = lzo
> +suffix_$(CONFIG_KERNEL_LZMA) = lzma
>
>   targets       := vmlinux vmlinux.lds \
>   		 piggy.$(suffix_y) piggy.$(suffix_y).o \
> diff --git a/arch/arm/boot/compressed/decompress.c b/arch/arm/boot/compressed/decompress.c
> index 0da382f..d554df6 100644
> --- a/arch/arm/boot/compressed/decompress.c
> +++ b/arch/arm/boot/compressed/decompress.c
> @@ -39,6 +39,10 @@ extern void error(char *);
>   #include "../../../../lib/decompress_unlzo.c"
>   #endif
>
> +#ifdef CONFIG_KERNEL_LZMA
> +#include "../../../../lib/decompress_unlzma.c"
> +#endif
> +
>   void do_decompress(u8 *input, int len, u8 *output, void (*error)(char *x))
>   {
>   	decompress(input, len, NULL, NULL, output, NULL, error);
> diff --git a/arch/arm/boot/compressed/piggy.lzma.S b/arch/arm/boot/compressed/piggy.lzma.S
> new file mode 100644
> index 0000000..d7e69cf
> --- /dev/null
> +++ b/arch/arm/boot/compressed/piggy.lzma.S
> @@ -0,0 +1,6 @@
> +	.section .piggydata,#alloc
> +	.globl	input_data
> +input_data:
> +	.incbin	"arch/arm/boot/compressed/piggy.lzma"
> +	.globl	input_data_end
> +input_data_end:

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Andrea Adami]

On Thu, Mar 25, 2010 at 10:56 AM, Paulius Zaleckas
<paulius.zaleckas@gmail.com> wrote:
> On 03/11/2010 09:24 PM, Albin Tonnerre wrote:
>>
>> This patch allows using a kernel image compressed with LZMA on ARM.
>> Extracting the image is fairly slow, but it might be useful on machines
>> with a very limited amount of storage, as the size benefit is quite
>> significant:
>> Gzip: Data Size: ? ?1586352 Bytes = 1549.17 kB = 1.51 MB
>> LZMA: Data Size: ? ?2135916 Bytes = 2085.86 kB = 2.04 MB
>>
>> Signed-off-by: Albin Tonnerre<albin.tonnerre@free-electrons.com>
>> Tested-by: Martin Michlmayr<tbm@cyrius.com>
>
> You can add
> Tested-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>
>
> I think you should submit this patch to Russell's patch system.
>
>> ---
>> v2: Updated to apply on top of 2.6.34-rc1
>>
>> ?arch/arm/Kconfig ? ? ? ? ? ? ? ? ? ? ?| ? ?1 +
>> ?arch/arm/boot/compressed/Makefile ? ? | ? ?1 +
>> ?arch/arm/boot/compressed/decompress.c | ? ?4 ++++
>> ?arch/arm/boot/compressed/piggy.lzma.S | ? ?6 ++++++
>> ?4 files changed, 12 insertions(+), 0 deletions(-)
>> ?create mode 100644 arch/arm/boot/compressed/piggy.lzma.S
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 3b18128..3ebc7c3 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -21,6 +21,7 @@ config ARM
>> ? ? ? ?select HAVE_GENERIC_DMA_COHERENT
>> ? ? ? ?select HAVE_KERNEL_GZIP
>> ? ? ? ?select HAVE_KERNEL_LZO
>> + ? ? ? select HAVE_KERNEL_LZMA
>> ? ? ? ?select HAVE_PERF_EVENTS
>> ? ? ? ?select PERF_USE_VMALLOC
>> ? ? ? ?help
>> diff --git a/arch/arm/boot/compressed/Makefile
>> b/arch/arm/boot/compressed/Makefile
>> index 97c89e7..53faa90 100644
>> --- a/arch/arm/boot/compressed/Makefile
>> +++ b/arch/arm/boot/compressed/Makefile
>> @@ -65,6 +65,7 @@ SEDFLAGS ? ? ?=
>> s/TEXT_START/$(ZTEXTADDR)/;s/BSS_START/$(ZBSSADDR)/
>>
>> ?suffix_$(CONFIG_KERNEL_GZIP) = gzip
>> ?suffix_$(CONFIG_KERNEL_LZO) ?= lzo
>> +suffix_$(CONFIG_KERNEL_LZMA) = lzma
>>
>> ?targets ? ? ? := vmlinux vmlinux.lds \
>> ? ? ? ? ? ? ? ? piggy.$(suffix_y) piggy.$(suffix_y).o \
>> diff --git a/arch/arm/boot/compressed/decompress.c
>> b/arch/arm/boot/compressed/decompress.c
>> index 0da382f..d554df6 100644
>> --- a/arch/arm/boot/compressed/decompress.c
>> +++ b/arch/arm/boot/compressed/decompress.c
>> @@ -39,6 +39,10 @@ extern void error(char *);
>> ?#include "../../../../lib/decompress_unlzo.c"
>> ?#endif
>>
>> +#ifdef CONFIG_KERNEL_LZMA
>> +#include "../../../../lib/decompress_unlzma.c"
>> +#endif
>> +
>> ?void do_decompress(u8 *input, int len, u8 *output, void (*error)(char
>> *x))
>> ?{
>> ? ? ? ?decompress(input, len, NULL, NULL, output, NULL, error);
>> diff --git a/arch/arm/boot/compressed/piggy.lzma.S
>> b/arch/arm/boot/compressed/piggy.lzma.S
>> new file mode 100644
>> index 0000000..d7e69cf
>> --- /dev/null
>> +++ b/arch/arm/boot/compressed/piggy.lzma.S
>> @@ -0,0 +1,6 @@
>> + ? ? ? .section .piggydata,#alloc
>> + ? ? ? .globl ?input_data
>> +input_data:
>> + ? ? ? .incbin "arch/arm/boot/compressed/piggy.lzma"
>> + ? ? ? .globl ?input_data_end
>> +input_data_end:
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

Any reason to further delay the LZMA adoption?
It will not be the fastest decompressor, but gives the smallest kernel size.
Tested on various Zaurus models (pxa255, pxa270, armv4).

Regards

Andrea Adami

P.S. Fixes to .gitignore would need to be added for lzma.

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Albin Tonnerre]

On Thu, May 6, 2010 at 11:04 AM, Andrea Adami <andrea.adami@gmail.com> wrote:
> Any reason to further delay the LZMA adoption?
> It will not be the fastest decompressor, but gives the smallest kernel size.
> Tested on various Zaurus models (pxa255, pxa270, armv4).

It's in the devel branch of Russell's tree already, so it should find
its way to mainline :)

Regards,
Albin

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Eric Miao]

On Thu, May 6, 2010 at 9:30 PM, Albin Tonnerre <albin.tonnerre@gmail.com> wrote:
> On Thu, May 6, 2010 at 11:04 AM, Andrea Adami <andrea.adami@gmail.com> wrote:
>> Any reason to further delay the LZMA adoption?
>> It will not be the fastest decompressor, but gives the smallest kernel size.
>> Tested on various Zaurus models (pxa255, pxa270, armv4).
>
> It's in the devel branch of Russell's tree already, so it should find
> its way to mainline :)
>

Tested on my zaurus, worked just out of the box. Thanks.

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Russell King - ARM Linux]

On Thu, May 06, 2010 at 11:04:31AM +0200, Andrea Adami wrote:
> Any reason to further delay the LZMA adoption?

Only due process; it'll be merged when the next merge window opens.

[PATCH v2] ARM: Add support for LZMA-compressed kernel images

[Gadiyar, Anand]

Eric Miao wrote:
> On Thu, May 6, 2010 at 9:30 PM, Albin Tonnerre <albin.tonnerre@gmail.com> wrote:
> > On Thu, May 6, 2010 at 11:04 AM, Andrea Adami <andrea.adami@gmail.com> wrote:
> >> Any reason to further delay the LZMA adoption?
> >> It will not be the fastest decompressor, but gives the smallest kernel size.
> >> Tested on various Zaurus models (pxa255, pxa270, armv4).
> >
> > It's in the devel branch of Russell's tree already, so it should find
> > its way to mainline :)
> >
> 
> Tested on my zaurus, worked just out of the box. Thanks.

And tested on a couple of OMAP3 boards too. Works great. Thanks!