From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
Date: Thu, 25 Mar 2010 13:19:29 +0300 [thread overview]
Message-ID: <4BAB38B1.8080404@ru.mvista.com> (raw)
In-Reply-To: <20100324230729.GA21359@n2100.arm.linux.org.uk>
Hello.
Russell King - ARM Linux wrote:
>> - debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n",
>> - (state->csc_mask==0)?"<NONE> ":"",
>> - (state->csc_mask&SS_DETECT)?"DETECT ":"",
>> - (state->csc_mask&SS_READY)?"READY ":"",
>> - (state->csc_mask&SS_BATDEAD)?"BATDEAD ":"",
>> - (state->csc_mask&SS_BATWARN)?"BATWARN ":"",
>> - (state->csc_mask&SS_STSCHG)?"STSCHG ":"",
>> - (state->flags==0)?"<NONE> ":"",
>> - (state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"",
>> - (state->flags&SS_IOCARD)?"IOCARD ":"",
>> - (state->flags&SS_RESET)?"RESET ":"",
>> - (state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"",
>> - (state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"",
>> + debug(skt, 2, "mask: %s%s%s%s%s%s "
>> + "flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n",
>>
>
> NAK. Breaking kernel messages across multiple lines makes them impossible
> to grep for. checkpatch.pl is wrong on this one.
>
I'd disagree in this case. Anybody will hardly grep for "mask:
%s%s%s%s%s%sflags: %s%s%s%s%s%s".
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Marcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>,
linux-arm-kernel@lists.infradead.org,
linux-pcmcia@lists.infradead.org,
Wolfram Sang <w.sang@pengutronix.de>,
Dominik Brodowski <linux@dominikbrodowski.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c
Date: Thu, 25 Mar 2010 13:19:29 +0300 [thread overview]
Message-ID: <4BAB38B1.8080404@ru.mvista.com> (raw)
In-Reply-To: <20100324230729.GA21359@n2100.arm.linux.org.uk>
Hello.
Russell King - ARM Linux wrote:
>> - debug(skt, 2, "mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n",
>> - (state->csc_mask==0)?"<NONE> ":"",
>> - (state->csc_mask&SS_DETECT)?"DETECT ":"",
>> - (state->csc_mask&SS_READY)?"READY ":"",
>> - (state->csc_mask&SS_BATDEAD)?"BATDEAD ":"",
>> - (state->csc_mask&SS_BATWARN)?"BATWARN ":"",
>> - (state->csc_mask&SS_STSCHG)?"STSCHG ":"",
>> - (state->flags==0)?"<NONE> ":"",
>> - (state->flags&SS_PWR_AUTO)?"PWR_AUTO ":"",
>> - (state->flags&SS_IOCARD)?"IOCARD ":"",
>> - (state->flags&SS_RESET)?"RESET ":"",
>> - (state->flags&SS_SPKR_ENA)?"SPKR_ENA ":"",
>> - (state->flags&SS_OUTPUT_ENA)?"OUTPUT_ENA ":"",
>> + debug(skt, 2, "mask: %s%s%s%s%s%s "
>> + "flags: %s%s%s%s%s%s Vcc %d Vpp %d irq %d\n",
>>
>
> NAK. Breaking kernel messages across multiple lines makes them impossible
> to grep for. checkpatch.pl is wrong on this one.
>
I'd disagree in this case. Anybody will hardly grep for "mask:
%s%s%s%s%s%sflags: %s%s%s%s%s%s".
WBR, Sergei
next prev parent reply other threads:[~2010-03-25 10:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 23:04 [PATCH 1/2] ARM: pcmcia: Fix for building DEBUG with sa11xx_base.c as a module Marcelo Roberto Jimenez
2010-03-24 23:04 ` Marcelo Roberto Jimenez
2010-03-24 23:04 ` [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c Marcelo Roberto Jimenez
2010-03-24 23:04 ` Marcelo Roberto Jimenez
2010-03-24 23:07 ` Russell King - ARM Linux
2010-03-24 23:07 ` Russell King - ARM Linux
2010-03-24 23:20 ` Marcelo Jimenez
2010-03-24 23:20 ` Marcelo Jimenez
2010-03-26 15:56 ` Valdis.Kletnieks at vt.edu
2010-03-26 15:56 ` Valdis.Kletnieks
2010-03-25 10:19 ` Sergei Shtylyov [this message]
2010-03-25 10:19 ` Sergei Shtylyov
2010-03-25 18:26 ` Valdis.Kletnieks at vt.edu
2010-03-25 18:26 ` Valdis.Kletnieks
2010-03-26 18:18 ` Russell King - ARM Linux
2010-03-26 18:18 ` Russell King - ARM Linux
2010-03-26 21:57 ` Marcelo Jimenez
2010-03-26 21:57 ` Marcelo Jimenez
2010-03-26 23:06 ` Russell King - ARM Linux
2010-03-26 23:06 ` Russell King - ARM Linux
2010-03-24 23:45 ` Marcelo Roberto Jimenez
2010-03-24 23:45 ` Marcelo Roberto Jimenez
2010-03-25 17:04 ` Dominik Brodowski
2010-03-25 17:04 ` Dominik Brodowski
2010-03-25 17:47 ` Marcelo Jimenez
2010-03-25 17:47 ` Marcelo Jimenez
2010-03-28 9:44 ` Russell King - ARM Linux
2010-03-28 9:44 ` Russell King - ARM Linux
2010-03-28 9:46 ` Dominik Brodowski
2010-03-28 9:46 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAB38B1.8080404@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.