Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()

From: Benny Halevy <bhalevy@panasas.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: pNFS Mailing List <pnfs@linux-nfs.org>,
	"J. Bruce Fields" <bfields@citi.umich.edu>,
	Trond Myklebust <Trond.Myklebust@netapp.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Doug Nazar <nazard.lkml@gmail.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()
Date: Thu, 25 Mar 2010 13:13:51 +0200	[thread overview]
Message-ID: <4BAB456F.7080501@panasas.com> (raw)
In-Reply-To: <4BAB4523.1010601@panasas.com>

On Mar. 25, 2010, 13:12 +0200, Benny Halevy <bhalevy@panasas.com> wrote:
> On Mar. 25, 2010, 13:00 +0200, Al Viro <viro@ZenIV.linux.org.uk> wrote:
>> On Thu, Mar 25, 2010 at 12:56:40PM +0200, Benny Halevy wrote:
>>> -		if (*want_dir && !path->dentry->d_inode->i_op->lookup)
>>> +		if (*want_dir && !path->dentry->d_inode->i_op->lookup) {
>>> +			WARN_ON(1);
>>>  			goto exit_dput;
>>> +		}
>>>  		path_to_nameidata(path, nd);
>>>  		audit_inode(pathname, nd->path.dentry);
>>>  		goto ok;
>>>
>>> but it is NOT tripping for this scenario.
>>>
>>> (for some reason I saw it tripping when building the kernel over nfs
>>> but it's benign)
>> It's ENOTDIR, not EISDIR, anyway.  Happens if you ask to open foo/ or
>> foo with O_DIRECTORY when foo is not a directory.
> 
> Hmm, not according to my strace (or am I blind today? :)

Duh, you were referring to the hunk I added a WARN_ON to.
Sure. you're right!

> 
>>> open(".git/objects/pack", O_RDONLY|O_NONBLOCK|O_DIRECTORY|0x80000) = -1 EISDIR (Is a directory)
> 
> The odd thing is the app incorrectly gets EISDIR despite
> the fact that it is opening a directory with O_DIRECTORY.
> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs