Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()

From: Benny Halevy <bhalevy@panasas.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"J. Bruce Fields" <bfields@citi.umich.edu>,
	pNFS Mailing List <pnfs@linux-nfs.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Doug Nazar <nazard.lkml@gmail.com>
Subject: Re: [pnfs] [GIT BISECT] first bad commit: 1f36f774 Switch !O_CREAT case to use of do_last()
Date: Thu, 25 Mar 2010 14:07:17 +0200	[thread overview]
Message-ID: <4BAB51F5.609@panasas.com> (raw)
In-Reply-To: <20100325105406.GW30031@ZenIV.linux.org.uk>

On Mar. 25, 2010, 12:54 +0200, Al Viro <viro@ZenIV.linux.org.uk> wrote:
> On Thu, Mar 25, 2010 at 10:12:31AM +0000, Al Viro wrote:
>> On Thu, Mar 25, 2010 at 11:39:38AM +0200, Boaz Harrosh wrote:
>>
>>> It makes no difference, fails just the same. Would an "strace" help?
>> It might, especially if you ran it for identical repositories on local
>> fs and on NFS; at least that way it would be possible to see where do
>> they diverge...
> 
> I wonder...  What happens if you add
> 	if (error == -EISDIR)
> 		printk("blah: %s", pathname);
> right after do_lookup() call in do_last()?  That would separate -EISDIR
> coming from NFS from the same thing coming from fs/namei.c...

Bingo.
It is returned from do_lookup.

@@ -1648,6 +1654,8 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
 	/* just plain open? */
 	if (!(open_flag & O_CREAT)) {
 		error = do_lookup(nd, &nd->last, path);
+		if (error == -EISDIR)
+			printk("%s: do_lookup returned -EISDIR %s\n", __func__, pathname);
 		if (error)
 			goto exit;
 		error = -ENOENT;


> _______________________________________________
> pNFS mailing list
> pNFS@linux-nfs.org
> http://linux-nfs.org/cgi-bin/mailman/listinfo/pnfs
