* [Patch 1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue
@ 2010-03-25 8:57 JosephChan
2010-03-25 12:02 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: JosephChan @ 2010-03-25 8:57 UTC (permalink / raw)
To: linux-ide, stable; +Cc: jeff, tj
When using VT6410/6415/6330 chips on some VIA's platforms, the HDD connects to VT6410/6415/6330 cannot be detected.
It is because the driver detects wrong via_isa_bridge ID, and then cause the this issue happen.
This patch will fix this problem.
Signed-off-by: Joseph Chan<josephchan@via.com.tw>
--- a/drivers/ata/pata_via.c 2010-03-16 06:00:01.000000000 -0400
+++ b/drivers/ata/pata_via.c 2010-03-19 10:21:59.000000000 -0400
@@ -576,6 +576,10 @@
u8 rev = isa->revision;
pci_dev_put(isa);
+ if ( (id->device == 0x0415 || id->device == 0x3164) &&
+ (config->id != id->device ))
+ continue;
+
if (rev >= config->rev_min && rev <= config->rev_max)
break;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch 1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue
2010-03-25 8:57 [Patch 1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue JosephChan
@ 2010-03-25 12:02 ` Sergei Shtylyov
2010-03-25 12:41 ` JosephChan
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2010-03-25 12:02 UTC (permalink / raw)
To: JosephChan; +Cc: linux-ide, stable, jeff, tj
Hello.
JosephChan@via.com.tw wrote:
> When using VT6410/6415/6330 chips on some VIA's platforms, the HDD connects to VT6410/6415/6330 cannot be detected.
> It is because the driver detects wrong via_isa_bridge ID, and then cause the this issue happen.
> This patch will fix this problem.
>
>
> Signed-off-by: Joseph Chan<josephchan@via.com.tw>
>
> --- a/drivers/ata/pata_via.c 2010-03-16 06:00:01.000000000 -0400
> +++ b/drivers/ata/pata_via.c 2010-03-19 10:21:59.000000000 -0400
> @@ -576,6 +576,10 @@
> u8 rev = isa->revision;
> pci_dev_put(isa);
>
> + if ( (id->device == 0x0415 || id->device == 0x3164) &&
> + (config->id != id->device ))
>
Don't put spaces before parens.
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Patch 1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue
2010-03-25 12:02 ` Sergei Shtylyov
@ 2010-03-25 12:41 ` JosephChan
0 siblings, 0 replies; 3+ messages in thread
From: JosephChan @ 2010-03-25 12:41 UTC (permalink / raw)
To: sshtylyov; +Cc: linux-ide, stable, jeff, tj
>> Don't put spaces before parens.
Sergei,
Thanks for reminding, I forgot to check it.
I will re-submit the patch later.
BRs,
Joseph Chan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-25 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-25 8:57 [Patch 1/1] pata_via: HDD of VT6410/6415/6330 cannot be detected issue JosephChan
2010-03-25 12:02 ` Sergei Shtylyov
2010-03-25 12:41 ` JosephChan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.