[Ocfs2-devel] [PATCH] ocfs2: remove a useless statement

[Ocfs2-devel] [PATCH] ocfs2: remove a useless statement

[Wengang Wang]

When we are downconvert a lock to NL from PR, we don't need access lvb. So we
clear LKM_VALBLK from _flags_ in __dlmconvert_master(). While we don't check
LKM_VALBLK on _flags_ any more and _flags_ is never passed to any other
function. Thus the clearing statement is useless though harmless. For making
code clean, I made this patch to remove the useless statement.

Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
---
 fs/ocfs2/dlm/dlmconvert.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/ocfs2/dlm/dlmconvert.c b/fs/ocfs2/dlm/dlmconvert.c
index f283bce..44b40a8 100644
--- a/fs/ocfs2/dlm/dlmconvert.c
+++ b/fs/ocfs2/dlm/dlmconvert.c
@@ -173,7 +173,6 @@ static enum dlm_status __dlmconvert_master(struct dlm_ctxt *dlm,
 					     "into lvb: converting %s->%s\n",
 					     dlm_lock_mode_name(lock->ml.type),
 					     dlm_lock_mode_name(type));
-					flags &= ~(LKM_VALBLK);
 				}
 				break;
 		}
-- 
1.6.6.1

[Ocfs2-devel] [PATCH] ocfs2: remove a useless statement

[Sunil Mushran]

nak

I would rather leave it there. We have that if block just for it.
There must have been a reason for it being there.

Wengang Wang wrote:
> When we are downconvert a lock to NL from PR, we don't need access lvb. So we
> clear LKM_VALBLK from _flags_ in __dlmconvert_master(). While we don't check
> LKM_VALBLK on _flags_ any more and _flags_ is never passed to any other
> function. Thus the clearing statement is useless though harmless. For making
> code clean, I made this patch to remove the useless statement.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
>  fs/ocfs2/dlm/dlmconvert.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/fs/ocfs2/dlm/dlmconvert.c b/fs/ocfs2/dlm/dlmconvert.c
> index f283bce..44b40a8 100644
> --- a/fs/ocfs2/dlm/dlmconvert.c
> +++ b/fs/ocfs2/dlm/dlmconvert.c
> @@ -173,7 +173,6 @@ static enum dlm_status __dlmconvert_master(struct dlm_ctxt *dlm,
>  					     "into lvb: converting %s->%s\n",
>  					     dlm_lock_mode_name(lock->ml.type),
>  					     dlm_lock_mode_name(type));
> -					flags &= ~(LKM_VALBLK);
>  				}
>  				break;
>  		}
>   

[Ocfs2-devel] [PATCH] ocfs2: remove a useless statement

[Wengang Wang]

On 10-03-25 15:33, Sunil Mushran wrote:
> nak
> 
> I would rather leave it there. We have that if block just for it.
> There must have been a reason for it being there.

Ok, thanks for review.

regards,
wengang.
> 
> Wengang Wang wrote:
> >When we are downconvert a lock to NL from PR, we don't need access lvb. So we
> >clear LKM_VALBLK from _flags_ in __dlmconvert_master(). While we don't check
> >LKM_VALBLK on _flags_ any more and _flags_ is never passed to any other
> >function. Thus the clearing statement is useless though harmless. For making
> >code clean, I made this patch to remove the useless statement.
> >
> >Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> >---
> > fs/ocfs2/dlm/dlmconvert.c |    1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> >diff --git a/fs/ocfs2/dlm/dlmconvert.c b/fs/ocfs2/dlm/dlmconvert.c
> >index f283bce..44b40a8 100644
> >--- a/fs/ocfs2/dlm/dlmconvert.c
> >+++ b/fs/ocfs2/dlm/dlmconvert.c
> >@@ -173,7 +173,6 @@ static enum dlm_status __dlmconvert_master(struct dlm_ctxt *dlm,
> > 					     "into lvb: converting %s->%s\n",
> > 					     dlm_lock_mode_name(lock->ml.type),
> > 					     dlm_lock_mode_name(type));
> >-					flags &= ~(LKM_VALBLK);
> > 				}
> > 				break;
> > 		}
>