From: Daniele Nicolodi <daniele@domain.hid>
To: xenomai-core <xenomai@xenomai.org>,
Alexis Berlemont <berlemont.hauw@domain.hid>
Subject: [Xenomai-core] Bug in a4l_get_chan
Date: Fri, 26 Mar 2010 15:08:28 +0100 [thread overview]
Message-ID: <4BACBFDC.4080909@domain.hid> (raw)
Hello Alexis,
I found that a4l_get_chan() in buffer.c does not work for subdevices
that use a global channels description struct (mode =
A4L_CHAN_GLOBAL_CHANDESC in the a4l_chdesc_t structure).
The problem is that a4l_get_chan() iterates (twice) on the chan_desc
array looking for channel descriptions at indexes higher than 0, also in
the case where those are not populated because the subdevice uses a
single channel description structure for all channels.
This bug is quite bas, as it triggers a kernel oops for a integer
division by zero when an a4l_cmd_t command is issued with a channels
description array that does not have the channel id 0 as first acquired
channel. You can easily reproduce the bug using the ni_pcimio driver,
using cmd_read with the parameter -c 1.
I'm looking into providing a patch, but I have some difficulties in
understanding the rational of this part of analogy code...
Cheers,
--
Daniele
next reply other threads:[~2010-03-26 14:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 14:08 Daniele Nicolodi [this message]
2010-03-28 23:35 ` [Xenomai-core] Bug in a4l_get_chan Alexis Berlemont
2010-03-29 16:48 ` Daniele Nicolodi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BACBFDC.4080909@domain.hid \
--to=daniele@domain.hid \
--cc=berlemont.hauw@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.