From: Daniele Nicolodi <daniele@domain.hid>
To: Alexis Berlemont <alexis.berlemont@domain.hid>
Cc: Alexis Berlemont <berlemont.hauw@domain.hid>,
xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] Bug in a4l_get_chan
Date: Mon, 29 Mar 2010 18:48:25 +0200 [thread overview]
Message-ID: <4BB0D9D9.1050904@domain.hid> (raw)
In-Reply-To: <20100328233556.GC2542@domain.hid>
Alexis Berlemont wrote:
> Daniele Nicolodi wrote:
>> Hello Alexis,
>>
>> I found that a4l_get_chan() in buffer.c does not work for subdevices
>> that use a global channels description struct (mode =
>> A4L_CHAN_GLOBAL_CHANDESC in the a4l_chdesc_t structure).
> However, with your accurate description, I think this patch should
> solve the problem:
Thanks Alexis. Your patch has the same effect as the one I cracked up
myself after some head scratching. It is more readable than mine,
however my solution avoids the iteration and the multiple checks for
A4L_CHAN_GLOBAL_CHANDESC and can be a little more efficient, but i think
compiler optimizations should make it a non noticeable difference.
Cheers,
PS: Looks like free.fr does not like my university SMTP server. I have
difficulties in sending mails to your account there.
--
Daniele
prev parent reply other threads:[~2010-03-29 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 14:08 [Xenomai-core] Bug in a4l_get_chan Daniele Nicolodi
2010-03-28 23:35 ` Alexis Berlemont
2010-03-29 16:48 ` Daniele Nicolodi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB0D9D9.1050904@domain.hid \
--to=daniele@domain.hid \
--cc=alexis.berlemont@domain.hid \
--cc=berlemont.hauw@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.