[PATCH] A testcase for blank lines in grub script (debian bug #572302)

[PATCH] A testcase for blank lines in grub script (debian bug #572302)

[BVK Chaitanya]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

Hi,


Attached is a test case for the bug #572302, blank lines being not
accepted by grub-script.   It is also pushed into
branches/blanklines-test branch.


-- 
bvk.chaitanya

[-- Attachment #2: blanklines-test.patch.txt --]
[-- Type: text/plain, Size: 3060 bytes --]

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: bvk.groups@gmail.com-20100322082445-ooa2pzr7q32ed30b
# target_branch: file:///home/bvk/Work/grub2/mainline/
# testament_sha1: 92341f9daabb8d9055832f64822b614435c29f48
# timestamp: 2010-03-22 17:40:11 +0530
# base_revision_id: bvk.groups@gmail.com-20100314170717-\
#   q8ppihzgyjyifcke
# 
# Begin patch
=== modified file 'conf/tests.rmk'
--- conf/tests.rmk	2010-01-22 13:37:27 +0000
+++ conf/tests.rmk	2010-03-22 08:24:45 +0000
@@ -50,6 +50,9 @@
 check_SCRIPTS += grub_script_vars1
 grub_script_vars1_SOURCES = tests/grub_script_vars1.in
 
+check_SCRIPTS += grub_script_blanklines
+grub_script_blanklines_SOURCES = tests/grub_script_blanklines.in
+
 # List of tests to execute on "make check"
 # SCRIPTED_TESTS    = example_scripted_test
 # SCRIPTED_TESTS   += example_grub_script_test
@@ -59,6 +62,7 @@
 SCRIPTED_TESTS  = grub_script_echo1
 SCRIPTED_TESTS += grub_script_echo_keywords
 SCRIPTED_TESTS += grub_script_vars1
+SCRIPTED_TESTS += grub_script_blanklines
 
 # dependencies between tests and testing-tools
 $(SCRIPTED_TESTS): grub-shell grub-shell-tester

=== added file 'tests/grub_script_blanklines.in'
--- tests/grub_script_blanklines.in	1970-01-01 00:00:00 +0000
+++ tests/grub_script_blanklines.in	2010-03-22 08:24:45 +0000
@@ -0,0 +1,14 @@
+#! /bin/sh -e
+
+@builddir@/grub-script-check <<EOF
+# comment 1
+
+command1 arg1
+
+command2 arg2
+
+
+
+last command
+# comment 2
+EOF

# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWQecVv4AAg9fgEAQeGv/918o
3wC////wUAR+6HdjDPW7KE3ZwkkppmiAyGmTKaaeqZtCYk9RtR6jE2p6gSkCnqbAST2omUzRDIDT
aACMmRhFPUPUyCZojBAYgAZGQMgNAZTVPap6hoBoAAGgGmgAAAJIggmBT1NpMajU9AgDQAyaBoYL
vt3cYaEvF8jvbuG357K/htmtRuz575SFUyU675kaGTwkoY+0OUQRUnEBFKHz0ABVXAXpiIXiBAmM
mgu3NE51/zZxOCq8sfUab9hWyOEnCvlLjVW/DXUTKk7JGi6pseG4bw5PC45PEMBgNLzZZJ7OPHoA
gsrrN5rn4oWCFJFqtp0PfqnJ7sCkDazIC7YyAvTDQd0KRzkTFNJ3U1AFPrKAkqkoNxOXCiblZ+rd
3tHS24QTjggHRQkxNY/lxiDG0e9IQXoL4x6r3pEaMCyR/uK9XvxSrGtrHeT8ow2Sy0OJicvHd4w1
00RmIqcYxBGsNwjQbeInaaa88pViL2eoeT11a70UIrpzK7QLAPIzLcp1mQjmQugCEZl95ZcarcRz
CvmjsP6aSWd2eeRIiMEYuug0fGYFwFA9JaTL1ymcLZE9WTLzAYoabQwkMrG4q5wSxa+RJMKCxu9g
TLQz1aCzVBxM0r5BVRJVKaAjm0Xzpa1gcq2GYts2AYDnGpaKUglDfaY1gWHjjEottmi61TiIPndI
62sxrlMdlU0WGETgprZNSUg5C7pKfVaZ1gp6mo9CEibHzbavUdsyF41lKuMzWczdpvbUKJwwzDbO
nvyMVyH4im/Vz3Iz5eSfB8vHl2TqO6ue69bwm61JaGyMwoOfEloESCBoOaEAQRQq78zdem7xOwEY
SDJ4vh9VO0gRmxX0vIyQQqjidmTMTbuBvN8/3M8A/BGSJPfXVNIfUvx5+UMoLRXgoGkkUL3ch9xJ
UFYm8xcyuzpy4dvdKWlq+tfdC2TGMtd/Ugsq+Y9MXiBWWWORCYYvFD8aorFqghtmuGBh/MwuJDpO
QQ9KvHcWmYrZ48kRt13ynNAW+AFhjwOivtc0DjDVZDha3q4yG5eaYJp8NerAlqjJJUoZDxv1EbjY
X1TZTMSCyynNec6TsLWXYd+JkWFgtyFsQn7ja4c6/rqUlmtnCo9ZYDKoxVwtMZdu9DQNxVisWdC4
d4oiigbzLfBDkpe2qe5QjKgx2ox23SRiw4LMqiFPQnW0O8hlsqRWg0oWkMIYnBQgm7QysETFKDLP
ptv+iF6IWdaE8cVXh0ChFKSkKAzLgRCCIMkzc0EGQEGBk/FtpMCrakE0dj1ARKelDLf1QVUkK/xL
8GGCClQHatblIJVA3AXmB+rJjWs8rpkBJqG1yJXXkjDPxyQCQchqtqWCCrmIQGFCrCwBpBRLdFxL
yvTKQ0I5igxQxsNS4tXWyoQyG6YNbc8HSc7QjqZ4vTRZ6y5sEb8rct1RqReDIg4Xugx5uE6UL/HA
qWtFCF3DG+zMXUYHsUkcamU0q5KOkD/i7kinChIA84rfwA==

Re: [PATCH] A testcase for blank lines in grub script (debian bug #572302)

[Vladimir 'φ-coder/phcoder' Serbinenko]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

BVK Chaitanya wrote:
> Hi,
>
>
> Attached is a test case for the bug #572302, blank lines being not
> accepted by grub-script.   It is also pushed into
> branches/blanklines-test branch.
>
>   
Please commit.
In general the bugfixes which are small, clear, clean and unlikely to
create other problems can go into trunk directly. The same goes for the
corresponding testcases if they should succeed on any sane platform
>   
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]