Re: [PATCH 2/7] fbdev: section cleanup in efifb

[Peter Jones <pjones@redhat.com>]

On 03/27/2010 02:29 AM, Henrik Kretzschmar wrote:
> This patch fixes the sections on the efifb driver.
> 
> WARNING: drivers/video/built-in.o(.devinit.text+0x19f8c): Section mismatch in re
> ference from the function efifb_probe() to the (unknown reference) .init.data:(u
> nknown)
> The function __devinit efifb_probe() references
> a (unknown reference) __initdata (unknown).
> If (unknown) is only used by efifb_probe then
> annotate (unknown) with a matching annotation.
> 
> WARNING: drivers/video/built-in.o(.devinit.text+0x19f9a): Section mismatch in reference from the function efifb_probe() to the (unknown reference) .init.data:(unknown)
> The function __devinit efifb_probe() references
> a (unknown reference) __initdata (unknown).
> If (unknown) is only used by efifb_probe then
> annotate (unknown) with a matching annotation.
> 
> WARNING: drivers/video/built-in.o(.devinit.text+0x19fa1): Section mismatch in reference from the function efifb_probe() to the variable .init.data:efifb_fix
> The function __devinit efifb_probe() references
> a variable __initdata efifb_fix.
> If efifb_fix is only used by efifb_probe then
> annotate efifb_fix with a matching annotation.
> 
> WARNING: drivers/video/built-in.o(.devinit.text+0x19fa7): Section mismatch in reference from the function efifb_probe() to the variable .init.data:efifb_defined
> The function __devinit efifb_probe() references
> a variable __initdata efifb_defined.
> If efifb_defined is only used by efifb_probe then
> annotate efifb_defined with a matching annotation.
> 
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>

Acked-by: Peter Jones <pjones@redhat.com>

> ---
>  drivers/video/efifb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 581d2db..6aea0d3 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -16,7 +16,7 @@
>  
>  #include <video/vga.h>
>  
> -static struct fb_var_screeninfo efifb_defined __initdata = {
> +static struct fb_var_screeninfo efifb_defined __devinitdata = {
>  	.activate		= FB_ACTIVATE_NOW,
>  	.height			= -1,
>  	.width			= -1,
> @@ -27,7 +27,7 @@ static struct fb_var_screeninfo efifb_defined __initdata = {
>  	.vmode			= FB_VMODE_NONINTERLACED,
>  };
>  
> -static struct fb_fix_screeninfo efifb_fix __initdata = {
> +static struct fb_fix_screeninfo efifb_fix __devinitdata = {
>  	.id			= "EFI VGA",
>  	.type			= FB_TYPE_PACKED_PIXELS,
>  	.accel			= FB_ACCEL_NONE,


-- 
        Peter

Sanity's just a one trick pony anyway.  You only get one trick -- rational
thinking -- but when you're good and crazy, the sky's the limit!
		-- The Tick