From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ethtool: RXHASH flag support
Date: Tue, 30 Mar 2010 13:37:13 -0400 [thread overview]
Message-ID: <4BB236C9.7080300@garzik.org> (raw)
In-Reply-To: <20100330103207.7fc5681a@nehalam>
On 03/30/2010 01:32 PM, Stephen Hemminger wrote:
> On Tue, 30 Mar 2010 13:29:01 -0400
> Jeff Garzik<jeff@garzik.org> wrote:
>
>> By blindly sync'ing the ethtool.h header, ETHTOOL_MAX_NTUPLE_LIST_ENTRY
>> and its sibling ETHTOOL_MAX_NTUPLE_STRING_PER_ENTRY were removed,
>> breaking the ethtool build.
>
> In the patch I moved it to ethtool.c to have local entries.
>
> I believe that all cloned headers should only come from the result
> of kernel "make install_headers". Not locally different vrsions.
There is nothing locally different about ethtool-copy.h.
Jeff
next prev parent reply other threads:[~2010-03-30 17:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-28 22:44 [PATCH 1/2] netdev: add support for Receive Side Scaling hash control Stephen Hemminger
2010-03-28 22:47 ` [PATCH 2/2] ethtool: add RSS command flag Stephen Hemminger
2010-03-30 0:47 ` [PATCH 1/2] netdev: ethtool RXHASH flag Stephen Hemminger
2010-03-30 0:53 ` [PATCH 2/2] ethtool: RXHASH flag support Stephen Hemminger
2010-03-30 17:29 ` Jeff Garzik
2010-03-30 17:32 ` Stephen Hemminger
2010-03-30 17:37 ` Jeff Garzik [this message]
2010-03-30 21:05 ` Stephen Hemminger
2010-03-30 21:08 ` Jeff Garzik
2010-03-30 21:31 ` Stephen Hemminger
2010-03-30 22:58 ` Jeff Garzik
2010-03-30 17:19 ` [PATCH 1/2] netdev: ethtool RXHASH flag Jeff Garzik
2010-03-31 6:52 ` David Miller
2010-03-31 6:52 ` [PATCH 1/2] netdev: add support for Receive Side Scaling hash control David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB236C9.7080300@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.