From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: [RFC][PATCH][WIP] b43: N-PHY: set band width
Date: Tue, 30 Mar 2010 13:06:53 -0500 [thread overview]
Message-ID: <4BB23DBD.8080904@lwfinger.net> (raw)
In-Reply-To: <1269971657-4663-1-git-send-email-zajec5@gmail.com>
On 03/30/2010 12:54 PM, Rafa? Mi?ecki wrote:
> ---
> I've problem with deciding how to keep some data needed by band width setting
> code. Generally these band width-related routines are considered "common", to
> be used by more than just N-PHY. So probably the most /correct/ way should be
> to add some variables like maccontrol, wake_override, clk and other to struct
> b43_phy which is shared between all PHYs. However we would not use these vars
> in anything except N-PHY, so we would just waste users memory.
>
> Could you help me decide correct way to handle this?
I have not done the RE yet, but the SSLPN PHY is multi-band and will likely need
all the band width parameters needed by the N PHY. I would vote for putting them
in a "common" struct.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org
Subject: Re: [RFC][PATCH][WIP] b43: N-PHY: set band width
Date: Tue, 30 Mar 2010 13:06:53 -0500 [thread overview]
Message-ID: <4BB23DBD.8080904@lwfinger.net> (raw)
In-Reply-To: <1269971657-4663-1-git-send-email-zajec5@gmail.com>
On 03/30/2010 12:54 PM, Rafał Miłecki wrote:
> ---
> I've problem with deciding how to keep some data needed by band width setting
> code. Generally these band width-related routines are considered "common", to
> be used by more than just N-PHY. So probably the most /correct/ way should be
> to add some variables like maccontrol, wake_override, clk and other to struct
> b43_phy which is shared between all PHYs. However we would not use these vars
> in anything except N-PHY, so we would just waste users memory.
>
> Could you help me decide correct way to handle this?
I have not done the RE yet, but the SSLPN PHY is multi-band and will likely need
all the band width parameters needed by the N PHY. I would vote for putting them
in a "common" struct.
Larry
next prev parent reply other threads:[~2010-03-30 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 17:54 [RFC][PATCH][WIP] b43: N-PHY: set band width Rafał Miłecki
2010-03-30 18:06 ` Larry Finger [this message]
2010-03-30 18:06 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB23DBD.8080904@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.