From: Jiri Slaby <jirislaby@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mxser: spin_lock() => spin_lock_irq()
Date: Thu, 01 Apr 2010 16:52:37 +0000 [thread overview]
Message-ID: <4BB4CF55.8000400@gmail.com> (raw)
In-Reply-To: <20100401155143.GC5265@bicker>
On 04/01/2010 05:51 PM, Dan Carpenter wrote:
> This should be spin_lock_irq() to match the spin_unlock_irq().
> Originally it was a lock_kernel() but we switched everything to
> spin_lock_irq() last November.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index e0c5d2a..ecb2d8b 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -1768,7 +1768,7 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file,
> int len, lsr;
>
> len = mxser_chars_in_buffer(tty);
> - spin_lock(&info->slock);
> + spin_lock_irq(&info->slock);
Hmm, and there is one more error in the MOXA_ASPP_MON case. Interrupts
are not disabled at all there. Could you fix that too?
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: Dan Carpenter <error27@gmail.com>,
Alan Cox <alan@linux.intel.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mxser: spin_lock() => spin_lock_irq()
Date: Thu, 01 Apr 2010 18:52:37 +0200 [thread overview]
Message-ID: <4BB4CF55.8000400@gmail.com> (raw)
In-Reply-To: <20100401155143.GC5265@bicker>
On 04/01/2010 05:51 PM, Dan Carpenter wrote:
> This should be spin_lock_irq() to match the spin_unlock_irq().
> Originally it was a lock_kernel() but we switched everything to
> spin_lock_irq() last November.
>
> Signed-off-by: Dan Carpenter<error27@gmail.com>
>
> diff --git a/drivers/char/mxser.c b/drivers/char/mxser.c
> index e0c5d2a..ecb2d8b 100644
> --- a/drivers/char/mxser.c
> +++ b/drivers/char/mxser.c
> @@ -1768,7 +1768,7 @@ static int mxser_ioctl(struct tty_struct *tty, struct file *file,
> int len, lsr;
>
> len = mxser_chars_in_buffer(tty);
> - spin_lock(&info->slock);
> + spin_lock_irq(&info->slock);
Hmm, and there is one more error in the MOXA_ASPP_MON case. Interrupts
are not disabled at all there. Could you fix that too?
Thanks.
next prev parent reply other threads:[~2010-04-01 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 15:51 [patch] mxser: spin_lock() => spin_lock_irq() Dan Carpenter
2010-04-01 15:51 ` Dan Carpenter
2010-04-01 16:52 ` Jiri Slaby [this message]
2010-04-01 16:52 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB4CF55.8000400@gmail.com \
--to=jirislaby@gmail.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=error27@gmail.com \
--cc=gregkh@suse.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.