From: Larry Finger <Larry.Finger@lwfinger.net>
To: "richardvoigt@gmail.com" <richardvoigt@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org,
"Myhailo Danylenko" <isbear@ukrpost.net>
Subject: [PATCH] b43: N-PHY: fix copy&paste typo
Date: Thu, 01 Apr 2010 18:12:39 -0500 [thread overview]
Message-ID: <4BB52867.4080304@lwfinger.net> (raw)
In-Reply-To: <m2y2e59e6971004011605oc44de860q87948992252fbac2@mail.gmail.com>
On 04/01/2010 06:05 PM, richardvoigt at gmail.com wrote:
> Does anybody else think all the magic numbers make this code hard to understand?
>
> 2010/4/1 Rafa? Mi?ecki <zajec5@gmail.com>:
>> Reported-by: Myhailo Danylenko <isbear@ukrpost.net>
>> Signed-off-by: Rafa? Mi?ecki <zajec5@gmail.com>
>> ---
>> drivers/net/wireless/b43/phy_n.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
>> index 6fd140a..2ae2445 100644
>> --- a/drivers/net/wireless/b43/phy_n.c
>> +++ b/drivers/net/wireless/b43/phy_n.c
>> @@ -2790,7 +2790,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
>> }
>> b43_ntab_write_bulk(dev, B43_NTAB16(15, 88), 4,
If you have any idea what the 16-bit N PHY table 15 with offset 88 and
length 4 means to the firmware, please be our guest. All those us that
do the RE can only decompile the Broadcom driver, and write the specs.
Rafal writes the b43 code from that.
Larry
WARNING: multiple messages have this Message-ID (diff)
From: Larry Finger <Larry.Finger@lwfinger.net>
To: "richardvoigt@gmail.com" <richardvoigt@gmail.com>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>,
b43-dev@lists.infradead.org,
"Myhailo Danylenko" <isbear@ukrpost.net>
Subject: Re: [PATCH] b43: N-PHY: fix copy&paste typo
Date: Thu, 01 Apr 2010 18:12:39 -0500 [thread overview]
Message-ID: <4BB52867.4080304@lwfinger.net> (raw)
In-Reply-To: <m2y2e59e6971004011605oc44de860q87948992252fbac2@mail.gmail.com>
On 04/01/2010 06:05 PM, richardvoigt@gmail.com wrote:
> Does anybody else think all the magic numbers make this code hard to understand?
>
> 2010/4/1 Rafał Miłecki <zajec5@gmail.com>:
>> Reported-by: Myhailo Danylenko <isbear@ukrpost.net>
>> Signed-off-by: Rafał Miłecki <zajec5@gmail.com>
>> ---
>> drivers/net/wireless/b43/phy_n.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
>> index 6fd140a..2ae2445 100644
>> --- a/drivers/net/wireless/b43/phy_n.c
>> +++ b/drivers/net/wireless/b43/phy_n.c
>> @@ -2790,7 +2790,7 @@ static int b43_nphy_cal_tx_iq_lo(struct b43_wldev *dev,
>> }
>> b43_ntab_write_bulk(dev, B43_NTAB16(15, 88), 4,
If you have any idea what the 16-bit N PHY table 15 with offset 88 and
length 4 means to the firmware, please be our guest. All those us that
do the RE can only decompile the Broadcom driver, and write the specs.
Rafal writes the b43 code from that.
Larry
next prev parent reply other threads:[~2010-04-01 23:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 21:11 [PATCH] b43: N-PHY: fix copy&paste typo Rafał Miłecki
2010-04-01 21:11 ` Rafał Miłecki
2010-04-01 23:05 ` richardvoigt at gmail.com
2010-04-01 23:05 ` richardvoigt
2010-04-01 23:12 ` Larry Finger [this message]
2010-04-01 23:12 ` Larry Finger
2010-04-02 7:28 ` Michael Buesch
2010-04-02 7:28 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB52867.4080304@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=isbear@ukrpost.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=richardvoigt@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.