Re: [Qemu-devel] [BREAKAGE] commit 9bc6304c156dcc01c619672ca33d7152bb18bcb9 breaks build

[Stefan Weil <weil@mail.berlios.de>]

Blue Swirl schrieb:
> On 4/2/10, Roy Tam <roytam@gmail.com> wrote:
>> 2010/4/2 Anthony Liguori <anthony@codemonkey.ws>:
>>
>>> Try doing a clean build
>>
>> This is a fresh checkout.
>
> I can confirm this with mingw32:
> LINK sparc64-softmmu/qemu-system-sparc64.exe
> virtio-net.o: In function `virtio_net_exit':
> /src/qemu/hw/virtio-net.c:943: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_save':
> /src/qemu/hw/virtio-net.c:719: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_reset':
> /src/qemu/hw/virtio-net.c:122: undefined reference to `_tap_get_vhost_net'
> virtio-net.o: In function `virtio_net_set_status':
> /src/qemu/hw/virtio-net.c:863: undefined reference to `_tap_get_vhost_net'
> /src/qemu/hw/virtio-net.c:870: undefined reference to `_tap_get_vhost_net'
> virtio-net.o:/src/qemu/hw/virtio-net.c:878: more undefined references
> to `_tap_get_vhost_net' follow
> collect2: ld returned 1 exit status

A cross build (mingw32 on debian) also results in this linker error.
The reason is quite simple: tap.o (which provides tap_get_vhost_net)
is only build for posix systems, but not for windows:

Makefile.objs:net-nested-$(CONFIG_POSIX) += tap.o

Changing this does not help because tap.c does not
compile for win32 without errors. Either these errors
have to be fixed, or don't call tap_get_vhost_net when
compiling for win32.

Stefan