All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 1/2] Move KVM init to arch_init.c, compile  vl.c once
Date: Fri, 02 Apr 2010 10:20:41 -0500	[thread overview]
Message-ID: <4BB60B49.5040407@codemonkey.ws> (raw)
In-Reply-To: <4BB60921.5050906@redhat.com>

On 04/02/2010 10:11 AM, Paolo Bonzini wrote:
> On 04/02/2010 05:08 PM, Anthony Liguori wrote:
>> Having kvm-all.c compile with and without CONFIG_KVM is pretty ugly 
>> IMHO.
>>
>> Is compiling vl.c once really that important of a goal?
>
> I didn't do this to compile vl.c once.  I don't care about that.
>
> I did this as an initial step towards having kvm functions stubbed out 
> for !CONFIG_KVM, instead of relying on GCC performing 
> dead-code-elimination on kvm_enabled().

I'd prefer a kvm-stub.c implementation as opposed to mixing in 
CONFIG_KVM in kvm-all.c

Regards,

Anthony Liguori

> Paolo

  reply	other threads:[~2010-04-02 15:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-01 20:07 [Qemu-devel] [PATCH 1/2] Move KVM init to arch_init.c, compile vl.c once Blue Swirl
2010-04-01 20:15 ` Anthony Liguori
2010-04-01 20:27   ` Blue Swirl
2010-04-02 15:01     ` [Qemu-devel] " Paolo Bonzini
2010-04-02 15:08       ` Anthony Liguori
2010-04-02 15:11         ` Paolo Bonzini
2010-04-02 15:20           ` Anthony Liguori [this message]
2010-04-02 16:01             ` Paolo Bonzini
2010-04-02 15:43         ` Blue Swirl
2010-04-01 20:23 ` Paolo Bonzini
2010-04-02 14:20   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB60B49.5040407@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=blauwirbel@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.