All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Tom Tucker <tom@ogc.us>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
	Steve Wise <swise@opengridcomputing.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH] svcrdma: RDMA support not yet compatible with RPC6
Date: Mon, 05 Apr 2010 10:55:12 -0400	[thread overview]
Message-ID: <4BB9F9D0.1040203@oracle.com> (raw)
In-Reply-To: <4BB74241.4060308@ogc.us>

On 04/03/2010 09:27 AM, Tom Tucker wrote:
> RPC6 requires that it be possible to create endpoints that listen
> exclusively for IPv4 or IPv6 connection requests. This is not currently
> supported by the RDMA API.
>
> Signed-off-by: Tom Tucker<tom@opengridcomputing.com>
> Tested-by: Steve Wise<swise@opengridcomputing.com>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

> ---
>
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 3fa5751..4e6bbf9 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -678,7 +678,10 @@ static struct svc_xprt *svc_rdma_create(struct
> svc_serv *serv,
> int ret;
>
> dprintk("svcrdma: Creating RDMA socket\n");
> -
> + if (sa->sa_family != AF_INET) {
> + dprintk("svcrdma: Address family %d is not supported.\n", sa->sa_family);
> + return ERR_PTR(-EAFNOSUPPORT);
> + }
> cma_xprt = rdma_create_xprt(serv, 1);
> if (!cma_xprt)
> return ERR_PTR(-ENOMEM);
>


-- 
chuck[dot]lever[at]oracle[dot]com

WARNING: multiple messages have this Message-ID (diff)
From: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Tom Tucker <tom-/Yg/VP3ZvrM@public.gmane.org>
Cc: "J. Bruce Fields"
	<bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>,
	Steve Wise
	<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
	"linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] svcrdma: RDMA support not yet compatible with RPC6
Date: Mon, 05 Apr 2010 10:55:12 -0400	[thread overview]
Message-ID: <4BB9F9D0.1040203@oracle.com> (raw)
In-Reply-To: <4BB74241.4060308-/Yg/VP3ZvrM@public.gmane.org>

On 04/03/2010 09:27 AM, Tom Tucker wrote:
> RPC6 requires that it be possible to create endpoints that listen
> exclusively for IPv4 or IPv6 connection requests. This is not currently
> supported by the RDMA API.
>
> Signed-off-by: Tom Tucker<tom-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Tested-by: Steve Wise<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>

Reviewed-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

> ---
>
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 3fa5751..4e6bbf9 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -678,7 +678,10 @@ static struct svc_xprt *svc_rdma_create(struct
> svc_serv *serv,
> int ret;
>
> dprintk("svcrdma: Creating RDMA socket\n");
> -
> + if (sa->sa_family != AF_INET) {
> + dprintk("svcrdma: Address family %d is not supported.\n", sa->sa_family);
> + return ERR_PTR(-EAFNOSUPPORT);
> + }
> cma_xprt = rdma_create_xprt(serv, 1);
> if (!cma_xprt)
> return ERR_PTR(-ENOMEM);
>


-- 
chuck[dot]lever[at]oracle[dot]com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-04-05 14:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-03 13:27 [PATCH] svcrdma: RDMA support not yet compatible with RPC6 Tom Tucker
2010-04-03 13:27 ` Tom Tucker
2010-04-05 14:55 ` Chuck Lever [this message]
2010-04-05 14:55   ` Chuck Lever
2010-04-05 15:48   ` J. Bruce Fields
2010-04-05 15:48     ` J. Bruce Fields
2010-04-05 15:49     ` Chuck Lever
2010-04-05 15:49       ` Chuck Lever
2010-04-05 15:50     ` Tom Tucker
2010-04-05 15:50       ` Tom Tucker
2010-04-05 16:16       ` J. Bruce Fields
2010-04-05 16:16         ` J. Bruce Fields
2010-04-05 16:20         ` J. Bruce Fields
2010-04-05 16:20           ` J. Bruce Fields
2010-04-05 16:19           ` Tom Tucker
2010-04-05 16:19             ` Tom Tucker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB9F9D0.1040203@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    --cc=tom@ogc.us \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.