From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: split raw_getlength
Date: Tue, 06 Apr 2010 11:36:15 +0200 [thread overview]
Message-ID: <4BBB008F.1000802@redhat.com> (raw)
In-Reply-To: <20100405141257.GB24646@lst.de>
Am 05.04.2010 16:12, schrieb Christoph Hellwig:
> Split up the raw_getlength into separate generic, solaris and BSD
> versions to reduce the ifdef maze a bit. The BSD variant still
> is a complete maze, but to clean it up properly we'd need some
> people using the BSD variants to figure out what code is used
> for what variant.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Seems to leave some duplicate #ifdef CONFIG_BSD around, but that code is
a mess anyway and maybe it's the bit of additional ugliness that makes
someone of the BSD people clean it up. Anyway, it's definitely an
improvement over the current code.
Acked-by: Kevin Wolf <kwolf@redhat.com>
prev parent reply other threads:[~2010-04-06 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-05 14:12 [Qemu-devel] [PATCH] block: split raw_getlength Christoph Hellwig
2010-04-06 9:36 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBB008F.1000802@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.