From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images
Date: Thu, 08 Apr 2010 09:53:16 +0200 [thread overview]
Message-ID: <4BBD8B6C.1060207@redhat.com> (raw)
In-Reply-To: <v2hfbd9d3991004070802y4f937494w714929279b840ba4@mail.gmail.com>
Am 07.04.2010 17:02, schrieb Stefan Hajnoczi:
> On Wed, Apr 7, 2010 at 12:57 PM, Christoph Hellwig <hch@lst.de> wrote:
>> Various obscure image format drivers do not allow write access.
>> Instead of silently falling back to read-only access reject attempts
>> to open these images for write access.
>
> Does block/curl.c need this too?
Yes, looks like it. It even fails to declare itself readonly like those
other formats do currently. One more argument for doing it in a central
place where no driver would be missed.
Kevin
prev parent reply other threads:[~2010-04-08 7:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 11:57 [Qemu-devel] [PATCH] block: reject O_RDWR open for read-only images Christoph Hellwig
2010-04-07 12:32 ` Kevin Wolf
2010-04-23 16:09 ` Kevin Wolf
2010-04-23 16:19 ` Christoph Hellwig
2010-04-07 15:02 ` Stefan Hajnoczi
2010-04-08 7:53 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBD8B6C.1060207@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.