From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] Fix the drivers/media/dvb/ttpci/budget-ci.c conversion to ir-core
Date: Thu, 08 Apr 2010 20:11:51 -0300 [thread overview]
Message-ID: <4BBE62B7.9010807@redhat.com> (raw)
In-Reply-To: <20100408230425.14453.62639.stgit@localhost.localdomain>
Hi David,
David Härdeman wrote:
> When I converted drivers/media/dvb/ttpci/budget-ci.c to use ir-core
> I missed one line. This patch fixes that mistake.
I did this already (I merged with your commit, at v4l-dvb.git), to avoid
breaking git bisect. I'll backport it to the ir.git tree after finishing
to process my loooong patchwork queue. (I'll probably just create a new
branch there from v4l-dvb.git - since I've merged all ir-related patches
there already).
Cheers,
Mauro
PS.: As you can see, stgit did the right thing with inline ;)
>
> Signed-off-by: David Härdeman <david@hardeman.nu>
> ---
> drivers/media/dvb/ttpci/budget-ci.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
> index 8950df1..4617143 100644
> --- a/drivers/media/dvb/ttpci/budget-ci.c
> +++ b/drivers/media/dvb/ttpci/budget-ci.c
> @@ -225,8 +225,6 @@ static int msp430_ir_init(struct budget_ci *budget_ci)
> break;
> }
>
> - ir_input_init(input_dev, &budget_ci->ir.state, IR_TYPE_RC5);
> -
> error = ir_input_register(input_dev, ir_codes, NULL, MODULE_NAME);
> if (error) {
> printk(KERN_ERR "budget_ci: could not init driver for IR device (code %d)\n", error);
>
--
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "David Härdeman" <david@hardeman.nu>
Cc: linux-input@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/4] Fix the drivers/media/dvb/ttpci/budget-ci.c conversion to ir-core
Date: Thu, 08 Apr 2010 20:11:51 -0300 [thread overview]
Message-ID: <4BBE62B7.9010807@redhat.com> (raw)
In-Reply-To: <20100408230425.14453.62639.stgit@localhost.localdomain>
Hi David,
David Härdeman wrote:
> When I converted drivers/media/dvb/ttpci/budget-ci.c to use ir-core
> I missed one line. This patch fixes that mistake.
I did this already (I merged with your commit, at v4l-dvb.git), to avoid
breaking git bisect. I'll backport it to the ir.git tree after finishing
to process my loooong patchwork queue. (I'll probably just create a new
branch there from v4l-dvb.git - since I've merged all ir-related patches
there already).
Cheers,
Mauro
PS.: As you can see, stgit did the right thing with inline ;)
>
> Signed-off-by: David Härdeman <david@hardeman.nu>
> ---
> drivers/media/dvb/ttpci/budget-ci.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
> index 8950df1..4617143 100644
> --- a/drivers/media/dvb/ttpci/budget-ci.c
> +++ b/drivers/media/dvb/ttpci/budget-ci.c
> @@ -225,8 +225,6 @@ static int msp430_ir_init(struct budget_ci *budget_ci)
> break;
> }
>
> - ir_input_init(input_dev, &budget_ci->ir.state, IR_TYPE_RC5);
> -
> error = ir_input_register(input_dev, ir_codes, NULL, MODULE_NAME);
> if (error) {
> printk(KERN_ERR "budget_ci: could not init driver for IR device (code %d)\n", error);
>
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-04-08 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 23:04 [PATCH 0/4] ir-core: one-line bugfix, add RC5x, NECx, RC6 David Härdeman
2010-04-08 23:04 ` [PATCH 1/4] Fix the drivers/media/dvb/ttpci/budget-ci.c conversion to ir-core David Härdeman
2010-04-08 23:04 ` David Härdeman
2010-04-08 23:11 ` Mauro Carvalho Chehab [this message]
2010-04-08 23:11 ` Mauro Carvalho Chehab
2010-04-08 23:04 ` [PATCH 2/4] Add RC5x support " David Härdeman
2010-04-08 23:04 ` David Härdeman
2010-04-08 23:04 ` [PATCH 3/4] Add NECx " David Härdeman
2010-04-08 23:04 ` [PATCH 4/4] Add RC6 " David Härdeman
2010-04-09 8:17 ` Andreas Oberritter
2010-04-09 8:17 ` Andreas Oberritter
2010-04-09 8:31 ` David Härdeman
2010-04-09 12:43 ` Mauro Carvalho Chehab
2010-04-09 12:43 ` Mauro Carvalho Chehab
2010-04-10 1:12 ` Andy Walls
2010-04-10 19:52 ` David Härdeman
2010-04-10 21:19 ` Andy Walls
2010-04-10 21:19 ` Andy Walls
2010-04-10 22:23 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE62B7.9010807@redhat.com \
--to=mchehab@redhat.com \
--cc=david@hardeman.nu \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.