From: Jeff Mahoney <jeffm@suse.com>
To: Matt McCutchen <matt@mattmccutchen.net>
Cc: ReiserFS Mailing List <reiserfs-devel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Edward Shishkin <edward.shishkin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv
Date: Thu, 08 Apr 2010 20:04:28 -0400 [thread overview]
Message-ID: <4BBE6F0C.6020207@suse.com> (raw)
In-Reply-To: <1270766367.3441.4.camel@mattlaptop2.local>
On 04/08/2010 06:39 PM, Matt McCutchen wrote:
> On Thu, 2010-04-08 at 23:38 +0200, Edward Shishkin wrote:
>> Jeff Mahoney wrote:
>>> [...] This patch resolves the issue by properly hiding .reiserfs_priv. This
>>> was the intent of the xattr poisoning code, but it appears to have
>>> never worked as expected. This is fixed by using d_revalidate instead
>>> of d_compare. [...]
>
> The patch seems to rely on the fact that the priv_root dentry is stuck
> in the dcache for as long as the filesystem is mounted, so that attempts
> to follow ".reiserfs_priv" are guaranteed to match that dentry in the
> cache and be refused by xattr_hide_revalidate. Is my understanding
> correct?
>
Yes. The other half of it is that the priv_root dentry being stuck in
the dcache for as long as the flie system is mounted is a guaranteed
since REISERFS_SB(sb) holds a reference to it until reiserfs_kill_sb is
called.
-Jeff
--
Jeff Mahoney
SuSE Labs
prev parent reply other threads:[~2010-04-09 0:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 20:55 [PATCH #3] reiserfs: Fix permissions on .reiserfs_priv Jeff Mahoney
2010-04-08 21:38 ` Edward Shishkin
2010-04-08 22:39 ` Matt McCutchen
2010-04-09 0:04 ` Jeff Mahoney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BBE6F0C.6020207@suse.com \
--to=jeffm@suse.com \
--cc=akpm@linux-foundation.org \
--cc=edward.shishkin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@mattmccutchen.net \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.