All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Jayamohan Kalickal <jayamohank@serverengines.com>
Cc: linux-scsi@vger.kernel.org, James.Bottomley@suse.de
Subject: Re: Proposal for BSG Interface -V2
Date: Sat, 10 Apr 2010 05:27:39 -0500	[thread overview]
Message-ID: <4BC0529B.5040206@cs.wisc.edu> (raw)
In-Reply-To: <20100330234759.GA5874@serverengines.com>

On 03/30/2010 06:48 PM, Jayamohan Kallickal wrote:
> 	Have modified the code as per code review provided to
> remove Generic VENDOR opcode in the driver
>

You forgot to remove that code from the class code, and you forgot to 
use kmap like we talked about.

I just sent a patch to try and make the fc bsg code a lib, so try that 
out. For the iscsi code I think it just needs a fix up to sg_virt code 
(should be using kmap) and it needs a kfree on the completion path 
(looks like your patch was leaking what is in the va pointer and I did 
not fix that yet).

      reply	other threads:[~2010-04-10 10:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 23:48 Proposal for BSG Interface -V2 Jayamohan Kallickal
2010-04-10 10:27 ` Mike Christie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BC0529B.5040206@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=James.Bottomley@suse.de \
    --cc=jayamohank@serverengines.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.