* Proposal for BSG Interface -V2
@ 2010-03-30 23:48 Jayamohan Kallickal
2010-04-10 10:27 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Jayamohan Kallickal @ 2010-03-30 23:48 UTC (permalink / raw)
To: linux-scsi; +Cc: James.Bottomley, michaelc
Have modified the code as per code review provided to
remove Generic VENDOR opcode in the driver
These patches are made over the latest scsi-misc tree.
Signed-off-by: Jayamohan Kallickal <jayamohank@serverengines.com>
---
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Proposal for BSG Interface -V2
2010-03-30 23:48 Proposal for BSG Interface -V2 Jayamohan Kallickal
@ 2010-04-10 10:27 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2010-04-10 10:27 UTC (permalink / raw)
To: Jayamohan Kalickal; +Cc: linux-scsi, James.Bottomley
On 03/30/2010 06:48 PM, Jayamohan Kallickal wrote:
> Have modified the code as per code review provided to
> remove Generic VENDOR opcode in the driver
>
You forgot to remove that code from the class code, and you forgot to
use kmap like we talked about.
I just sent a patch to try and make the fc bsg code a lib, so try that
out. For the iscsi code I think it just needs a fix up to sg_virt code
(should be using kmap) and it needs a kfree on the completion path
(looks like your patch was leaking what is in the va pointer and I did
not fix that yet).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-10 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-30 23:48 Proposal for BSG Interface -V2 Jayamohan Kallickal
2010-04-10 10:27 ` Mike Christie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.