From: Avi Kivity <avi@redhat.com>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [PATCH v4] Shared memory uio_pci driver
Date: Mon, 12 Apr 2010 23:57:56 +0300 [thread overview]
Message-ID: <4BC38954.2000507@redhat.com> (raw)
In-Reply-To: <1270681258-9042-1-git-send-email-cam@cs.ualberta.ca>
On 04/08/2010 02:00 AM, Cam Macdonell wrote:
> This patch adds a driver for my shared memory PCI device using the uio_pci
> interface. The driver has three memory regions. The first memory region is for
> device registers for sending interrupts. The second BAR is for receiving MSI-X
> interrupts and the third memory region maps the shared memory. The device only
> exports the first and third memory regions to userspace.
>
> This driver supports MSI-X and regular pin interrupts. Currently, the number
> of MSI vectors is set to 2 (one for new connections and the other for
> interrupts) but it could easily be increased. If MSI is not available, then
> regular interrupts will be used.
>
> This version added formatting and style corrections as well as better
> error-checking and cleanup when errors occur.
>
>
There is work now to bring msi to the generic pci 2.3 driver, perhaps we
can use that instead. From a quick look it looks fine.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi@redhat.com>
To: Cam Macdonell <cam@cs.ualberta.ca>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH v4] Shared memory uio_pci driver
Date: Mon, 12 Apr 2010 23:57:56 +0300 [thread overview]
Message-ID: <4BC38954.2000507@redhat.com> (raw)
In-Reply-To: <1270681258-9042-1-git-send-email-cam@cs.ualberta.ca>
On 04/08/2010 02:00 AM, Cam Macdonell wrote:
> This patch adds a driver for my shared memory PCI device using the uio_pci
> interface. The driver has three memory regions. The first memory region is for
> device registers for sending interrupts. The second BAR is for receiving MSI-X
> interrupts and the third memory region maps the shared memory. The device only
> exports the first and third memory regions to userspace.
>
> This driver supports MSI-X and regular pin interrupts. Currently, the number
> of MSI vectors is set to 2 (one for new connections and the other for
> interrupts) but it could easily be increased. If MSI is not available, then
> regular interrupts will be used.
>
> This version added formatting and style corrections as well as better
> error-checking and cleanup when errors occur.
>
>
There is work now to bring msi to the generic pci 2.3 driver, perhaps we
can use that instead. From a quick look it looks fine.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2010-04-12 20:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-07 22:51 [PATCH v4 0/3] PCI Shared memory device Cam Macdonell
2010-04-07 22:51 ` [Qemu-devel] " Cam Macdonell
2010-04-07 22:51 ` [PATCH v4 1/3] Device specification for shared memory PCI device Cam Macdonell
2010-04-07 22:51 ` [Qemu-devel] " Cam Macdonell
2010-04-07 22:51 ` [PATCH v4 2/3] Support adding a file to qemu's ram allocation Cam Macdonell
2010-04-07 22:51 ` [Qemu-devel] " Cam Macdonell
2010-04-07 22:52 ` [PATCH v4 3/3] Inter-VM shared memory PCI device Cam Macdonell
2010-04-07 22:52 ` [Qemu-devel] " Cam Macdonell
2010-04-12 20:56 ` Avi Kivity
2010-04-12 20:56 ` [Qemu-devel] " Avi Kivity
2010-04-14 23:30 ` Cam Macdonell
2010-04-14 23:30 ` [Qemu-devel] " Cam Macdonell
2010-04-15 8:33 ` Avi Kivity
2010-04-15 8:33 ` [Qemu-devel] " Avi Kivity
2010-04-12 20:38 ` [PATCH v4 2/3] Support adding a file to qemu's ram allocation Avi Kivity
2010-04-12 20:38 ` [Qemu-devel] " Avi Kivity
2010-04-07 23:00 ` [PATCH v4] Shared memory uio_pci driver Cam Macdonell
2010-04-07 23:00 ` [Qemu-devel] " Cam Macdonell
2010-04-12 20:57 ` Avi Kivity [this message]
2010-04-12 20:57 ` [Qemu-devel] " Avi Kivity
2010-04-23 17:45 ` Cam Macdonell
2010-04-23 17:45 ` [Qemu-devel] " Cam Macdonell
2010-04-24 9:28 ` Avi Kivity
2010-04-24 9:28 ` [Qemu-devel] " Avi Kivity
2010-04-12 20:34 ` [PATCH v4 1/3] Device specification for shared memory PCI device Avi Kivity
2010-04-12 20:34 ` [Qemu-devel] " Avi Kivity
2010-04-12 21:11 ` Cam Macdonell
2010-04-12 21:11 ` [Qemu-devel] " Cam Macdonell
2010-04-12 21:17 ` [PATCH v4 0/3] PCI Shared memory device Michael S. Tsirkin
2010-04-12 21:17 ` [Qemu-devel] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC38954.2000507@redhat.com \
--to=avi@redhat.com \
--cc=cam@cs.ualberta.ca \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.