Re: [PATCH 8/10] pdc202xx_old: implement test_irq() method (take 2)

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello, I wrote:

> Implement test_irq() method based on the driver's former dma_test_irq() method.
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> The patch is atop of ide-2.6.git 'for-next' branch.
> Hopefully it won't break the driver -- previosly the bits have been effectively
> ignored...
>
> Changes sice previos take:
> - decided to document the register bits...
>
>  drivers/ide/pdc202xx_old.c |   22 ++++++++++++++++++++++
>  1 files changed, 22 insertions(+)
>
> Index: ide-2.6/drivers/ide/pdc202xx_old.c
> ===================================================================
> --- ide-2.6.orig/drivers/ide/pdc202xx_old.c
> +++ ide-2.6/drivers/ide/pdc202xx_old.c
>   
[...]
> @@ -231,6 +252,7 @@ static void __devinit pdc202ata4_fixup_i
>  static const struct ide_port_ops pdc20246_port_ops = {
>  	.set_pio_mode		= pdc202xx_set_pio_mode,
>  	.set_dma_mode		= pdc202xx_set_mode,
> +	.test_irq		= pdc202xx_test_irq,
>  };
>  
>  static const struct ide_port_ops pdc2026x_port_ops = {
>   

   Ugh, I forgot to modify this structure, it seems... no wonder Russell 
has emphasized that the bug he's fixed only concerns PDC2024x. :-)

WBR, Sergei