From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Changli Gao <xiaosuo@gmail.com>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding.
Date: Tue, 13 Apr 2010 15:25:07 +0200 [thread overview]
Message-ID: <4BC470B3.4030007@trash.net> (raw)
In-Reply-To: <1271164991.16881.346.camel@edumazet-laptop>
Eric Dumazet wrote:
> Le mardi 13 avril 2010 à 21:09 +0800, Changli Gao a écrit :
>> On Tue, Apr 13, 2010 at 8:44 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>>> Thats theory. And for sparse arrays, that pro might be true.
>>> In your case, you prealloc all the array, using more ram than vmalloc...
>>>
>> I prealloc all the arrays, because all of them are needed later in any way.
>>
>
> Yes, that is why vmalloc() is perfect for this case. No extra memory for
> management, but one pointer for each page of memory.
I agree, if it works for conntrack, it certainly also works for
nfnetlink_queue.
--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-04-13 13:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 4:13 [PATCH 3/3] nfnetlink_queue: use hash table to speed up entry finding Changli Gao
2010-04-09 4:50 ` Eric Dumazet
2010-04-13 10:09 ` Patrick McHardy
2010-04-13 11:06 ` Changli Gao
2010-04-13 12:44 ` Eric Dumazet
2010-04-13 13:02 ` Changli Gao
2010-04-13 13:09 ` Changli Gao
2010-04-13 13:23 ` Eric Dumazet
2010-04-13 13:25 ` Patrick McHardy [this message]
2010-04-15 6:53 ` Changli Gao
2010-04-15 8:23 ` Eric Dumazet
2010-04-15 8:30 ` Changli Gao
2010-04-15 10:36 ` Patrick McHardy
2010-04-15 14:35 ` Changli Gao
2010-04-15 14:40 ` Patrick McHardy
2010-04-15 14:46 ` Patrick McHardy
2010-04-15 15:01 ` Changli Gao
2010-04-15 15:05 ` Patrick McHardy
2010-04-15 15:11 ` Changli Gao
2010-04-15 15:35 ` Patrick McHardy
2010-04-16 13:50 ` Changli Gao
2010-04-16 15:30 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BC470B3.4030007@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.